Issues in Gumroad.php (master) - Issues in master - Alofoxx/oauth2-gumroad - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Provider/Gumroad.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * Gumroad OAuth2 Provider
 * (c) alofoxx
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Alofoxx\OAuth2\Client\Provider;

use League\OAuth2\Client\Provider\AbstractProvider;
use League\OAuth2\Client\Token\AccessToken;
use League\OAuth2\Client\Tool\BearerAuthorizationTrait;
use Alofoxx\OAuth2\Client\Provider\Exception\GumroadIdentityProviderException;
use Psr\Http\Message\ResponseInterface;

/**
 * Gumroad provider.
 *
 * @author alofoxx <[email protected]>
 */
class Gumroad extends AbstractProvider
{
    use BearerAuthorizationTrait;

    /**
     * API Domain
     *
     * @var string
     */
    public $apiDomain = 'https://gumroad.com';

    /**
     * Get authorization URL to begin OAuth flow
     * Note: Gumroad does not use /oauth2/ for url path of OAuth2!
     *
     * @return string
     */
    public function getBaseAuthorizationUrl()
    {
        return $this->apiDomain.'/oauth/authorize';
    }

    /**
     * Get access token URL to retrieve token
     * Note: Gumroad does not use /oauth2/ for url path of OAuth2!
     *
     * @param  array $params
     *
     * @return string
     */
    public function getBaseAccessTokenUrl(array $params)
    {
        return $this->apiDomain.'/oauth/token';
    }

    /**
     * Get provider URL to retrieve user details
     *
     * @param  AccessToken $token
     *
     * @return string
     */
    public function getResourceOwnerDetailsUrl(AccessToken $token)
    {
        return $this->apiDomain.'/api/v2/user';
    }

    /**
     * Returns the string that should be used to separate scopes when building
     * the URL for requesting an access token.
     *
     * Discord's scope separator is space (%20)
     *
     * @return string Scope separator
     */
    protected function getScopeSeparator()
    {
        return ' ';
    }

    /**
     * Get the default scopes used by this provider.
     *
     * This should not be a complete list of all scopes, but the minimum
     * required for the provider user interface!
     *
     * @return array
     */
    protected function getDefaultScopes()
    {
        return ['view_sales'];
    }

    /**
     * Check a provider response for errors.
     *
     * @throws \League\OAuth2\Client\Provider\Exception\IdentityProviderException
     * @param  ResponseInterface $response
     * @param  array $data Parsed response data
     * @return void
     */
    protected function checkResponse(ResponseInterface $response, $data)
    {
        if ($response->getStatusCode() >= 400) {
            throw GumroadIdentityProviderException::clientException($response, $data);
        } elseif (isset($data['error'])) {
            throw GumroadIdentityProviderException::oauthException($response, $data);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }
    }

    /**
     * Generate a user object from a successful user details request.
     *
     * @param array $response
     * @param AccessToken $token
     * @return \League\OAuth2\Client\Provider\ResourceOwnerInterface
     */
    protected function createResourceOwner(array $response, AccessToken $token)
    {
        return new GumroadResourceOwner($response);
    }
}


1		<?php
2
3		/*
4		* Gumroad OAuth2 Provider
5		* (c) alofoxx
6		*
7		* For the full copyright and license information, please view the LICENSE
8		* file that was distributed with this source code.
9		*/
10
11		namespace Alofoxx\OAuth2\Client\Provider;
12
13		use League\OAuth2\Client\Provider\AbstractProvider;
14		use League\OAuth2\Client\Token\AccessToken;
15		use League\OAuth2\Client\Tool\BearerAuthorizationTrait;
16		use Alofoxx\OAuth2\Client\Provider\Exception\GumroadIdentityProviderException;
17		use Psr\Http\Message\ResponseInterface;
18
19		/**
20		* Gumroad provider.
21		*
22		* @author alofoxx <[email protected]>
23		*/
24		class Gumroad extends AbstractProvider
25		{
26		use BearerAuthorizationTrait;
27
28		/**
29		* API Domain
30		*
31		* @var string
32		*/
33		public $apiDomain = 'https://gumroad.com';
34
35		/**
36		* Get authorization URL to begin OAuth flow
37		* Note: Gumroad does not use /oauth2/ for url path of OAuth2!
38		*
39		* @return string
40		*/
41	9	public function getBaseAuthorizationUrl()
42		{
43	9	return $this->apiDomain.'/oauth/authorize';
44		}
45
46		/**
47		* Get access token URL to retrieve token
48		* Note: Gumroad does not use /oauth2/ for url path of OAuth2!
49		*
50		* @param array $params
51		*
52		* @return string
53		*/
54	15	public function getBaseAccessTokenUrl(array $params)
55		{
56	15	return $this->apiDomain.'/oauth/token';
57		}
58
59		/**
60		* Get provider URL to retrieve user details
61		*
62		* @param AccessToken $token
63		*
64		* @return string
65		*/
66	3	public function getResourceOwnerDetailsUrl(AccessToken $token)
67		{
68	3	return $this->apiDomain.'/api/v2/user';
69		}
70
71		/**
72		* Returns the string that should be used to separate scopes when building
73		* the URL for requesting an access token.
74		*
75		* Discord's scope separator is space (%20)
76		*
77		* @return string Scope separator
78		*/
79	9	protected function getScopeSeparator()
80		{
81	9	return ' ';
82		}
83
84		/**
85		* Get the default scopes used by this provider.
86		*
87		* This should not be a complete list of all scopes, but the minimum
88		* required for the provider user interface!
89		*
90		* @return array
91		*/
92	6	protected function getDefaultScopes()
93		{
94	6	return ['view_sales'];
95		}
96
97		/**
98		* Check a provider response for errors.
99		*
100		* @throws \League\OAuth2\Client\Provider\Exception\IdentityProviderException
101		* @param ResponseInterface $response
102		* @param array $data Parsed response data
103		* @return void
104		*/
105	12	protected function checkResponse(ResponseInterface $response, $data)
106		{
107	12	if ($response->getStatusCode() >= 400) {
108	3	throw GumroadIdentityProviderException::clientException($response, $data);
109	9	} elseif (isset($data['error'])) {
110	3	throw GumroadIdentityProviderException::oauthException($response, $data);
		0 ignored issues – show Documentation introduced 2020-06-27 11:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$data` is of type `array<string,?,{"error":"?"}>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
111		}
112	6	}
113
114		/**
115		* Generate a user object from a successful user details request.
116		*
117		* @param array $response
118		* @param AccessToken $token
119		* @return \League\OAuth2\Client\Provider\ResourceOwnerInterface
120		*/
121	3	protected function createResourceOwner(array $response, AccessToken $token)
122		{
123	3	return new GumroadResourceOwner($response);
124		}
125		}
126

Alofoxx / oauth2-gumroad

Issues (1)

Security Analysis no request data

src/Provider/Gumroad.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like