Passed
Push — master ( 5ca96f...883013 )
by Babak
02:41
created

SmartResponse   A

Complexity

Total Complexity 4

Size/Duplication

Total Lines 25
Duplicated Lines 0 %

Importance

Changes 0
Metric Value
dl 0
loc 25
rs 10
c 0
b 0
f 0
wmc 4

1 Method

Rating   Name   Duplication   Size   Complexity  
A response() 0 19 4
1
<?php
2
3
use Alive2212\LaravelSmartResponse\ResponseModel;
4
5
/**
6
 * Created by PhpStorm.
7
 * User: alive
8
 * Date: 8/23/17
9
 * Time: 6:46 AM
10
 */
11
12
class SmartResponse
13
{
14
    /**
15
     * @param ResponseModel $response
16
     * @return \Illuminate\Http\JsonResponse
0 ignored issues
show
Bug introduced by
The type Illuminate\Http\JsonResponse was not found. Maybe you did not declare it correctly or list all dependencies?

The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:

filter:
    dependency_paths: ["lib/*"]

For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths

Loading history...
17
     */
18
    public static function response(ResponseModel $response)
19
    {
20
        $header = array(
21
            'Content-Type' => 'application/json; charset=UTF-8',
22
            'charset' => 'utf-8'
23
        );
24
        if (!is_null($response->getError())) {
0 ignored issues
show
Bug introduced by
Are you sure the usage of $response->getError() targeting Alive2212\LaravelSmartRe...sponseModel::getError() seems to always return null.

This check looks for function or method calls that always return null and whose return value is used.

class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

The method getObject() can return nothing but null, so it makes no sense to use the return value.

The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.

Loading history...
introduced by
The condition is_null($response->getError()) is always true.
Loading history...
25
            return response()->json([
0 ignored issues
show
Bug introduced by
The function response was not found. Maybe you did not declare it correctly or list all dependencies? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

25
            return /** @scrutinizer ignore-call */ response()->json([
Loading history...
26
                'status' => $response->getStatus(),
27
                'data' => $response->getData()->count() ? $response->getData() : null,
28
                'message' => $response->getMessage(),
29
                'error_code' => $response->getError(),
30
            ], $response->getstatusCode(), $header, JSON_UNESCAPED_UNICODE);
31
        } else {
32
            return response()->json([
33
                'status' => $response->getStatus(),
34
                'data' => $response->getData()->count() ? $response->getData() : null,
35
                'message' => $response->getMessage(),
36
            ], $response->getStatusCode(), $header, JSON_UNESCAPED_UNICODE);
37
        }
38
    }
39
}
40
41