driver.js ➔ ??? - Code Metrics - Inspection of "Replace PhantomJS with Zombie in NPM driver" - AliasIO/wappalyzer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5c721a...2d59ae )

by Elbert

created 2017-07-23 06:27 UTC

driver.js ➔ ??? A

↳ Parent: src/drivers/npm/driver.js

Complexity

Conditions	1
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
c	1
b	0
f	0
nc	2
nop	1
dl	0
loc	65
rs	9.3571

1 Function

Rating	Name	Duplication	Size	Complexity
A	driver.js ➔ ... ➔ ???	0	63	1

How to fix Long Method

'use strict';

const wappalyzer = require('./wappalyzer');
const request = require('request');

const fs = require('fs');
const Browser = require('zombie');

const json = JSON.parse(fs.readFileSync(__dirname + '/apps.json'));


wappalyzer.apps = json.apps;
wappalyzer.categories = json.categories;

const driver = {
  quiet: true,

  analyze: url => {
    return new Promise((resolve, reject) => {
      wappalyzer.driver.log = (message, source, type) => {
        if ( type === 'error' ) {
          return reject(message);
        }

        if ( !driver.quiet ) {
function isBig(a) {
    if (a > 5000) {
        return "yes";
    }
}

console.log(isBig(5001)); //returns yes
console.log(isBig(42)); //returns undefined
          console.log('[wappalyzer ' + type + ']', '[' + source + ']', message);

        }
      };

      wappalyzer.driver.displayApps = detected => {
        var apps = [];

        Object.keys(detected).forEach(appName => {
          const app = detected[appName];

          var categories = [];

          app.props.cats.forEach(id => {
            var category = {};

            category[id] = wappalyzer.categories[id].name;

            categories.push(category)
          });

          apps.push({
            name: app.name,
            confidence: app.confidenceTotal.toString(),
            version: app.version,
            icon: app.props.icon || 'default.svg',
            website: app.props.website,
            categories
          });
        });

        resolve(apps);
      };

      const browser = new Browser();

      browser.visit(url, error => {
        if ( error ) {
          return reject(error);
        }

        wappalyzer.driver.document = browser.document;

        const headers = browser.resources['0'].response.headers;
        const vars = Object.getOwnPropertyNames(browser.window);
        const html = browser.html();

        const hostname = wappalyzer.parseUrl(url).hostname;

        wappalyzer.analyze(hostname, url, {
          headers,
          html,
          env: vars
        });

      });

    });
  }
}

module.exports = driver;


1			'use strict';
2
3			const wappalyzer = require('./wappalyzer');
4			const request = require('request');
			0 ignored issues – show Unused Code introduced 2017-07-23 06:28 UTC by Report Bug Copy Issue Report The constant `request` seems to be never used. Consider removing it. Loading history...
5			const fs = require('fs');
6			const Browser = require('zombie');
7
8			const json = JSON.parse(fs.readFileSync(__dirname + '/apps.json'));
			0 ignored issues – show Compatibility introduced 2017-07-23 06:28 UTC by Report Bug Copy Issue Report Consider using the `path` module for constructing paths since they are otherwise not cross-OS compatible. Loading history...
9
10			wappalyzer.apps = json.apps;
11			wappalyzer.categories = json.categories;
12
13			const driver = {
14			quiet: true,
15
16			analyze: url => {
17			return new Promise((resolve, reject) => {
18			wappalyzer.driver.log = (message, source, type) => {
19			if ( type === 'error' ) {
20			return reject(message);
21			}
22
23			if ( !driver.quiet ) {
			0 ignored issues – show Complexity Best Practice introduced 2017-07-23 06:28 UTC by Report Bug Copy Issue Report There is no return statement if `!driver.quiet` is `false`. Are you sure this is correct? If so, consider adding `return;` explicitly. This check looks for functions where a `return` statement is found in some execution paths, but not in all. Consider this little piece of code function isBig(a) { if (a > 5000) { return "yes"; } } console.log(isBig(5001)); //returns yes console.log(isBig(42)); //returns undefined The function `isBig` will only return a specific value when its parameter is bigger than 5000. In any other case, it will implicitly return `undefined`. This behaviour may not be what you had intended. In any case, you can add a `return undefined` to the other execution path to make the return value explicit. Loading history...
24			console.log('[wappalyzer ' + type + ']', '[' + source + ']', message);
			0 ignored issues – show Debugging Code introduced 2017-07-23 06:28 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history... Best Practice introduced 2017-07-23 06:28 UTC by Report Bug Copy Issue Report There is no `return` statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding `return undefined;` explicitly. Loading history...
25			}
26			};
27
28			wappalyzer.driver.displayApps = detected => {
29			var apps = [];
30
31			Object.keys(detected).forEach(appName => {
32			const app = detected[appName];
33
34			var categories = [];
35
36			app.props.cats.forEach(id => {
37			var category = {};
38
39			category[id] = wappalyzer.categories[id].name;
40
41			categories.push(category)
42			});
43
44			apps.push({
45			name: app.name,
46			confidence: app.confidenceTotal.toString(),
47			version: app.version,
48			icon: app.props.icon \|\| 'default.svg',
49			website: app.props.website,
50			categories
51			});
52			});
53
54			resolve(apps);
55			};
56
57			const browser = new Browser();
58
59			browser.visit(url, error => {
60			if ( error ) {
61			return reject(error);
62			}
63
64			wappalyzer.driver.document = browser.document;
65
66			const headers = browser.resources['0'].response.headers;
67			const vars = Object.getOwnPropertyNames(browser.window);
68			const html = browser.html();
69
70			const hostname = wappalyzer.parseUrl(url).hostname;
71
72			wappalyzer.analyze(hostname, url, {
73			headers,
74			html,
75			env: vars
76			});
			0 ignored issues – show Best Practice introduced 2017-07-23 06:28 UTC by Report Bug Copy Issue Report There is no `return` statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding `return undefined;` explicitly. Loading history...
77			});
78
79			});
80			}
81			}
82
83			module.exports = driver;
84

AliasIO / wappalyzer

Push — master ( 5c721a...2d59ae )

driver.js ➔ ??? A

Complexity

Size

Duplication

Importance

1 Function

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like