Test Failed
Pull Request — master (#26)
by Christopher
03:20 queued 56s
created

xsDecimalTest   A

Complexity

Total Complexity 8

Size/Duplication

Total Lines 72
Duplicated Lines 13.89 %

Coupling/Cohesion

Components 1
Dependencies 2

Importance

Changes 2
Bugs 1 Features 1
Metric Value
wmc 8
lcom 1
cbo 2
dl 10
loc 72
rs 10
c 2
b 1
f 1

6 Methods

Rating   Name   Duplication   Size   Complexity  
A setUp() 0 4 1
A tearDown() 0 4 1
A testxsDecimalValid() 0 9 2
A testxsDecimalValidDataProvider() 0 16 1
A testxsDecimalInvalid() 10 10 2
A testxsDecimalInvalidDataProvider() 0 7 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
4
namespace AlgoWeb\xsdTypes;
5
6
/**
7
 * Generated Test Class.
8
 */
9
class xsDecimalTest extends \PHPUnit_Framework_TestCase
10
{
11
    /**
12
     * Sets up the fixture, for example, opens a network connection.
13
     * This method is called before a test is executed.
14
     */
15
    protected function setUp()
16
    {
17
        parent::setUp();
18
    }
19
20
    /**
21
     * Tears down the fixture, for example, closes a network connection.
22
     * This method is called after a test is executed.
23
     */
24
    protected function tearDown()
25
    {
26
        parent::tearDown();
27
    }
28
29
    /**
30
     * @dataProvider testxsDecimalValidDataProvider
31
     */
32
    public function testxsDecimalValid($input, $message)
33
    {
34
        try {
35
            $d = new xsDecimal($input);
36
            $e = (string)$d;
0 ignored issues
show
Unused Code introduced by
$e is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
37
        } catch (\Exception $e) {
38
    $this->fail($message . ' with Exception ' . $e->getMessage());
39
}
40
    }
41
42
    public function testxsDecimalValidDataProvider()
43
{
44
        return array(
45
            array(3.0, ''),
46
            array(-3.0, 'a negative sign is permitted'),
47
            array(+3.5, 'a positive sign is permitted'),
48
            array(3, 'a decimal point is not required'),
49
            array(.3, 'the value can start with a decimal point'),
50
            array(0, ''),
51
            array(-.3, ''),
52
            array(0003.0, 'leading zeros are permitted'),
53
            array(3.0000, 'trailing zeros are permitted'),
54
55
56
        );
57
    }
58
59
    /**
60
     * @dataProvider testxsDecimalInvalidDataProvider
61
     */
62 View Code Duplication
    public function testxsDecimalInvalid($input, $message)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
63
{
64
        try {
65
            $d = new xsDecimal($input);
66
            $e = (string)$d;
67
            $this->fail($message);
68
        } catch (\Exception $e) {
0 ignored issues
show
Coding Style Comprehensibility introduced by
Consider adding a comment why this CATCH block is empty.
Loading history...
69
        }
70
        $this->assertEquals('', $e, $message);
71
    }
72
73
    public function testxsDecimalInvalidDataProvider()
74
{
75
        return array(
76
            array('3,5', 'commas are not permitted; the decimal separator must be a period'),
77
            array('', 'an empty value is not valid, unless xsi:nil is used'),
78
        );
79
    }
80
}
81