Test Failed
Pull Request — master (#26)
by Christopher
02:34
created

xsHexBinaryTest   A

Complexity

Total Complexity 8

Size/Duplication

Total Lines 68
Duplicated Lines 0 %

Coupling/Cohesion

Components 1
Dependencies 2

Importance

Changes 2
Bugs 0 Features 0
Metric Value
wmc 8
c 2
b 0
f 0
lcom 1
cbo 2
dl 0
loc 68
rs 10

6 Methods

Rating   Name   Duplication   Size   Complexity  
A testxsHexBinaryValid() 0 9 2
A testxsHexBinaryValidDataProvider() 0 9 1
A testxsHexBinaryInvalid() 0 10 2
A testxsHexBinaryInvalidDataProvider() 0 6 1
A setUp() 0 4 1
A tearDown() 0 4 1
1
<?php
2
3
4
namespace AlgoWeb\xsdTypes;
5
6
/**
7
 * Generated Test Class.
8
 */
9
class xsHexBinaryTest extends \PHPUnit_Framework_TestCase
10
{
11
    /**
12
     * @dataProvider testxsHexBinaryValidDataProvider
13
     * @param mixed $input
14
     * @param mixed $message
15
     */
16
    public function testxsHexBinaryValid($input, $message)
17
    {
18
        try {
19
            $d = new xsHexBinary($input);
20
            $s = (string)$d;
0 ignored issues
show
Unused Code introduced by
$s is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
21
        } catch (\Exception $e) {
22
            $this->fail($message . ' with Exception ' . $e->getMessage());
23
        }
24
    }
25
26
    public function testxsHexBinaryValidDataProvider()
27
    {
28
        return array(
29
            array('0FB8', ''),
30
            array('0fb8', 'equivalent to 0FB8'),
31
            array('', 'an empty value is valid'),
32
33
        );
34
    }
35
36
    /**
37
     * @dataProvider testxsHexBinaryInvalidDataProvider
38
     * @param mixed $input
39
     * @param mixed $message
40
     */
41
    public function testxsHexBinaryInvalid($input, $message)
42
    {
43
        try {
44
            $d = new xsHexBinary($input);
45
            $s = (string)$d;
46
            $this->fail($message);
47
        } catch (\Exception $e) {
0 ignored issues
show
Coding Style Comprehensibility introduced by
Consider adding a comment why this CATCH block is empty.
Loading history...
48
        }
49
        $this->assertEquals('', $s, $message);
0 ignored issues
show
Bug introduced by
The variable $s does not seem to be defined for all execution paths leading up to this point.

If you define a variable conditionally, it can happen that it is not defined for all execution paths.

Let’s take a look at an example:

function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

In the above example, the variable $x is defined if you pass “foo” or “bar” as argument for $a. However, since the switch statement has no default case statement, if you pass any other value, the variable $x would be undefined.

Available Fixes

  1. Check for existence of the variable explicitly:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        if (isset($x)) { // Make sure it's always set.
            echo $x;
        }
    }
    
  2. Define a default value for the variable:

    function myFunction($a) {
        $x = ''; // Set a default which gets overridden for certain paths.
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        echo $x;
    }
    
  3. Add a value for the missing path:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
    
            // We add support for the missing case.
            default:
                $x = '';
                break;
        }
    
        echo $x;
    }
    
Loading history...
50
    }
51
52
    public function testxsHexBinaryInvalidDataProvider()
53
    {
54
        return array(
55
            array('FB8', 'an odd number of characters is not valid; characters must appear in pairs'),
56
        );
57
    }
58
59
    /**
60
     * Sets up the fixture, for example, opens a network connection.
61
     * This method is called before a test is executed.
62
     */
63
    protected function setUp()
64
    {
65
        parent::setUp();
66
    }
67
68
    /**
69
     * Tears down the fixture, for example, closes a network connection.
70
     * This method is called after a test is executed.
71
     */
72
    protected function tearDown()
73
    {
74
        parent::tearDown();
75
    }
76
}
77