Test Failed
Pull Request — master (#26)
by Christopher
02:34
created

xsGMonthTest   A

Complexity

Total Complexity 8

Size/Duplication

Total Lines 71
Duplicated Lines 100 %

Coupling/Cohesion

Components 1
Dependencies 2

Importance

Changes 2
Bugs 0 Features 0
Metric Value
wmc 8
c 2
b 0
f 0
lcom 1
cbo 2
dl 71
loc 71
rs 10

6 Methods

Rating   Name   Duplication   Size   Complexity  
A testxsGMonthValid() 9 9 2
A testxsGMonthValidDataProvider() 8 8 1
A testxsGMonthInvalid() 10 10 2
A testxsGMonthInvalidDataProvider() 10 10 1
A setUp() 4 4 1
A tearDown() 4 4 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
4
namespace AlgoWeb\xsdTypes;
5
6
/**
7
 * Generated Test Class.
8
 */
9 View Code Duplication
class xsGMonthTest extends \PHPUnit_Framework_TestCase
0 ignored issues
show
Duplication introduced by
This class seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
10
{
11
    /**
12
     * @dataProvider testxsGMonthValidDataProvider
13
     * @param mixed $input
14
     * @param mixed $message
15
     */
16
    public function testxsGMonthValid($input, $message)
17
    {
18
        try {
19
            $d = new xsGMonth($input);
20
            $s = (string)$d;
0 ignored issues
show
Unused Code introduced by
$s is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
21
        } catch (\Exception $e) {
22
            $this->fail($message . ' with Exception ' . $e->getMessage());
23
        }
24
    }
25
26
    public function testxsGMonthValidDataProvider()
27
    {
28
        return array(
29
            array('--04', 'April'),
30
            array('--04-05:00', 'April, US Eastern Standard Time'),
31
32
        );
33
    }
34
35
    /**
36
     * @dataProvider testxsGMonthInvalidDataProvider
37
     * @param mixed $input
38
     * @param mixed $message
39
     */
40
    public function testxsGMonthInvalid($input, $message)
41
    {
42
        try {
43
            $d = new xsGMonth($input);
44
            $s = (string)$d;
45
            $this->fail($message);
46
        } catch (\Exception $e) {
0 ignored issues
show
Coding Style Comprehensibility introduced by
Consider adding a comment why this CATCH block is empty.
Loading history...
47
        }
48
        $this->assertEquals('', $s, $message);
0 ignored issues
show
Bug introduced by
The variable $s does not seem to be defined for all execution paths leading up to this point.

If you define a variable conditionally, it can happen that it is not defined for all execution paths.

Let’s take a look at an example:

function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

In the above example, the variable $x is defined if you pass “foo” or “bar” as argument for $a. However, since the switch statement has no default case statement, if you pass any other value, the variable $x would be undefined.

Available Fixes

  1. Check for existence of the variable explicitly:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        if (isset($x)) { // Make sure it's always set.
            echo $x;
        }
    }
    
  2. Define a default value for the variable:

    function myFunction($a) {
        $x = ''; // Set a default which gets overridden for certain paths.
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        echo $x;
    }
    
  3. Add a value for the missing path:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
    
            // We add support for the missing case.
            default:
                $x = '';
                break;
        }
    
        echo $x;
    }
    
Loading history...
49
    }
50
51
    public function testxsGMonthInvalidDataProvider()
52
    {
53
        return array(
54
            array('2004-04', 'the year must not be specified; use gYearMonth instead'),
55
            array('04', 'the leading hyphens are required'),
56
            array('--4', 'the month must be 2 digits'),
57
            array('--13	', 'the month must be a valid month'),
58
            array('', 'an empty value is not valid, unless xsi:nil is used'),
59
        );
60
    }
61
62
    /**
63
     * Sets up the fixture, for example, opens a network connection.
64
     * This method is called before a test is executed.
65
     */
66
    protected function setUp()
67
    {
68
        parent::setUp();
69
    }
70
71
    /**
72
     * Tears down the fixture, for example, closes a network connection.
73
     * This method is called after a test is executed.
74
     */
75
    protected function tearDown()
76
    {
77
        parent::tearDown();
78
    }
79
}
80