Test Failed
Pull Request — master (#26)
by Christopher
02:51
created

xsDateTimeTest::tearDown()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 4
Code Lines 2

Duplication

Lines 0
Ratio 0 %

Importance

Changes 1
Bugs 0 Features 0
Metric Value
c 1
b 0
f 0
dl 0
loc 4
rs 10
cc 1
eloc 2
nc 1
nop 0
1
<?php
2
3
4
namespace AlgoWeb\xsdTypes;
5
6
/**
7
 * Generated Test Class.
8
 */
9
class xsDateTimeTest extends \PHPUnit_Framework_TestCase
10
{
11
    /**
12
     * Sets up the fixture, for example, opens a network connection.
13
     * This method is called before a test is executed.
14
     */
15
    protected function setUp()
16
    {
17
        parent::setUp();
18
    }
19
20
    /**
21
     * Tears down the fixture, for example, closes a network connection.
22
     * This method is called after a test is executed.
23
     */
24
    protected function tearDown()
25
    {
26
        parent::tearDown();
27
    }
28
29
    /**
30
     * @dataProvider testxsDateTimeValidDataProvider
31
     * @param mixed $input
32
     * @param mixed $message
33
     */
34
    public function testxsDateTimeValid($input, $message)
35
    {
36
        try {
37
            $d = new xsDateTime($input);
38
            $e = (string)$d;
0 ignored issues
show
Unused Code introduced by
$e is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
39
        } catch (\Exception $e) {
40
            $this->fail($message . ' with Exception ' . $e->getMessage());
41
        }
42
    }
43
44
    public function testxsDateTimeValidDataProvider()
45
    {
46
        return array(
47
            array('2004-04-12T13:20:00', '1:20 pm on April 12, 2004'),
48
            array('2004-04-12T13:20:15.5', '1:20 pm and 15.5 seconds on April 12, 2004'),
49
            array('2004-04-12T13:20:00-05:00', '1:20 pm on April 12, 2004, US Eastern Standard Time'),
50
            array('2004-04-12T13:20:00Z', '	1:20 pm on April 12, 2004, Coordinated Universal Time (UTC)'),
51
        );
52
    }
53
54
    /**
55
     * @dataProvider testxsDateTimeInvalidDataProvider
56
     * @param mixed $input
57
     * @param mixed $message
58
     */
59
    public function testxsDateTimeInvalid($input, $message)
60
    {
61
        try {
62
            $d = new xsDateTime($input);
63
            $s = (string)$d;
64
            $this->fail($message);
65
        } catch (\Exception $e) {
0 ignored issues
show
Coding Style Comprehensibility introduced by
Consider adding a comment why this CATCH block is empty.
Loading history...
66
        }
67
        $this->assertEquals('', $s, $message);
0 ignored issues
show
Bug introduced by
The variable $s does not seem to be defined for all execution paths leading up to this point.

If you define a variable conditionally, it can happen that it is not defined for all execution paths.

Let’s take a look at an example:

function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

In the above example, the variable $x is defined if you pass “foo” or “bar” as argument for $a. However, since the switch statement has no default case statement, if you pass any other value, the variable $x would be undefined.

Available Fixes

  1. Check for existence of the variable explicitly:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        if (isset($x)) { // Make sure it's always set.
            echo $x;
        }
    }
    
  2. Define a default value for the variable:

    function myFunction($a) {
        $x = ''; // Set a default which gets overridden for certain paths.
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        echo $x;
    }
    
  3. Add a value for the missing path:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
    
            // We add support for the missing case.
            default:
                $x = '';
                break;
        }
    
        echo $x;
    }
    
Loading history...
68
    }
69
70
    public function testxsDateTimeInvalidDataProvider()
71
    {
72
        return array(
73
            array('2004-04-12T13:00', 'seconds must be specified'),
74
            array('2004-04-1213:20:00', 'the letter T is required'),
75
            array('99-04-12T13:00', 'the century must not be left truncated'),
76
            array('2004-04-12', 'the time is required'),
77
            array('', 'an empty value is not valid, unless xsi:nil is used'),
78
        );
79
    }
80
}
81