Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 9 | class xsDoubleTest extends \PHPUnit_Framework_TestCase |
||
| 10 | { |
||
| 11 | /** |
||
| 12 | * Sets up the fixture, for example, opens a network connection. |
||
| 13 | * This method is called before a test is executed. |
||
| 14 | */ |
||
| 15 | protected function setUp() |
||
| 19 | |||
| 20 | /** |
||
| 21 | * Tears down the fixture, for example, closes a network connection. |
||
| 22 | * This method is called after a test is executed. |
||
| 23 | */ |
||
| 24 | protected function tearDown() |
||
| 28 | |||
| 29 | /** |
||
| 30 | * @dataProvider testxsDoubleValidDataProvider |
||
| 31 | */ |
||
| 32 | public function testxsDoubleValid($input, $message) |
||
| 41 | |||
| 42 | public function testxsDoubleValidDataProvider() |
||
| 56 | |||
| 57 | /** |
||
| 58 | * @dataProvider testxsDoubleInvalidDataProvider |
||
| 59 | */ |
||
| 60 | View Code Duplication | public function testxsDoubleInvalid($input, $message) |
|
| 70 | |||
| 71 | public function testxsDoubleInvalidDataProvider() |
||
| 80 | } |
||
| 81 |
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.