xsNegativeIntegerTest::setUp() - Code Metrics - Inspection of "getting basic test framework in place" - Algo-Web/xsdTypes - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#26)

by Christopher

created 2017-07-06 15:42 UTC

xsNegativeIntegerTest::setUp() A

↳ Parent: xsNegativeIntegerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	4
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	4
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php


namespace AlgoWeb\xsdTypes;

/**
 * Generated Test Class.
 */
class xsNegativeIntegerTest extends \PHPUnit_Framework_TestCase

{
    /**
     * @dataProvider testxsNegativeIntegerValidDataProvider
     * @param mixed $input
     * @param mixed $message
     */
    public function testxsNegativeIntegerValid($input, $message)
    {
        try {
            $d = new xsNegativeInteger($input);
            $s = (string)$d;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        } catch (\Exception $e) {
            $this->fail($message . ' with Exception ' . $e->getMessage());
        }
    }

    public function testxsNegativeIntegerValidDataProvider()
    {
        return array(
            array('-3', ''),
            array('-00122', 'leading zeros are permitted'),
        );
    }

    /**
     * @dataProvider testxsNegativeIntegerInvalidDataProvider
     * @param mixed $input
     * @param mixed $message
     */
    public function testxsNegativeIntegerInvalid($input, $message)
    {
        try {
            $d = new xsNegativeInteger($input);
            $s = (string)$d;
            $this->fail($message);
        } catch (\Exception $e) {

        }
        $this->assertEquals('', $s, $message);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }

    public function testxsNegativeIntegerInvalidDataProvider()
    {
        return array(
            array('0', '0 is not considered negative'),
            array('122', 'value cannot be positive'),
            array('+3', 'value cannot be positive'),
            array('3.0', 'value must not contain a decimal point'),
            array('', 'an empty value is not valid, unless xsi:nil is used'),
        );
    }

    /**
     * Sets up the fixture, for example, opens a network connection.
     * This method is called before a test is executed.
     */
    protected function setUp()
    {
        parent::setUp();
    }

    /**
     * Tears down the fixture, for example, closes a network connection.
     * This method is called after a test is executed.
     */
    protected function tearDown()
    {
        parent::tearDown();
    }
}


1		<?php
2
3
4		namespace AlgoWeb\xsdTypes;
5
6		/**
7		* Generated Test Class.
8		*/
9	View Code Duplication	class xsNegativeIntegerTest extends \PHPUnit_Framework_TestCase
		0 ignored issues – show Duplication introduced 2017-07-05 12:49 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
10		{
11		/**
12		* @dataProvider testxsNegativeIntegerValidDataProvider
13		* @param mixed $input
14		* @param mixed $message
15		*/
16		public function testxsNegativeIntegerValid($input, $message)
17		{
18		try {
19		$d = new xsNegativeInteger($input);
20		$s = (string)$d;
		0 ignored issues – show Unused Code introduced 2017-07-06 15:45 UTC by Report Bug Copy Issue Report `$s` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
21		} catch (\Exception $e) {
22		$this->fail($message . ' with Exception ' . $e->getMessage());
23		}
24		}
25
26		public function testxsNegativeIntegerValidDataProvider()
27		{
28		return array(
29		array('-3', ''),
30		array('-00122', 'leading zeros are permitted'),
31		);
32		}
33
34		/**
35		* @dataProvider testxsNegativeIntegerInvalidDataProvider
36		* @param mixed $input
37		* @param mixed $message
38		*/
39		public function testxsNegativeIntegerInvalid($input, $message)
40		{
41		try {
42		$d = new xsNegativeInteger($input);
43		$s = (string)$d;
44		$this->fail($message);
45		} catch (\Exception $e) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-07-06 15:45 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
46		}
47		$this->assertEquals('', $s, $message);
		0 ignored issues – show Bug introduced 2017-07-06 15:45 UTC by Report Bug Copy Issue Report The variable `$s` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
48		}
49
50		public function testxsNegativeIntegerInvalidDataProvider()
51		{
52		return array(
53		array('0', '0 is not considered negative'),
54		array('122', 'value cannot be positive'),
55		array('+3', 'value cannot be positive'),
56		array('3.0', 'value must not contain a decimal point'),
57		array('', 'an empty value is not valid, unless xsi:nil is used'),
58		);
59		}
60
61		/**
62		* Sets up the fixture, for example, opens a network connection.
63		* This method is called before a test is executed.
64		*/
65		protected function setUp()
66		{
67		parent::setUp();
68		}
69
70		/**
71		* Tears down the fixture, for example, closes a network connection.
72		* This method is called after a test is executed.
73		*/
74		protected function tearDown()
75		{
76		parent::tearDown();
77		}
78		}
79

Algo-Web / xsdTypes

Pull Request — master (#26)

xsNegativeIntegerTest::setUp() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like