xsGDayTest::testxsGDayValidDataProvider() - Code Metrics - Inspection of "getting basic test framework in place" - Algo-Web/xsdTypes - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#26)

by Christopher

created 2017-07-06 15:42 UTC

xsGDayTest::testxsGDayValidDataProvider() A

↳ Parent: xsGDayTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	6
rs	9.4285
cc	1
eloc	3
nc	1
nop	0

<?php


namespace AlgoWeb\xsdTypes;

/**
 * Generated Test Class.
 */
class xsGDayTest extends \PHPUnit_Framework_TestCase
{
    /**
     * @dataProvider testxsGDayValidDataProvider
     * @param mixed $input
     * @param mixed $message
     */
    public function testxsGDayValid($input, $message)
    {
        try {
            $d = new xsGDay($input);
            $s = (string)$d;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        } catch (\Exception $e) {
            $this->fail($message . ' with Exception ' . $e->getMessage());
        }
    }

    public function testxsGDayValidDataProvider()
    {
        return array(
            array('---02', 'the 2nd of the month'),
        );
    }

    /**
     * @dataProvider testxsGDayInvalidDataProvider
     * @param mixed $input
     * @param mixed $message
     */
    public function testxsGDayInvalid($input, $message)
    {
        try {
            $d = new xsGDay($input);
            $s = (string)$d;
            $this->fail($message);
        } catch (\Exception $e) {

        }
        $this->assertEquals('', $s, $message);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }

    public function testxsGDayInvalidDataProvider()
    {
        return array(
            array('02', 'the leading hyphens are required'),
            array('---2', 'the day must be 2 digits'),
            array('---32', 'the day must be a valid day of the month; no month has 32 days'),
            array('', 'an empty value is not valid, unless xsi:nil is used'),
        );
    }

    /**
     * Sets up the fixture, for example, opens a network connection.
     * This method is called before a test is executed.
     */
    protected function setUp()
    {
        parent::setUp();
    }

    /**
     * Tears down the fixture, for example, closes a network connection.
     * This method is called after a test is executed.
     */
    protected function tearDown()
    {
        parent::tearDown();
    }
}


1			<?php
2
3
4			namespace AlgoWeb\xsdTypes;
5
6			/**
7			* Generated Test Class.
8			*/
9			class xsGDayTest extends \PHPUnit_Framework_TestCase
10			{
11			/**
12			* @dataProvider testxsGDayValidDataProvider
13			* @param mixed $input
14			* @param mixed $message
15			*/
16			public function testxsGDayValid($input, $message)
17			{
18			try {
19			$d = new xsGDay($input);
20			$s = (string)$d;
			0 ignored issues – show Unused Code introduced 2017-07-06 11:39 UTC by Report Bug Copy Issue Report `$s` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
21			} catch (\Exception $e) {
22			$this->fail($message . ' with Exception ' . $e->getMessage());
23			}
24			}
25
26			public function testxsGDayValidDataProvider()
27			{
28			return array(
29			array('---02', 'the 2nd of the month'),
30			);
31			}
32
33			/**
34			* @dataProvider testxsGDayInvalidDataProvider
35			* @param mixed $input
36			* @param mixed $message
37			*/
38			public function testxsGDayInvalid($input, $message)
39			{
40			try {
41			$d = new xsGDay($input);
42			$s = (string)$d;
43			$this->fail($message);
44			} catch (\Exception $e) {
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-07-06 11:39 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
45			}
46			$this->assertEquals('', $s, $message);
			0 ignored issues – show Bug introduced 2017-07-06 11:39 UTC by Report Bug Copy Issue Report The variable `$s` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
47			}
48
49			public function testxsGDayInvalidDataProvider()
50			{
51			return array(
52			array('02', 'the leading hyphens are required'),
53			array('---2', 'the day must be 2 digits'),
54			array('---32', 'the day must be a valid day of the month; no month has 32 days'),
55			array('', 'an empty value is not valid, unless xsi:nil is used'),
56			);
57			}
58
59			/**
60			* Sets up the fixture, for example, opens a network connection.
61			* This method is called before a test is executed.
62			*/
63			protected function setUp()
64			{
65			parent::setUp();
66			}
67
68			/**
69			* Tears down the fixture, for example, closes a network connection.
70			* This method is called after a test is executed.
71			*/
72			protected function tearDown()
73			{
74			parent::tearDown();
75			}
76			}
77

Algo-Web / xsdTypes

Pull Request — master (#26)

xsGDayTest::testxsGDayValidDataProvider() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like