xsLanguageTest::testxsLanguageInvalidDataProvider() - Code Metrics - Inspection of "getting basic test framework in place" - Algo-Web/xsdTypes - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#26)

by Christopher

created 2017-07-06 15:37 UTC

testxsLanguageInvalidDataProvider() A

↳ Parent: xsLanguageTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	7
rs	9.4285
cc	1
eloc	4
nc	1
nop	0

<?php


namespace AlgoWeb\xsdTypes;

/**
 * Generated Test Class.
 */
class xsLanguageTest extends \PHPUnit_Framework_TestCase
{
    /**
     * @dataProvider testxsLanguageValidDataProvider
     */
    public function testxsLanguageValid($input, $message)
    {
        try {
            $d = new xsLanguage($input);
            $s = (string)$d;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        } catch (\Exception $e) {
            $this->fail($message . ' with Exception ' . $e->getMessage());
        }
    }

    public function testxsLanguageValidDataProvider()
    {
        return array(
            array('en', 'English'),
            array('en-GB', 'UK English'),
            array('en-US', 'US English'),
            array('fr', 'French'),
            array('de', 'German'),
            array('es', 'Spanish'),
            array('it', 'Italian'),
            array('nl', 'Dutch'),
            array('zh', 'Chinese'),
            array('ja', 'Japanese'),
            array('ko', 'Korean'),
            array('i-navajo', 'IANA-registered language'),
            array('x-Newspeak', 'private, unregistered language'),
            array('any-value-with-short-parts', 'although a schema processor will consider this value valid, ' .
                'it does not follow RFC 3066 guidelines'),
        );
    }

    /**
     * @dataProvider testxsLanguageInvalidDataProvider
     */
    public function testxsLanguageInvalid($input, $message)
    {
        try {
            $d = new xsLanguage($input);
            $s = (string)$d;
            $this->fail($message);
        } catch (\Exception $e) {

        }
        $this->assertEquals('', $s, $message);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }

    public function testxsLanguageInvalidDataProvider()
    {
        return array(
            array('longerThan8', 'parts may not exceed 8 characters in length'),
            array('', 'an empty value is not valid, unless xsi:nil is used'),
        );
    }

    /**
     * Sets up the fixture, for example, opens a network connection.
     * This method is called before a test is executed.
     */
    protected function setUp()
    {
        parent::setUp();
    }

    /**
     * Tears down the fixture, for example, closes a network connection.
     * This method is called after a test is executed.
     */
    protected function tearDown()
    {
        parent::tearDown();
    }
}


1			<?php
2
3
4			namespace AlgoWeb\xsdTypes;
5
6			/**
7			* Generated Test Class.
8			*/
9			class xsLanguageTest extends \PHPUnit_Framework_TestCase
10			{
11			/**
12			* @dataProvider testxsLanguageValidDataProvider
13			*/
14			public function testxsLanguageValid($input, $message)
15			{
16			try {
17			$d = new xsLanguage($input);
18			$s = (string)$d;
			0 ignored issues – show Unused Code introduced 2017-07-06 15:16 UTC by Report Bug Copy Issue Report `$s` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
19			} catch (\Exception $e) {
20			$this->fail($message . ' with Exception ' . $e->getMessage());
21			}
22			}
23
24			public function testxsLanguageValidDataProvider()
25			{
26			return array(
27			array('en', 'English'),
28			array('en-GB', 'UK English'),
29			array('en-US', 'US English'),
30			array('fr', 'French'),
31			array('de', 'German'),
32			array('es', 'Spanish'),
33			array('it', 'Italian'),
34			array('nl', 'Dutch'),
35			array('zh', 'Chinese'),
36			array('ja', 'Japanese'),
37			array('ko', 'Korean'),
38			array('i-navajo', 'IANA-registered language'),
39			array('x-Newspeak', 'private, unregistered language'),
40			array('any-value-with-short-parts', 'although a schema processor will consider this value valid, ' .
41			'it does not follow RFC 3066 guidelines'),
42			);
43			}
44
45			/**
46			* @dataProvider testxsLanguageInvalidDataProvider
47			*/
48			public function testxsLanguageInvalid($input, $message)
49			{
50			try {
51			$d = new xsLanguage($input);
52			$s = (string)$d;
53			$this->fail($message);
54			} catch (\Exception $e) {
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-07-06 15:16 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
55			}
56			$this->assertEquals('', $s, $message);
			0 ignored issues – show Bug introduced 2017-07-06 15:16 UTC by Report Bug Copy Issue Report The variable `$s` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
57			}
58
59			public function testxsLanguageInvalidDataProvider()
60			{
61			return array(
62			array('longerThan8', 'parts may not exceed 8 characters in length'),
63			array('', 'an empty value is not valid, unless xsi:nil is used'),
64			);
65			}
66
67			/**
68			* Sets up the fixture, for example, opens a network connection.
69			* This method is called before a test is executed.
70			*/
71			protected function setUp()
72			{
73			parent::setUp();
74			}
75
76			/**
77			* Tears down the fixture, for example, closes a network connection.
78			* This method is called after a test is executed.
79			*/
80			protected function tearDown()
81			{
82			parent::tearDown();
83			}
84			}
85

Algo-Web / xsdTypes

Pull Request — master (#26)

testxsLanguageInvalidDataProvider() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like