Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 9 | View Code Duplication | class xsDayTimeDurationTest extends \PHPUnit_Framework_TestCase |
|
|
|
|||
| 10 | { |
||
| 11 | /** |
||
| 12 | * Sets up the fixture, for example, opens a network connection. |
||
| 13 | * This method is called before a test is executed. |
||
| 14 | */ |
||
| 15 | protected function setUp() |
||
| 16 | { |
||
| 17 | parent::setUp(); |
||
| 18 | } |
||
| 19 | |||
| 20 | /** |
||
| 21 | * Tears down the fixture, for example, closes a network connection. |
||
| 22 | * This method is called after a test is executed. |
||
| 23 | */ |
||
| 24 | protected function tearDown() |
||
| 25 | { |
||
| 26 | parent::tearDown(); |
||
| 27 | } |
||
| 28 | |||
| 29 | /** |
||
| 30 | * @dataProvider testxsDayTimeDurationValidDataProvider |
||
| 31 | * @param mixed $input |
||
| 32 | * @param mixed $message |
||
| 33 | */ |
||
| 34 | public function testxsDayTimeDurationValid($input, $message) |
||
| 43 | |||
| 44 | public function testxsDayTimeDurationValidDataProvider() |
||
| 45 | { |
||
| 46 | return array( |
||
| 47 | array('P2Y6M5DT12H35M30S', '2 years, 6 months, 5 days, 12 hours, 35 minutes, 30 seconds'), |
||
| 48 | array('P1DT2H', '1 day, 2 hours'), |
||
| 49 | array('P20M', '20 months (the number of months can be more than 12)'), |
||
| 50 | array('PT20M', '20 minutes'), |
||
| 51 | array('P0Y20M0D', '20 months (0 is permitted as a number, but is not required)'), |
||
| 52 | array('P0Y', '0 years'), |
||
| 53 | array('-P60D', 'minus 60 days'), |
||
| 54 | array('PT1M30.5S', '1 minute, 30.5 seconds'), |
||
| 55 | ); |
||
| 56 | } |
||
| 57 | |||
| 58 | /** |
||
| 59 | * @dataProvider testxsDayTimeDurationInvalidDataProvider |
||
| 60 | * @param mixed $input |
||
| 61 | * @param mixed $message |
||
| 62 | */ |
||
| 63 | public function testxsDayTimeDurationInvalid($input, $message) |
||
| 73 | |||
| 74 | public function testxsDayTimeDurationInvalidDataProvider() |
||
| 75 | { |
||
| 76 | return array( |
||
| 89 | } |
||
| 90 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.