AlgoWeb\xsdTypes\AxillaryClasses\XMLDateInterval

Complexity

Total Complexity

11

Size/Duplication

Total Lines	57
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	5
Bugs	2	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	11	2
A	__toString()	0	9	2
A	handleSign()	0	6	2
B	handleChar()	0	13	5

<?php

namespace AlgoWeb\xsdTypes\AxillaryClasses;

class XMLDateInterval extends \DateInterval
{
    /**
     * formating string like ISO 8601 (PnYnMnDTnHnMnS).
     */
    const INTERVAL_ISO8601 = 'P%yY%mM%dDT%hH%iM%sS';
    private $pattern;
    private $patternLen;

    public function __construct($intervalSpec, $pattern = 'PnYnMnDTnHnMnS')
    {
        if ($intervalSpec[0] == '-') {
            $intervalSpec = substr($intervalSpec, 1);

Consider using a different name than the parameter $intervalSpec. This often makes code more readable.

            $this->invert = true;

The property $invert was declared of type integer, but true is of type boolean. Maybe add a type cast?

        }
        parent::__construct($intervalSpec);
        $this->pattern = trim($pattern);

        $this->patternLen = strlen($this->pattern);
    }

    /**
     * formating the interval like ISO 8601 (PnYnMnDTnHnMnS).
     *
     * @return string

Should the return type not be string|null?

     */
    public function __toString()
    {
        $sReturn = $this->handleSign();
        $tSeen = false;
        for ($i = 0; $i < $this->patternLen; $i++) {
            $sReturn .= $this->handleChar($i, $tSeen);
        }
        return $sReturn;
    }

    private function handleSign()
    {
        if ($this->invert === 1) {
            return '-';
        }
    }

    private function handleChar($i, &$tSeen)

The return type could not be reliably inferred; please add a @return annotation.

    {
        switch ($this->pattern[$i]) {
            case 'n':
                $v = ($this->pattern[$i + 1] == 'M' && $tSeen) ? 'i' : strtolower($this->pattern[$i + 1]);
                return $this->$v;
            case 'T':
                $tSeen = true;
                return 'T';
            default:
                return $this->pattern[$i];
        }
    }
}