xsDayTimeDurationTest - Code Metrics - Inspection of "getting basic test framework in place" - Algo-Web/xsdTypes - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#26)

by Christopher

created 2017-07-06 06:59 UTC

xsDayTimeDurationTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	77
Duplicated Lines	12.99 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
wmc	8
c	2
b	0
f	0
lcom	1
cbo	3
dl	10
loc	77
rs	10

6 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	4	1
A	tearDown()	0	4	1
A	testxsDayTimeDurationValid()	0	9	2
A	testxsDayTimeDurationValidDataProvider()	0	13	1
A	testxsDayTimeDurationInvalid()	10	10	2
A	testxsDayTimeDurationInvalidDataProvider()	0	15	1

How to fix Duplicated Code

<?php


namespace AlgoWeb\xsdTypes;

/**
 * Generated Test Class.
 */
class xsDayTimeDurationTest extends \PHPUnit_Framework_TestCase
{
    /**
     * Sets up the fixture, for example, opens a network connection.
     * This method is called before a test is executed.
     */
    protected function setUp()
    {
        parent::setUp();
    }

    /**
     * Tears down the fixture, for example, closes a network connection.
     * This method is called after a test is executed.
     */
    protected function tearDown()
    {
        parent::tearDown();
    }

    /**
     * @dataProvider testxsDayTimeDurationValidDataProvider
     */
    public function testxsDayTimeDurationValid($input, $message)
    {
        try {
            $d = new xsDayTimeDuration($input);
            $e = (string)$d;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        } catch (\Exception $e) {
    $this->fail($message . ' with Exception ' . $e->getMessage());
}
    }

    public function testxsDayTimeDurationValidDataProvider()
{
        return array(
            array('P2Y6M5DT12H35M30S', '2 years, 6 months, 5 days, 12 hours, 35 minutes, 30 seconds'),
            array('P1DT2H', '1 day, 2 hours'),
            array('P20M', '20 months (the number of months can be more than 12)'),
            array('PT20M', '20 minutes'),
            array('P0Y20M0D', '20 months (0 is permitted as a number, but is not required)'),
            array('P0Y', '0 years'),
            array('-P60D', 'minus 60 days'),
            array('PT1M30.5S', '1 minute, 30.5 seconds'),
        );
    }

    /**
     * @dataProvider testxsDayTimeDurationInvalidDataProvider
     */
    public function testxsDayTimeDurationInvalid($input, $message)

{
        try {
            $d = new xsBase64Binary($input);
            $e = (string)$d;
            $this->fail($message);
        } catch (\Exception $e) {

        }
        $this->assertEquals('', $e, $message);
    }

    public function testxsDayTimeDurationInvalidDataProvider()
{
        return array(
            array('P-20M', 'the minus sign must appear first'),
            array('P20MT', 'no time items are present, so "T" must not be present'),
            array('P1YM5D', 'no value is specified for months, so "M" must not be present'),
            array('P15.5Y', 'only the seconds can be expressed as a decimal'),
            array('P1D2H', '"T" must be present to separate days and hours'),
            array('1Y2M', '"P" must always be present'),
            array('P2M1Y', 'years must appear before months'),
            array('P', 'at least one number and designator are required'),
            array('PT15.S', 'at least one digit must follow the decimal point if it appears'),
            array('', 'an empty value is not valid, unless xsi:nil is used'),
        );
    }
}


1		<?php
2
3
4		namespace AlgoWeb\xsdTypes;
5
6		/**
7		* Generated Test Class.
8		*/
9		class xsDayTimeDurationTest extends \PHPUnit_Framework_TestCase
10		{
11		/**
12		* Sets up the fixture, for example, opens a network connection.
13		* This method is called before a test is executed.
14		*/
15		protected function setUp()
16		{
17		parent::setUp();
18		}
19
20		/**
21		* Tears down the fixture, for example, closes a network connection.
22		* This method is called after a test is executed.
23		*/
24		protected function tearDown()
25		{
26		parent::tearDown();
27		}
28
29		/**
30		* @dataProvider testxsDayTimeDurationValidDataProvider
31		*/
32		public function testxsDayTimeDurationValid($input, $message)
33		{
34		try {
35		$d = new xsDayTimeDuration($input);
36		$e = (string)$d;
		0 ignored issues – show Unused Code introduced 2017-07-06 03:53 UTC by Report Bug Copy Issue Report `$e` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
37		} catch (\Exception $e) {
38		$this->fail($message . ' with Exception ' . $e->getMessage());
39		}
40		}
41
42		public function testxsDayTimeDurationValidDataProvider()
43		{
44		return array(
45		array('P2Y6M5DT12H35M30S', '2 years, 6 months, 5 days, 12 hours, 35 minutes, 30 seconds'),
46		array('P1DT2H', '1 day, 2 hours'),
47		array('P20M', '20 months (the number of months can be more than 12)'),
48		array('PT20M', '20 minutes'),
49		array('P0Y20M0D', '20 months (0 is permitted as a number, but is not required)'),
50		array('P0Y', '0 years'),
51		array('-P60D', 'minus 60 days'),
52		array('PT1M30.5S', '1 minute, 30.5 seconds'),
53		);
54		}
55
56		/**
57		* @dataProvider testxsDayTimeDurationInvalidDataProvider
58		*/
59	View Code Duplication	public function testxsDayTimeDurationInvalid($input, $message)
		0 ignored issues – show Duplication introduced 2017-07-06 03:53 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
60		{
61		try {
62		$d = new xsBase64Binary($input);
63		$e = (string)$d;
64		$this->fail($message);
65		} catch (\Exception $e) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-07-06 03:53 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
66		}
67		$this->assertEquals('', $e, $message);
68		}
69
70		public function testxsDayTimeDurationInvalidDataProvider()
71		{
72		return array(
73		array('P-20M', 'the minus sign must appear first'),
74		array('P20MT', 'no time items are present, so "T" must not be present'),
75		array('P1YM5D', 'no value is specified for months, so "M" must not be present'),
76		array('P15.5Y', 'only the seconds can be expressed as a decimal'),
77		array('P1D2H', '"T" must be present to separate days and hours'),
78		array('1Y2M', '"P" must always be present'),
79		array('P2M1Y', 'years must appear before months'),
80		array('P', 'at least one number and designator are required'),
81		array('PT15.S', 'at least one digit must follow the decimal point if it appears'),
82		array('', 'an empty value is not valid, unless xsi:nil is used'),
83		);
84		}
85		}
86

Algo-Web / xsdTypes

Pull Request — master (#26)

xsDayTimeDurationTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

6 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like