Test Failed
Pull Request — master (#26)
by Christopher
02:41
created

xsNMTOKENSTest   A

Complexity

Total Complexity 8

Size/Duplication

Total Lines 62
Duplicated Lines 0 %

Coupling/Cohesion

Components 1
Dependencies 2

Importance

Changes 1
Bugs 0 Features 0
Metric Value
wmc 8
c 1
b 0
f 0
lcom 1
cbo 2
dl 0
loc 62
rs 10

6 Methods

Rating   Name   Duplication   Size   Complexity  
A testxsNMTOKENSValid() 0 9 2
A testxsNMTOKENSValidDataProvider() 0 7 1
A testxsNMTOKENSInvalid() 0 10 2
A testxsNMTOKENSInvalidDataProvider() 0 6 1
A setUp() 0 4 1
A tearDown() 0 4 1
1
<?php
2
3
4
namespace AlgoWeb\xsdTypes;
5
6
/**
7
 * Generated Test Class.
8
 */
9
class xsNMTOKENSTest extends \PHPUnit_Framework_TestCase
10
{
11
    /**
12
     * @dataProvider testxsNMTOKENSValidDataProvider
13
     */
14
    public function testxsNMTOKENSValid($input, $message)
15
    {
16
        try {
17
            $d = new xsNMTOKENS($input);
18
            $s = (string)$d;
0 ignored issues
show
Unused Code introduced by
$s is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
19
        } catch (\Exception $e) {
20
            $this->fail($message . ' with Exception ' . $e->getMessage());
21
        }
22
    }
23
24
    public function testxsNMTOKENSValidDataProvider()
25
    {
26
        return array(
27
            array('ABCD 123', ''),
28
            array('ABCD ', 'one-item list'),
29
        );
30
    }
31
32
    /**
33
     * @dataProvider testxsNMTOKENSInvalidDataProvider
34
     */
35
    public function testxsNMTOKENSInvalid($input, $message)
36
    {
37
        try {
38
            $d = new xsNMTOKENS($input);
39
            $s = (string)$d;
40
            $this->fail($message);
41
        } catch (\Exception $e) {
0 ignored issues
show
Coding Style Comprehensibility introduced by
Consider adding a comment why this CATCH block is empty.
Loading history...
42
        }
43
        $this->assertEquals('', $s, $message);
0 ignored issues
show
Bug introduced by
The variable $s does not seem to be defined for all execution paths leading up to this point.

If you define a variable conditionally, it can happen that it is not defined for all execution paths.

Let’s take a look at an example:

function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

In the above example, the variable $x is defined if you pass “foo” or “bar” as argument for $a. However, since the switch statement has no default case statement, if you pass any other value, the variable $x would be undefined.

Available Fixes

  1. Check for existence of the variable explicitly:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        if (isset($x)) { // Make sure it's always set.
            echo $x;
        }
    }
    
  2. Define a default value for the variable:

    function myFunction($a) {
        $x = ''; // Set a default which gets overridden for certain paths.
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        echo $x;
    }
    
  3. Add a value for the missing path:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
    
            // We add support for the missing case.
            default:
                $x = '';
                break;
        }
    
        echo $x;
    }
    
Loading history...
44
    }
45
46
    public function testxsNMTOKENSInvalidDataProvider()
47
    {
48
        return array(
49
            array('', 'an empty value is not valid, unless xsi:nil is used'),
50
        );
51
    }
52
53
    /**
54
     * Sets up the fixture, for example, opens a network connection.
55
     * This method is called before a test is executed.
56
     */
57
    protected function setUp()
58
    {
59
        parent::setUp();
60
    }
61
62
    /**
63
     * Tears down the fixture, for example, closes a network connection.
64
     * This method is called after a test is executed.
65
     */
66
    protected function tearDown()
67
    {
68
        parent::tearDown();
69
    }
70
}
71