xsIntegerTest::testxsIntegerValidDataProvider() - Code Metrics - Inspection of "getting basic test framework in place" - Algo-Web/xsdTypes - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#26)

by Christopher

created 2017-07-06 15:39 UTC

xsIntegerTest::testxsIntegerValidDataProvider() A

↳ Parent: xsIntegerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	10
rs	9.4285
cc	1
eloc	7
nc	1
nop	0

<?php


namespace AlgoWeb\xsdTypes;

/**
 * Generated Test Class.
 */
class xsIntegerTest extends \PHPUnit_Framework_TestCase
{
    /**
     * @dataProvider testxsIntegerValidDataProvider
     */
    public function testxsIntegerValid($input, $message)
    {
        try {
            $d = new xsInteger($input);
            $s = (string)$d;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        } catch (\Exception $e) {
            $this->fail($message . ' with Exception ' . $e->getMessage());
        }
    }

    public function testxsIntegerValidDataProvider()
    {
        return array(
            array('122', ''),
            array('00122', 'leading zeros are permitted'),
            array('0', ''),
            array('+3', ''),
            array('-1', ''),
        );
    }

    /**
     * @dataProvider testxsIntegerInvalidDataProvider
     */
    public function testxsIntegerInvalid($input, $message)
    {
        try {
            $d = new xsInteger($input);
            $s = (string)$d;
            $this->fail($message);
        } catch (\Exception $e) {

        }
        $this->assertEquals('', $s, $message);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }

    public function testxsIntegerInvalidDataProvider()
    {
        return array(
            array('3.', 'an integer must not contain a decimal point'),
            array('3.0', 'an integer must not contain a decimal point'),
            array('', 'an empty value is not valid, unless xsi:nil is used'),
        );
    }

    /**
     * Sets up the fixture, for example, opens a network connection.
     * This method is called before a test is executed.
     */
    protected function setUp()
    {
        parent::setUp();
    }

    /**
     * Tears down the fixture, for example, closes a network connection.
     * This method is called after a test is executed.
     */
    protected function tearDown()
    {
        parent::tearDown();
    }
}


1			<?php
2
3
4			namespace AlgoWeb\xsdTypes;
5
6			/**
7			* Generated Test Class.
8			*/
9			class xsIntegerTest extends \PHPUnit_Framework_TestCase
10			{
11			/**
12			* @dataProvider testxsIntegerValidDataProvider
13			*/
14			public function testxsIntegerValid($input, $message)
15			{
16			try {
17			$d = new xsInteger($input);
18			$s = (string)$d;
			0 ignored issues – show Unused Code introduced 2017-07-06 14:58 UTC by Report Bug Copy Issue Report `$s` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
19			} catch (\Exception $e) {
20			$this->fail($message . ' with Exception ' . $e->getMessage());
21			}
22			}
23
24			public function testxsIntegerValidDataProvider()
25			{
26			return array(
27			array('122', ''),
28			array('00122', 'leading zeros are permitted'),
29			array('0', ''),
30			array('+3', ''),
31			array('-1', ''),
32			);
33			}
34
35			/**
36			* @dataProvider testxsIntegerInvalidDataProvider
37			*/
38			public function testxsIntegerInvalid($input, $message)
39			{
40			try {
41			$d = new xsInteger($input);
42			$s = (string)$d;
43			$this->fail($message);
44			} catch (\Exception $e) {
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-07-06 14:58 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
45			}
46			$this->assertEquals('', $s, $message);
			0 ignored issues – show Bug introduced 2017-07-06 14:58 UTC by Report Bug Copy Issue Report The variable `$s` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
47			}
48
49			public function testxsIntegerInvalidDataProvider()
50			{
51			return array(
52			array('3.', 'an integer must not contain a decimal point'),
53			array('3.0', 'an integer must not contain a decimal point'),
54			array('', 'an empty value is not valid, unless xsi:nil is used'),
55			);
56			}
57
58			/**
59			* Sets up the fixture, for example, opens a network connection.
60			* This method is called before a test is executed.
61			*/
62			protected function setUp()
63			{
64			parent::setUp();
65			}
66
67			/**
68			* Tears down the fixture, for example, closes a network connection.
69			* This method is called after a test is executed.
70			*/
71			protected function tearDown()
72			{
73			parent::tearDown();
74			}
75			}
76

Algo-Web / xsdTypes

Pull Request — master (#26)

xsIntegerTest::testxsIntegerValidDataProvider() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like