xsDateTime::fixValue() - Code Metrics - Inspection of "Finishing up Types" - Algo-Web/xsdTypes - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#22)

by Christopher

created 2017-07-05 09:44 UTC

xsDateTime::fixValue() A

↳ Parent: xsDateTime

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	6
Ratio	100 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	6
loc	6
rs	9.4285
cc	1
eloc	4
nc	1
nop	0

<?php

namespace AlgoWeb\xsdTypes;

use AlgoWeb\xsdTypes\Facets\MinMaxTrait;

/**
 * The type xsd:dateTime represents a specific date and time in the format CCYY-MM-DDThh:mm:ss.sss, which is a
 * concatenation of the date and time forms, separated by a literal letter "T". All of the same rules that apply to
 * the date and time types are applicable to xsd:dateTime as well.
 *
 * An optional time zone expression may be added at the end of the value. The letter Z is used to indicate Coordinated
 * Universal Time (UTC). All other time zones are represented by their difference from Coordinated Universal Time
 * in the format +hh:mm, or -hh:mm. These values may range from -14:00 to 14:00. For example, US Eastern Standard Time,
 * which is five hours behind UTC, is represented as -05:00. If no time zone value is present, it is considered
 * unknown; it is not assumed to be UTC.
 * @package AlgoWeb\xsdTypes
 */
class xsDateTime extends xsAnySimpleType

{
    use MinMaxTrait;

    /**
     * Construct.
     *
     * @param string $value
     */
    public function __construct($value)
    {
        parent::__construct($value);
        $this->setWhiteSpaceFacet("collapse");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
    }

    public function fixValue()
    {
        parent::fixValue();
        $v = new \DateTime($this->value);
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->value = $v->format(\DateTime::RFC3339);
    }

    protected function isOK()
    {
        $this->CheckMinMax(new \Date($this->value));
    }
}



1		<?php
2
3		namespace AlgoWeb\xsdTypes;
4
5		use AlgoWeb\xsdTypes\Facets\MinMaxTrait;
6
7		/**
8		* The type xsd:dateTime represents a specific date and time in the format CCYY-MM-DDThh:mm:ss.sss, which is a
9		* concatenation of the date and time forms, separated by a literal letter "T". All of the same rules that apply to
10		* the date and time types are applicable to xsd:dateTime as well.
11		*
12		* An optional time zone expression may be added at the end of the value. The letter Z is used to indicate Coordinated
13		* Universal Time (UTC). All other time zones are represented by their difference from Coordinated Universal Time
14		* in the format +hh:mm, or -hh:mm. These values may range from -14:00 to 14:00. For example, US Eastern Standard Time,
15		* which is five hours behind UTC, is represented as -05:00. If no time zone value is present, it is considered
16		* unknown; it is not assumed to be UTC.
17		* @package AlgoWeb\xsdTypes
18		*/
19	View Code Duplication	class xsDateTime extends xsAnySimpleType
		1 ignored issue – show Duplication introduced 2017-07-05 08:58 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
20		{
21		use MinMaxTrait;
22
23		/**
24		* Construct.
25		*
26		* @param string $value
27		*/
28		public function __construct($value)
29		{
30		parent::__construct($value);
31		$this->setWhiteSpaceFacet("collapse");
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-07-05 09:46 UTC by Report Bug Copy Issue Report The string literal `collapse` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
32		}
33
34		public function fixValue()
35		{
36		parent::fixValue();
37		$v = new \DateTime($this->value);
		1 ignored issue – show Coding Style introduced 2017-07-05 09:46 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
38		$this->value = $v->format(\DateTime::RFC3339);
39		}
40
41		protected function isOK()
42		{
43		$this->CheckMinMax(new \Date($this->value));
44		}
45		}
		0 ignored issues – show Coding Style introduced 2017-07-05 09:46 UTC by Report Bug Copy Issue Report As per coding style, files should not end with a newline character. This check marks files that end in a newline character, i.e. an empy line. Loading history...
46

Algo-Web / xsdTypes

Pull Request — master (#22)

xsDateTime::fixValue() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like