Passed
Pull Request — master (#22)
by Christopher
01:59
created

xsGYear   A

Complexity

Total Complexity 3

Size/Duplication

Total Lines 28
Duplicated Lines 100 %

Coupling/Cohesion

Components 1
Dependencies 2

Importance

Changes 0
Metric Value
wmc 3
c 0
b 0
f 0
lcom 1
cbo 2
dl 28
loc 28
rs 10

3 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 5 5 1
A fixValue() 7 7 1
A isOK() 4 4 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace AlgoWeb\xsdTypes;
4
5
use AlgoWeb\xsdTypes\Facets\MinMaxTrait;
6
7
/**
8
 * The type xsd:gYear represents a specific calendar year. The letter g signifies "Gregorian." The format of xsd:gYear
9
 * is CCYY. No left truncation is allowed. To represent years later than 9999, additional digits can be added to the
10
 * left of the year value. To represent years before 0001, a preceding minus sign ("-") is allowed.
11
 *
12
 * An optional time zone expression may be added at the end of the value. The letter Z is used to indicate Coordinated
13
 * Universal Time (UTC). All other time zones are represented by their difference from Coordinated Universal Time in
14
 * the format +hh:mm, or -hh:mm. These values may range from -14:00 to 14:00. For example, US Eastern Standard Time,
15
 * which is five hours behind UTC, is represented as -05:00. If no time zone value is present, it is considered
16
 * unknown; it is not assumed to be UTC.
17
 * @package AlgoWeb\xsdTypes
18
 */
19 View Code Duplication
class xsGYear extends xsAnySimpleType
1 ignored issue
show
Duplication introduced by
This class seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
20
{
21
    use MinMaxTrait;
22
23
    /**
24
     * Construct.
25
     *
26
     * @param string $value
27
     */
28
    public function __construct($value)
29
    {
30
        parent::__construct($value);
31
        $this->setWhiteSpaceFacet("collapse");
0 ignored issues
show
Coding Style Comprehensibility introduced by
The string literal collapse does not require double quotes, as per coding-style, please use single quotes.

PHP provides two ways to mark string literals. Either with single quotes 'literal' or with double quotes "literal". The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences.

String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (\') and the backslash (\\). Every other character is displayed as is.

Double quoted string literals may contain other variables or more complex escape sequences.

<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

will print an indented: Single is Value

If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear.

For more information on PHP string literals and available escape sequences see the PHP core documentation.

Loading history...
32
    }
33
34
    public function fixValue()
35
    {
36
        parent::fixValue();
37
        $v = new \DateTime($this->value);
38
        //TODO: TechDebt, This needs to format to
0 ignored issues
show
Coding Style Best Practice introduced by
Comments for TODO tasks are often forgotten in the code; it might be better to use a dedicated issue tracker.
Loading history...
39
        $this->value = $v->format('Y');
40
    }
41
42
    protected function isOK()
43
    {
44
        $this->CheckMinMax(new \Date($this->value));
45
    }
46
}
0 ignored issues
show
Coding Style introduced by
As per coding style, files should not end with a newline character.

This check marks files that end in a newline character, i.e. an empy line.

Loading history...
47