AlgoWeb\xsdTypes\AxillaryClasses\Calender

Complexity

Total Complexity

34

Size/Duplication

Total Lines	153
Duplicated Lines	33.33 %

Coupling/Cohesion

Components	2
Dependencies	0

Importance

Changes	6
Bugs	2	Features	0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	1
B	validateInput()	6	9	7
B	valdidateState()	0	9	7
A	getMaxDays()	0	7	2
A	getYearOrHolder()	0	7	2
A	fromMonth()	9	9	3
A	fromYearMonth()	9	9	3
A	fromYear()	9	9	3
A	fromDay()	9	9	3
A	fromMonthDay()	9	9	3

<?php
/**
 * Created by PhpStorm.
 * User: Barnso
 * Date: 14/07/2017
 * Time: 8:28 PM.
 */
namespace AlgoWeb\xsdTypes\AxillaryClasses;

class Calender

Since you have declared the constructor as private, maybe you should also declare the class as final.

{
    const timezoneRegexPattern = '([-+][0-1]\d:[0-6]\d|Z*)';

This class constant is not uppercase (expected TIMEZONEREGEXPATTERN).

    private $year;
    private $month;
    private $day;
    private $timeZone;

    /**
     * Calender constructor.
     *
     * @param int|null    $year
     * @param int|null    $month
     * @param int|null    $day
     * @param string|null $timezone
     */
    private function __construct($year = null, $month = null, $day = null, $timezone = null)
    {
        $this->validateInput($year, $month, $day);
        $this->year = $year;
        $this->month = $month;
        $this->day = $day;
        $this->timeZone = $timezone;
        $this->valdidateState();
    }

    /**
     * @param int $year  |null

Should the type for parameter $year not be integer|null?

     * @param int $month |null

Should the type for parameter $month not be integer|null?

     * @param int $day   |null

Should the type for parameter $day not be integer|null?

     *
     * @return void
     */
    private function validateInput($year = null, $month = null, $day = null)
    {
        if (null === $year && null === $month && null === $day) {
            throw new \InvalidArgumentException('A Caldender class must have at least a day, month, or year');
        }
        if (null !== $year && null === $month && null !== $day) {
            throw new \InvalidArgumentException('a year day value is not valid');
        }
    }

    /**
     * @return void
     */
    private function valdidateState()
    {
        if (null !== $this->day && (1 > $this->day || $this->getMaxDays() < $this->day)) {
            throw new \InvalidArgumentException('the day must be greater 0 and less then 32');
        }
        if (null !== $this->month && (1 > $this->month || 12 < $this->month)) {
            throw new \InvalidArgumentException('the month must be greater 0 and less then 12');
        }
    }

    /**
     * @return int
     */
    private function getMaxDays()
    {
        if (null !== $this->month) {
            return cal_days_in_month(CAL_GREGORIAN, $this->month, $this->getYearOrHolder());
        }
        return 31;
    }

    /**
     * @return int

Should the return type not be string|integer?

     */
    private function getYearOrHolder()
    {
        if (null == $this->year) {

It seems like you are loosely comparing $this->year of type integer|null against null; this is ambiguous if the integer can be zero. Consider using a strict comparison === instead.

            return '2016';
        }
        return $this->year;
    }

    /**
     * @param string $day should match regex pattern ----\d\d
     *
     * @return \AlgoWeb\xsdTypes\AxillaryClasses\Calender
     */
    public static function fromDay($day)

This method seems to be duplicated in your project.

    {
        $re = '/----(0[1-9]|1[0-9]|2[0-9]|3[0-1]|[1-9])([-+][0-1]\d:[0-6]\d|Z*)/';
        preg_match_all($re, $day, $matches, PREG_SET_ORDER, 0);
        if (count($matches) != 1 && count($matches[0]) != 3) {
            throw new \InvalidArgumentException('Unable to extract day from input string');
        }
        return new self(null, null, $matches[0][1], $matches[0][2]);
    }

    /**
     * @param string $monthDay
     *
     * @return \AlgoWeb\xsdTypes\AxillaryClasses\Calender
     */
    public static function fromMonthDay($monthDay)

This method seems to be duplicated in your project.

    {
        $re = '/--(1[0-2]|0[1-9]|[1-9])-(0[1-9]|1[0-9]|2[0-9]|3[0-1]|[1-9])([-+][0-1]\d:[0-6]\d|Z*)/';
        preg_match_all($re, $monthDay, $matches, PREG_SET_ORDER, 0);
        if (count($matches) != 1 && count($matches[0]) != 4) {
            throw new \InvalidArgumentException('Unable to extract month day from input string');
        }
        return new self(null, $matches[0][1], $matches[0][2], $matches[0][3]);
    }

    /**
     * @param string $month
     *
     * @return \AlgoWeb\xsdTypes\AxillaryClasses\Calender
     */
    public static function fromMonth($month)

This method seems to be duplicated in your project.

    {
        $re = '/--(1[0-2]|0[1-9]|[1-9])([-+][0-1]\d:[0-6]\d|Z*)/';
        preg_match_all($re, $month, $matches, PREG_SET_ORDER, 0);
        if (count($matches) != 1 && count($matches[0]) != 3) {
            throw new \InvalidArgumentException('Unable to extract month from input string');
        }
        return new self(null, $matches[0][1], null, $matches[0][2]);
    }

    /**
     * @param string $yearMonth
     *
     * @return \AlgoWeb\xsdTypes\AxillaryClasses\Calender
     */
    public static function fromYearMonth($yearMonth)

This method seems to be duplicated in your project.

    {
        $re = '/(\d{4})-(1[0-2]|0[1-9]|[1-9])([-+][0-1]\d:[0-6]\d|Z*)/';
        preg_match_all($re, $yearMonth, $matches, PREG_SET_ORDER, 0);
        if (count($matches) != 1 && count($matches[0]) != 3) {
            throw new \InvalidArgumentException('Unable to extract month from input string');
        }
        return new self($matches[0][1], null, $matches[0][2], $matches[0][3]);
    }

    /**
     * @param string $year
     *
     * @return \AlgoWeb\xsdTypes\AxillaryClasses\Calender
     */
    public static function fromYear($year)

This method seems to be duplicated in your project.

    {
        $re = '/(\d{4})([-+][0-1]\d:[0-6]\d|Z*)/';
        preg_match_all($re, $year, $matches, PREG_SET_ORDER, 0);
        if (count($matches) != 1 && count($matches[0]) != 3) {
            throw new \InvalidArgumentException('Unable to extract month from input string');
        }
        return new self($matches[0][1], null, null, $matches[0][2]);
    }
}