Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 20 | View Code Duplication | class xsGMonthDay extends xsAnySimpleType |
|
| 21 | { |
||
| 22 | use MinMaxTrait; |
||
| 23 | |||
| 24 | /** |
||
| 25 | * Construct. |
||
| 26 | * |
||
| 27 | * @param string $value |
||
| 28 | */ |
||
| 29 | public function __construct($value) |
||
| 30 | { |
||
| 31 | parent::__construct($value); |
||
| 32 | $this->setWhiteSpaceFacet('collapse'); |
||
| 33 | } |
||
| 34 | |||
| 35 | public function fixValue() |
||
| 36 | { |
||
| 37 | parent::fixValue(); |
||
| 38 | $monthDayObject = CalenderFactory::fromMonthDay($this->value); |
||
|
|
|||
| 39 | } |
||
| 40 | |||
| 41 | protected function isOK() |
||
| 45 | } |
||
| 46 |
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.