POData\BatchProcessor\BatchProcessor

Complexity

Total Complexity

13

Size/Duplication

Total Lines	85
Duplicated Lines	0 %

Importance

Changes	1
Bugs	1	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	getResponse()	0	11	2
A	getService()	0	3	1
B	handleBatch()	0	23	5
A	getBoundary()	0	3	1
A	getParser()	0	6	2
A	__construct()	0	4	1
A	getRequest()	0	3	1

<?php
namespace POData\BatchProcessor;

use POData\BaseService;
use POData\UriProcessor\RequestDescription;

class BatchProcessor
{
    protected $service;
    protected $data;
    protected $batchBoundary = '';
    protected $request;
    protected $changeSetProcessors = [];

    /**
     * @param BaseService        $service
     * @param RequestDescription $request
     */
    public function __construct(BaseService $service, RequestDescription $request)
    {
        $this->service = $service;
        $this->request = $request;
    }

    public function getBoundary()
    {
        return $this->batchBoundary;
    }

    public function handleBatch()
    {
        $host = $this->getService()->getHost();
        $contentType = $host->getRequestContentType();
        assert('multipart/mixed;' === substr($contentType, 0, 16));

The call to assert() has too few arguments starting with description.

        $this->data = trim($this->getRequest()->getData());

It seems like $this->getRequest()->getData() can also be of type array; however, parameter $str of trim() does only seem to accept string, maybe add an additional type check?

        $this->data = preg_replace('~\r\n?~', "\n", $this->data);
        $this->batchBoundary = substr($contentType, 26);

        $matches = explode('--' . $this->batchBoundary, $this->data);

Are you sure $this->batchBoundary of type false|string can be used in concatenation?

        foreach ($matches as $match) {
            $match = trim($match);
            if ('' === $match || '--' === $match) {
                continue;
            }
            $header = explode("\n\n", $match)[0];
            $isChangeset = false === strpos($header, 'Content-Type: application/http');
            $this->changeSetProcessors[] = $this->getParser($this->getService(), $match, $isChangeset);
        }

        foreach ($this->changeSetProcessors as $csp) {
            $csp->handleData();
            $csp->process();
        }
    }

    public function getResponse()
    {
        $response = '';
        $splitter =  '--' . $this->batchBoundary . "\r\n";
        $raw = $this->changeSetProcessors;
        foreach ($raw as $contentID => &$workingObject) {
            $response .= $splitter;
            $response .= $workingObject->getResponse() . "\r\n";
        }
        $response .= trim($splitter) . "--\r\n";
        return $response;
    }


    protected function getParser(BaseService $service, $match, $isChangeset)
    {
        if ($isChangeset) {
            return new ChangeSetParser($service, $match);
        }
        return new QueryParser($service, $match);
    }

    /**
     * @return BaseService
     */
    public function getService()
    {
        return $this->service;
    }

    /**
     * @return RequestDescription
     */
    public function getRequest()
    {
        return $this->request;
    }
}