Completed
Pull Request — master (#63)
by Christopher
08:25
created
src/POData/UriProcessor/UriProcessor.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -208,7 +208,7 @@  discard block
 block discarded – undo
208 208
      */
209 209
     protected function executePut()
210 210
     {
211
-        return $this->executeBase(function ($uriProcessor, $segment) {
211
+        return $this->executeBase(function($uriProcessor, $segment) {
212 212
             $requestMethod = $uriProcessor->getService()->getOperationContext()->incomingRequest()->getMethod();
213 213
             $resourceSet = $segment->getTargetResourceSetWrapper();
214 214
             $keyDescriptor = $segment->getKeyDescriptor();
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
231 231
      */
232 232
     protected function executeDelete()
233 233
     {
234
-        return $this->executeBase(function ($uriProcessor, $segment) {
234
+        return $this->executeBase(function($uriProcessor, $segment) {
235 235
             $requestMethod = $uriProcessor->getService()->getOperationContext()->incomingRequest()->getMethod();
236 236
             $resourceSet = $segment->getTargetResourceSetWrapper();
237 237
             $keyDescriptor = $segment->getKeyDescriptor();
Please login to merge, or discard this patch.
src/POData/BaseService.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -665,7 +665,7 @@  discard block
 block discarded – undo
665 665
      */
666 666
     protected function compareETag(
667 667
         &$entryObject,
668
-        ResourceType &$resourceType,
668
+        ResourceType & $resourceType,
669 669
         &$needToSerializeResponse
670 670
     ) {
671 671
         $needToSerializeResponse = true;
@@ -716,7 +716,7 @@  discard block
 block discarded – undo
716 716
             // but that is causing an issue in Linux env where the
717 717
             // firefix browser is unable to parse the ETag in this case.
718 718
             // Need to follow up PHP core devs for this.
719
-            $eTag = ODataConstants::HTTP_WEAK_ETAG_PREFIX.$eTag.'"';
719
+            $eTag = ODataConstants::HTTP_WEAK_ETAG_PREFIX . $eTag . '"';
720 720
             if (!is_null($ifMatch)) {
721 721
                 if (0 != strcmp($eTag, $ifMatch)) {
722 722
                     // Requested If-Match value does not match with current
@@ -739,7 +739,7 @@  discard block
 block discarded – undo
739 739
             // but that is causing an issue in Linux env where the
740 740
             // firefix browser is unable to parse the ETag in this case.
741 741
             // Need to follow up PHP core devs for this.
742
-            $eTag = ODataConstants::HTTP_WEAK_ETAG_PREFIX.$eTag.'"';
742
+            $eTag = ODataConstants::HTTP_WEAK_ETAG_PREFIX . $eTag . '"';
743 743
         }
744 744
 
745 745
         return $eTag;
@@ -758,7 +758,7 @@  discard block
 block discarded – undo
758 758
      *                     for use in a URI) there are etag properties, NULL if
759 759
      *                     there is no etag property
760 760
      */
761
-    protected function getETagForEntry(&$entryObject, ResourceType &$resourceType)
761
+    protected function getETagForEntry(&$entryObject, ResourceType & $resourceType)
762 762
     {
763 763
         $eTag = null;
764 764
         $comma = null;
@@ -777,8 +777,8 @@  discard block
 block discarded – undo
777 777
                 );
778 778
             }
779 779
 
780
-            $eTagBase = $eTag.$comma;
781
-            $eTag = $eTagBase.((null == $value) ? 'null' : $type->convertToOData($value));
780
+            $eTagBase = $eTag . $comma;
781
+            $eTag = $eTagBase . ((null == $value) ? 'null' : $type->convertToOData($value));
782 782
 
783 783
             $comma = ',';
784 784
         }
Please login to merge, or discard this patch.
src/POData/UriProcessor/RequestExpander.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -194,7 +194,7 @@  discard block
 block discarded – undo
194 194
      *
195 195
      * @return bool true if a segment was pushed, false otherwise
196 196
      */
197
-    private function pushSegmentForNavigationProperty(ResourceProperty &$resourceProperty)
197
+    private function pushSegmentForNavigationProperty(ResourceProperty & $resourceProperty)
198 198
     {
199 199
         if ($resourceProperty->getTypeKind() == ResourceTypeKind::ENTITY) {
200 200
             assert(!empty($this->getStack()->getSegmentNames()), '!is_empty($this->getStack()->getSegmentNames())');
@@ -279,7 +279,7 @@  discard block
 block discarded – undo
279 279
      *
280 280
      * @return bool true if the segment was push, false otherwise
281 281
      */
282
-    private function pushSegment($segmentName, ResourceSetWrapper &$resourceSetWrapper)
282
+    private function pushSegment($segmentName, ResourceSetWrapper & $resourceSetWrapper)
283 283
     {
284 284
         return $this->getStack()->pushSegment($segmentName, $resourceSetWrapper);
285 285
     }
Please login to merge, or discard this patch.
src/POData/UriProcessor/XML2Array.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@
 block discarded – undo
35 35
                     throw new \Exception();
36 36
                 }
37 37
             } catch (\Exception $ex) {
38
-                throw new \Exception('[XML2Array] Error parsing the XML string.'.PHP_EOL.$ex->getMessage());
38
+                throw new \Exception('[XML2Array] Error parsing the XML string.' . PHP_EOL . $ex->getMessage());
39 39
             }
40 40
         } elseif (is_object($input_xml)) {
41 41
             if (get_class($input_xml) != 'DOMDocument') {
Please login to merge, or discard this patch.
POData/UriProcessor/ResourcePathProcessor/SegmentParser/SegmentParser.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -315,7 +315,7 @@  discard block
 block discarded – undo
315 315
                 if ($hasPredicate) {
316 316
                     $this->_assertion(!$current->isSingleResult());
317 317
                     $keyDescriptor = $this->_createKeyDescriptor(
318
-                        $identifier.'('.$keyPredicate.')',
318
+                        $identifier . '(' . $keyPredicate . ')',
319 319
                         $projectedProperty->getResourceType(),
320 320
                         $keyPredicate
321 321
                     );
@@ -394,7 +394,7 @@  discard block
 block discarded – undo
394 394
         $descriptor->setTargetKind(TargetKind::RESOURCE());
395 395
         if ($keyPredicate !== null) {
396 396
             $keyDescriptor = $this->_createKeyDescriptor(
397
-                $segmentIdentifier.'('.$keyPredicate.')',
397
+                $segmentIdentifier . '(' . $keyPredicate . ')',
398 398
                 $resourceSetWrapper->getResourceType(),
399 399
                 $keyPredicate
400 400
             );
Please login to merge, or discard this patch.
POData/UriProcessor/ResourcePathProcessor/SegmentParser/KeyDescriptor.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -273,7 +273,7 @@
 block discarded – undo
273 273
                 if (!array_key_exists($keyName, $this->_namedValues)) {
274 274
                     $keysAsString = null;
275 275
                     foreach (array_keys($keyProperties) as $key) {
276
-                        $keysAsString .= $key.', ';
276
+                        $keysAsString .= $key . ', ';
277 277
                     }
278 278
 
279 279
                     $keysAsString = rtrim($keysAsString, ' ,');
Please login to merge, or discard this patch.
src/POData/UriProcessor/RequestDescription.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -660,7 +660,7 @@  discard block
 block discarded – undo
660 660
      *
661 661
      * @param InternalOrderByInfo &$internalOrderByInfo The sorting information
662 662
      */
663
-    public function setInternalOrderByInfo(InternalOrderByInfo &$internalOrderByInfo)
663
+    public function setInternalOrderByInfo(InternalOrderByInfo & $internalOrderByInfo)
664 664
     {
665 665
         $this->internalOrderByInfo = $internalOrderByInfo;
666 666
     }
@@ -681,7 +681,7 @@  discard block
 block discarded – undo
681 681
      * @param InternalSkipTokenInfo &$internalSkipTokenInfo The paging information
682 682
      */
683 683
     public function setInternalSkipTokenInfo(
684
-        InternalSkipTokenInfo &$internalSkipTokenInfo
684
+        InternalSkipTokenInfo & $internalSkipTokenInfo
685 685
     ) {
686 686
         $this->_internalSkipTokenInfo = $internalSkipTokenInfo;
687 687
     }
@@ -707,7 +707,7 @@  discard block
 block discarded – undo
707 707
      *
708 708
      * @param RootProjectionNode &$rootProjectionNode Root of the projection tree
709 709
      */
710
-    public function setRootProjectionNode(RootProjectionNode &$rootProjectionNode)
710
+    public function setRootProjectionNode(RootProjectionNode & $rootProjectionNode)
711 711
     {
712 712
         $this->_rootProjectionNode = $rootProjectionNode;
713 713
     }
@@ -996,7 +996,7 @@  discard block
 block discarded – undo
996 996
         if (!$isSupportedVersion) {
997 997
             $availableVersions = null;
998 998
             foreach (self::getKnownDataServiceVersions() as $version1) {
999
-                $availableVersions .= $version1->toString().', ';
999
+                $availableVersions .= $version1->toString() . ', ';
1000 1000
             }
1001 1001
 
1002 1002
             $availableVersions = rtrim($availableVersions, ', ');
Please login to merge, or discard this patch.
src/POData/UriProcessor/QueryProcessor/FunctionDescription.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -64,13 +64,13 @@  discard block
 block discarded – undo
64 64
      */
65 65
     public function getPrototypeAsString()
66 66
     {
67
-        $str = $this->returnType->getFullTypeName().' '.$this->name.'(';
67
+        $str = $this->returnType->getFullTypeName() . ' ' . $this->name . '(';
68 68
 
69 69
         foreach ($this->argumentTypes as $argumentType) {
70
-            $str .= $argumentType->getFullTypeName().', ';
70
+            $str .= $argumentType->getFullTypeName() . ', ';
71 71
         }
72 72
 
73
-        return rtrim($str, ', ').')';
73
+        return rtrim($str, ', ') . ')';
74 74
     }
75 75
 
76 76
     /**
@@ -484,7 +484,7 @@  discard block
 block discarded – undo
484 484
     {
485 485
         $string = null;
486 486
         foreach ($argExpressions as $argExpression) {
487
-            $string .= $argExpression->getType()->getFullTypeName().', ';
487
+            $string .= $argExpression->getType()->getFullTypeName() . ', ';
488 488
         }
489 489
 
490 490
         $string = rtrim($string, ', ');
@@ -719,7 +719,7 @@  discard block
 block discarded – undo
719 719
         if ($function == null) {
720 720
             $protoTypes = null;
721 721
             foreach ($functions as $function) {
722
-                $protoTypes .= $function->getPrototypeAsString().'; ';
722
+                $protoTypes .= $function->getPrototypeAsString() . '; ';
723 723
             }
724 724
 
725 725
             throw ODataException::createSyntaxError(
Please login to merge, or discard this patch.
UriProcessor/QueryProcessor/SkipTokenParser/InternalSkipTokenInfo.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -67,9 +67,9 @@  discard block
 block discarded – undo
67 67
      * @param ResourceType                  &$resourceType            Reference to the type of the resource pointed by the request uri
68 68
      */
69 69
     public function __construct(
70
-        InternalOrderByInfo &$internalOrderByInfo,
70
+        InternalOrderByInfo & $internalOrderByInfo,
71 71
         $orderByValuesInSkipToken,
72
-        ResourceType &$resourceType
72
+        ResourceType & $resourceType
73 73
     ) {
74 74
         $this->_internalOrderByInfo = $internalOrderByInfo;
75 75
         $this->_orderByValuesInSkipToken = $orderByValuesInSkipToken;
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
         $high = $searcArraySize;
140 140
         do {
141 141
             $matchLevel = 0;
142
-            $mid = $low + round(($high - $low) / 2);
142
+            $mid = $low + round(($high - $low)/2);
143 143
             $result = $comparer($keyObject, $searchArray[$mid]);
144 144
             if ($result > 0) {
145 145
                 $low = $mid + 1;
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
                     } elseif ($isLastSegment) {
266 266
                         $type = $subPathSegment->getInstanceType();
267 267
                         $value = $type->convertToOData($currentObject);
268
-                        $nextPageLink .= $value.', ';
268
+                        $nextPageLink .= $value . ', ';
269 269
                     }
270 270
                 } catch (\ReflectionException $reflectionException) {
271 271
                     throw ODataException::createInternalServerError(
Please login to merge, or discard this patch.