Test Setup Failed
Pull Request — master (#140)
by Christopher
05:01
created
src/POData/Common/Messages/skipTokenParser.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@
 block discarded – undo
44 44
         $expectedCount
45 45
     ) {
46 46
         return 'The number of keys \'' . $skipTokenValuesCount . '\' in skip token with value \'' . $skipToken .
47
-               '\' did not match the number of ordering constraints \'' . $expectedCount . '\' for the resource type.';
47
+                '\' did not match the number of ordering constraints \'' . $expectedCount . '\' for the resource type.';
48 48
     }
49 49
 
50 50
     /**
Please login to merge, or discard this patch.
src/POData/Common/Messages/request.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@  discard block
 block discarded – undo
17 17
     public static function requestVersionTooLow($requestedVersion, $requiredVersion)
18 18
     {
19 19
         return 'Request version \''.$requestedVersion.'\' is not supported for the request payload. The only'
20
-               .' supported version is \''.$requiredVersion.'\'.';
20
+                .' supported version is \''.$requiredVersion.'\'.';
21 21
     }
22 22
 
23 23
     /**
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
     public static function requestVersionIsBiggerThanProtocolVersion($requiredVersion, $configuredVersion)
33 33
     {
34 34
         return 'The response requires that version '.$requiredVersion.' of the protocol be used, but the'
35
-               .' MaxProtocolVersion of the data service is set to '.$configuredVersion.'.';
35
+                .' MaxProtocolVersion of the data service is set to '.$configuredVersion.'.';
36 36
     }
37 37
 
38 38
     /**
@@ -65,6 +65,6 @@  discard block
 block discarded – undo
65 65
         $availableVersions
66 66
     ) {
67 67
         return 'The version value '.$requestedVersion.' in the header '.$requestHeaderName.' is not'
68
-               .' supported, available versions are '.$availableVersions;
68
+                .' supported, available versions are '.$availableVersions;
69 69
     }
70 70
 }
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -16,8 +16,8 @@  discard block
 block discarded – undo
16 16
      */
17 17
     public static function requestVersionTooLow($requestedVersion, $requiredVersion)
18 18
     {
19
-        return 'Request version \''.$requestedVersion.'\' is not supported for the request payload. The only'
20
-               .' supported version is \''.$requiredVersion.'\'.';
19
+        return 'Request version \'' . $requestedVersion . '\' is not supported for the request payload. The only'
20
+               .' supported version is \'' . $requiredVersion . '\'.';
21 21
     }
22 22
 
23 23
     /**
@@ -31,8 +31,8 @@  discard block
 block discarded – undo
31 31
      */
32 32
     public static function requestVersionIsBiggerThanProtocolVersion($requiredVersion, $configuredVersion)
33 33
     {
34
-        return 'The response requires that version '.$requiredVersion.' of the protocol be used, but the'
35
-               .' MaxProtocolVersion of the data service is set to '.$configuredVersion.'.';
34
+        return 'The response requires that version ' . $requiredVersion . ' of the protocol be used, but the'
35
+               .' MaxProtocolVersion of the data service is set to ' . $configuredVersion . '.';
36 36
     }
37 37
 
38 38
     /**
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
      */
47 47
     public static function requestDescriptionInvalidVersionHeader($versionAsString, $headerName)
48 48
     {
49
-        return 'The header '.$headerName.' has malformed version value '.$versionAsString;
49
+        return 'The header ' . $headerName . ' has malformed version value ' . $versionAsString;
50 50
     }
51 51
 
52 52
     /**
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
         $requestedVersion,
65 65
         $availableVersions
66 66
     ) {
67
-        return 'The version value '.$requestedVersion.' in the header '.$requestHeaderName.' is not'
68
-               .' supported, available versions are '.$availableVersions;
67
+        return 'The version value ' . $requestedVersion . ' in the header ' . $requestHeaderName . ' is not'
68
+               .' supported, available versions are ' . $availableVersions;
69 69
     }
70 70
 }
Please login to merge, or discard this patch.
src/POData/Common/Messages/orderByInfo.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
     public static function orderByParserPropertyNotFound($resourceTypeName, $propertyName)
51 51
     {
52 52
         return 'Error in the \'orderby\' clause. Type ' . $resourceTypeName
53
-               . ' does not have a property named \'' . $propertyName . '\'.';
53
+                . ' does not have a property named \'' . $propertyName . '\'.';
54 54
     }
55 55
 
56 56
     /**
@@ -179,6 +179,6 @@  discard block
 block discarded – undo
179 179
     public static function orderByParserFailedToAccessOrInitializeProperty($propertyName, $parentObjectName)
180 180
     {
181 181
         return 'OrderBy parser failed to access or initialize the property ' . $propertyName .
182
-               ' of ' . $parentObjectName;
182
+                ' of ' . $parentObjectName;
183 183
     }
184 184
 }
Please login to merge, or discard this patch.
src/POData/UriProcessor/RequestExpander.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -194,7 +194,7 @@  discard block
 block discarded – undo
194 194
      *
195 195
      * @return bool true if a segment was pushed, false otherwise
196 196
      */
197
-    private function pushSegmentForNavigationProperty(ResourceProperty &$resourceProperty)
197
+    private function pushSegmentForNavigationProperty(ResourceProperty & $resourceProperty)
198 198
     {
199 199
         if ($resourceProperty->getTypeKind() == ResourceTypeKind::ENTITY()) {
200 200
             assert(!empty($this->getStack()->getSegmentNames()), '!is_empty($this->getStack()->getSegmentNames())');
@@ -279,7 +279,7 @@  discard block
 block discarded – undo
279 279
      *
280 280
      * @return bool true if the segment was push, false otherwise
281 281
      */
282
-    private function pushSegment($segmentName, ResourceSetWrapper &$resourceSetWrapper)
282
+    private function pushSegment($segmentName, ResourceSetWrapper & $resourceSetWrapper)
283 283
     {
284 284
         return $this->getStack()->pushSegment($segmentName, $resourceSetWrapper);
285 285
     }
Please login to merge, or discard this patch.
src/POData/OperationContext/ServiceHost.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
222 222
                     );
223 223
                 }
224 224
 
225
-                $builtServiceUri = $requestUriScheme .'://' . $this->getAbsoluteRequestUri()->getHost();
225
+                $builtServiceUri = $requestUriScheme . '://' . $this->getAbsoluteRequestUri()->getHost();
226 226
 
227 227
                 if (($requestUriScheme == 'http' && $requestUriPort != '80') ||
228 228
                     ($requestUriScheme == 'https' && $requestUriPort != '443')
@@ -511,7 +511,7 @@  discard block
 block discarded – undo
511 511
             $this->getOperationContext()->outgoingResponse()->setContentLength($value);
512 512
         } else {
513 513
             throw ODataException::notAcceptableError(
514
-                'ContentLength: '.$value.' is invalid'
514
+                'ContentLength: ' . $value . ' is invalid'
515 515
             );
516 516
         }
517 517
     }
@@ -556,7 +556,7 @@  discard block
 block discarded – undo
556 556
     public function setResponseStatusCode($value)
557 557
     {
558 558
         if (!is_numeric($value)) {
559
-            $msg = 'Invalid, non-numeric, status code: '.$value;
559
+            $msg = 'Invalid, non-numeric, status code: ' . $value;
560 560
             throw ODataException::createInternalServerError($msg);
561 561
         }
562 562
         $floor = floor($value/100);
Please login to merge, or discard this patch.
src/POData/ObjectModel/CynicSerialiser.php 2 patches
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -565,10 +565,10 @@
 block discarded – undo
565 565
     {
566 566
         $queryParameterString = null;
567 567
         foreach ([ODataConstants::HTTPQUERY_STRING_FILTER,
568
-                     ODataConstants::HTTPQUERY_STRING_EXPAND,
569
-                     ODataConstants::HTTPQUERY_STRING_ORDERBY,
570
-                     ODataConstants::HTTPQUERY_STRING_INLINECOUNT,
571
-                     ODataConstants::HTTPQUERY_STRING_SELECT, ] as $queryOption) {
568
+                        ODataConstants::HTTPQUERY_STRING_EXPAND,
569
+                        ODataConstants::HTTPQUERY_STRING_ORDERBY,
570
+                        ODataConstants::HTTPQUERY_STRING_INLINECOUNT,
571
+                        ODataConstants::HTTPQUERY_STRING_SELECT, ] as $queryOption) {
572 572
             $value = $this->getService()->getHost()->getQueryStringItem($queryOption);
573 573
             if (null !== $value) {
574 574
                 if (null !== $queryParameterString) {
Please login to merge, or discard this patch.
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
         $this->loadStackIfEmpty();
112 112
 
113 113
         $stackCount = count($this->lightStack);
114
-        $topOfStack = $this->lightStack[$stackCount-1];
114
+        $topOfStack = $this->lightStack[$stackCount - 1];
115 115
         $resourceType = $this->getService()->getProvidersWrapper()->resolveResourceType($topOfStack[0]);
116 116
         assert($resourceType instanceof ResourceType, get_class($resourceType));
117 117
         $rawProp = $resourceType->getAllProperties();
@@ -133,8 +133,8 @@  discard block
 block discarded – undo
133 133
         $nonRelCount = count($nonRelProp);
134 134
         assert(
135 135
             $rawCount == $relCount + $nonRelCount,
136
-            'Raw property count '.$rawCount.', does not equal sum of relProp count, '.$relCount
137
-            .', and nonRelPropCount,'.$nonRelCount
136
+            'Raw property count ' . $rawCount . ', does not equal sum of relProp count, ' . $relCount
137
+            .', and nonRelPropCount,' . $nonRelCount
138 138
         );
139 139
 
140 140
         // now mask off against projNodes
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
181 181
                 .' $propKind != ResourcePropertyKind::RESOURCE_REFERENCE'
182 182
             );
183 183
             $propTail = ResourcePropertyKind::RESOURCE_REFERENCE == $propKind ? 'entry' : 'feed';
184
-            $propType = 'application/atom+xml;type='.$propTail;
184
+            $propType = 'application/atom+xml;type=' . $propTail;
185 185
             $propName = $prop->getName();
186 186
             $nuLink->title = $propName;
187 187
             $nuLink->name = ODataConstants::ODATA_RELATED_NAMESPACE . $propName;
@@ -224,7 +224,7 @@  discard block
 block discarded – undo
224 224
      *
225 225
      * @return ODataFeed
226 226
      */
227
-    public function writeTopLevelElements(QueryResult &$entryObjects)
227
+    public function writeTopLevelElements(QueryResult & $entryObjects)
228 228
     {
229 229
         assert(is_array($entryObjects->results), '!is_array($entryObjects->results)');
230 230
 
@@ -346,7 +346,7 @@  discard block
 block discarded – undo
346 346
      *
347 347
      * @return ODataPropertyContent
348 348
      */
349
-    public function writeTopLevelComplexObject(QueryResult &$complexValue, $propertyName, ResourceType &$resourceType)
349
+    public function writeTopLevelComplexObject(QueryResult & $complexValue, $propertyName, ResourceType & $resourceType)
350 350
     {
351 351
         $result = $complexValue->results;
352 352
 
@@ -374,14 +374,14 @@  discard block
 block discarded – undo
374 374
      *
375 375
      * @return ODataPropertyContent
376 376
      */
377
-    public function writeTopLevelBagObject(QueryResult &$bagValue, $propertyName, ResourceType &$resourceType)
377
+    public function writeTopLevelBagObject(QueryResult & $bagValue, $propertyName, ResourceType & $resourceType)
378 378
     {
379 379
         $result = $bagValue->results;
380 380
 
381 381
         $propertyContent = new ODataPropertyContent();
382 382
         $odataProperty = new ODataProperty();
383 383
         $odataProperty->name = $propertyName;
384
-        $odataProperty->typeName = 'Collection('.$resourceType->getFullName().')';
384
+        $odataProperty->typeName = 'Collection(' . $resourceType->getFullName() . ')';
385 385
         $odataProperty->value = $this->writeBagValue($resourceType, $result);
386 386
 
387 387
         $propertyContent->properties[] = $odataProperty;
@@ -396,7 +396,7 @@  discard block
 block discarded – undo
396 396
      *
397 397
      * @return ODataPropertyContent
398 398
      */
399
-    public function writeTopLevelPrimitive(QueryResult &$primitiveValue, ResourceProperty &$resourceProperty = null)
399
+    public function writeTopLevelPrimitive(QueryResult & $primitiveValue, ResourceProperty & $resourceProperty = null)
400 400
     {
401 401
         assert(null !== $resourceProperty, 'Resource property must not be null');
402 402
         $result = new ODataPropertyContent();
@@ -478,7 +478,7 @@  discard block
 block discarded – undo
478 478
      * @param $result
479 479
      * @return ODataBagContent|null
480 480
      */
481
-    protected function writeBagValue(ResourceType &$resourceType, $result)
481
+    protected function writeBagValue(ResourceType & $resourceType, $result)
482 482
     {
483 483
         assert(null === $result || is_array($result), 'Bag parameter must be null or array');
484 484
         $typeKind = $resourceType->getResourceTypeKind();
@@ -511,7 +511,7 @@  discard block
 block discarded – undo
511 511
      * @param  string|null          $propertyName
512 512
      * @return ODataPropertyContent
513 513
      */
514
-    protected function writeComplexValue(ResourceType &$resourceType, &$result, $propertyName = null)
514
+    protected function writeComplexValue(ResourceType & $resourceType, &$result, $propertyName = null)
515 515
     {
516 516
         assert(is_object($result), 'Supplied $customObject must be an object');
517 517
 
@@ -665,7 +665,7 @@  discard block
 block discarded – undo
665 665
         $skipToken = $internalOrderByInfo->buildSkipTokenValue($lastObject);
666 666
         assert(null !== $skipToken, '!is_null($skipToken)');
667 667
         $token = (1 < $numSegments) ? '$skiptoken=' : '$skip=';
668
-        $skipToken = '?'.$queryParameterString.$token.$skipToken;
668
+        $skipToken = '?' . $queryParameterString . $token . $skipToken;
669 669
 
670 670
         return $skipToken;
671 671
     }
@@ -915,7 +915,7 @@  discard block
 block discarded – undo
915 915
      *
916 916
      * @return string
917 917
      */
918
-    private function primitiveToString(IType &$type, $primitiveValue)
918
+    private function primitiveToString(IType & $type, $primitiveValue)
919 919
     {
920 920
         if ($type instanceof Boolean) {
921 921
             $stringValue = (true === $primitiveValue) ? 'true' : 'false';
@@ -940,6 +940,6 @@  discard block
 block discarded – undo
940 940
         if (28 < $resourceKind) {
941 941
             return false;
942 942
         }
943
-        return 0 == ($resourceKind % 4);
943
+        return 0 == ($resourceKind%4);
944 944
     }
945 945
 }
Please login to merge, or discard this patch.
src/POData/UriProcessor/SegmentStack.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@
 block discarded – undo
50 50
      * @throws InvalidOperationException
51 51
      * @return bool                      true if the segment was push, false otherwise
52 52
      */
53
-    public function pushSegment($segmentName, ResourceSetWrapper &$resourceSetWrapper)
53
+    public function pushSegment($segmentName, ResourceSetWrapper & $resourceSetWrapper)
54 54
     {
55 55
         if (!is_string($segmentName)) {
56 56
             throw new InvalidOperationException('segmentName must be a string');
Please login to merge, or discard this patch.
src/POData/BaseService.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -681,7 +681,7 @@  discard block
 block discarded – undo
681 681
      */
682 682
     protected function compareETag(
683 683
         &$entryObject,
684
-        ResourceType &$resourceType,
684
+        ResourceType & $resourceType,
685 685
         &$needToSerializeResponse
686 686
     ) {
687 687
         $needToSerializeResponse = true;
@@ -775,7 +775,7 @@  discard block
 block discarded – undo
775 775
      *                        for use in a URI) there are etag properties, NULL if
776 776
      *                        there is no etag property
777 777
      */
778
-    protected function getETagForEntry(&$entryObject, ResourceType &$resourceType)
778
+    protected function getETagForEntry(&$entryObject, ResourceType & $resourceType)
779 779
     {
780 780
         $eTag = null;
781 781
         $comma = null;
Please login to merge, or discard this patch.