Completed
Pull Request — master (#91)
by Christopher
04:09
created
src/POData/UriProcessor/QueryProcessor/OrderByParser/OrderByParser.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -410,7 +410,7 @@
 block discarded – undo
410 410
             $this->topLevelComparisonFunction = $this->comparisonFunctions[0];
411 411
         } else {
412 412
             $funcList = $this->comparisonFunctions;
413
-            $this->topLevelComparisonFunction = function ($object1, $object2) use ($funcList) {
413
+            $this->topLevelComparisonFunction = function($object1, $object2) use ($funcList) {
414 414
                 $ret = 0;
415 415
                 foreach ($funcList as $f) {
416 416
                     $ret = $f($object1, $object2);
Please login to merge, or discard this patch.
src/POData/Writers/Atom/AtomODataWriter.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -789,7 +789,7 @@
 block discarded – undo
789 789
     {
790 790
         $writer = $this->xmlWriter;
791 791
         $writer->startElementNs(null, ODataConstants::ATOM_PUBLISHING_SERVICE_ELEMENT_NAME, ODataConstants::APP_NAMESPACE);
792
-        $writer->writeAttributeNs(ODataConstants::XML_NAMESPACE_PREFIX, ODataConstants::XML_BASE_ATTRIBUTE_NAME, null, $this->baseUri. '/');
792
+        $writer->writeAttributeNs(ODataConstants::XML_NAMESPACE_PREFIX, ODataConstants::XML_BASE_ATTRIBUTE_NAME, null, $this->baseUri . '/');
793 793
         $writer->writeAttributeNs(ODataConstants::XMLNS_NAMESPACE_PREFIX, self::ATOM_NAMESPACE_PREFIX, null, ODataConstants::ATOM_NAMESPACE);
794 794
         //$writer->writeAttributeNs(ODataConstants::XMLNS_NAMESPACE_PREFIX, self::APP_NAMESPACE_PREFIX, null, ODataConstants::APP_NAMESPACE);
795 795
 
Please login to merge, or discard this patch.
src/POData/Providers/Metadata/ResourceAssociationType.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -124,7 +124,7 @@
 block discarded – undo
124 124
      * @param ResourceEntityType    $resourceType     Resource type for the source end
125 125
      * @param ResourceProperty      $resourceProperty Resource property for the source end
126 126
      *
127
-     * @return ResourceAssociationTypeEndRelated Association type end for the
127
+     * @return ResourceAssociationTypeEnd|null Association type end for the
128 128
      *                                           given parameters
129 129
      */
130 130
     public function getRelatedResourceAssociationSetEnd(
Please login to merge, or discard this patch.
src/POData/Providers/Metadata/SimpleMetadataProvider.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -7,7 +7,6 @@
 block discarded – undo
7 7
 use AlgoWeb\ODataMetadata\MetadataV3\edm\TEntityTypeType;
8 8
 use Illuminate\Support\Str;
9 9
 use POData\Common\InvalidOperationException;
10
-use POData\Common\NotImplementedException;
11 10
 use POData\Providers\Metadata\Type\IType;
12 11
 use POData\Providers\Metadata\Type\TypeCode;
13 12
 
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -278,7 +278,7 @@  discard block
 block discarded – undo
278 278
         $type = null;
279 279
         if ($typeKind == ResourceTypeKind::ENTITY) {
280 280
             list($oet, $entitySet) = $this->metadataManager->addEntityType($name);
281
-            assert($oet instanceof TEntityTypeType, "Entity type ".$name. " not successfully added");
281
+            assert($oet instanceof TEntityTypeType, "Entity type " . $name . " not successfully added");
282 282
             $type = new ResourceEntityType($refClass, $oet, $this);
283 283
             $typeName = $type->getFullName();
284 284
             $returnName = Str::plural($typeName);
@@ -567,7 +567,7 @@  discard block
 block discarded – undo
567 567
             );
568 568
         }
569 569
         if (!in_array($resourceMult, $allowedMult)) {
570
-            throw new InvalidOperationException("Supplied multiplicity ".$resourceMult." not valid");
570
+            throw new InvalidOperationException("Supplied multiplicity " . $resourceMult . " not valid");
571 571
         }
572 572
 
573 573
         $resourcePropertyKind = ('*' == $resourceMult)
Please login to merge, or discard this patch.
src/POData/Providers/Metadata/ResourceFunctionType.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
         $expectedParms = count($baseParms);
124 124
         $actualParms = count($parms);
125 125
         if ($expectedParms != $actualParms) {
126
-            $msg = "Was expecting ". $expectedParms. " arguments, received ".$actualParms." instead";
126
+            $msg = "Was expecting " . $expectedParms . " arguments, received " . $actualParms . " instead";
127 127
             throw new \InvalidArgumentException($msg);
128 128
         }
129 129
 
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
     private function checkBlacklist($func, $fromArray = false)
138 138
     {
139 139
         if (in_array($func, $this->blacklist) || in_array(strtolower($func), $this->blacklist)) {
140
-            $msg = (true === $fromArray ? "First element of " : "")."FunctionName blacklisted";
140
+            $msg = (true === $fromArray ? "First element of " : "") . "FunctionName blacklisted";
141 141
             throw new \InvalidArgumentException($msg);
142 142
         }
143 143
     }
Please login to merge, or discard this patch.