POData\UriProcessor\QueryProcessor\ExpressionParser\ExpressionParser::generateComparisonExpression()

Complexity

Conditions	20
Paths	416

Size

Total Lines	130
Code Lines	68

Duplication

Lines	20
Ratio	15.38 %

Importance

Changes

0

<?php
    private static function generateComparisonExpression($left, $right, $expressionToken, $isPHPExpressionProvider)

The variable name $isPHPExpressionProvider exceeds the maximum configured length of 20.

    {
        FunctionDescription::verifyRelationalOpArguments($expressionToken, $left, $right);

        //We need special handling for comparison of following types:
        //1. EdmString
        //2. DateTime
        //3. Guid
        //4. Binary
        //Will make these comparison as function calls, which will
        // be converted to language specific function call by expression
        // provider
        $string = new StringType();
        if ($left->typeIs($string) && $right->typeIs($string)) {

This code seems to be duplicated across your project.

            $strcmpFunctions = FunctionDescription::stringComparisonFunctions();
            $left = new FunctionCallExpression($strcmpFunctions[0], [$left, $right]);

Consider using a different name than the parameter $left. This often makes code more readable.

            $right = new ConstantExpression(0, new Int32());

Consider using a different name than the parameter $right. This often makes code more readable.

        }

        $dateTime = new DateTime();
        if ($left->typeIs($dateTime) && $right->typeIs($dateTime)) {

This code seems to be duplicated across your project.

            $dateTimeCmpFunctions = FunctionDescription::dateTimeComparisonFunctions();
            $left = new FunctionCallExpression($dateTimeCmpFunctions[0], [$left, $right]);

Consider using a different name than the parameter $left. This often makes code more readable.

            $right = new ConstantExpression(0, new Int32());

Consider using a different name than the parameter $right. This often makes code more readable.

        }

        $guid = new Guid();
        if ($left->typeIs($guid) && $right->typeIs($guid)) {

This code seems to be duplicated across your project.

            $guidEqualityFunctions = FunctionDescription::guidEqualityFunctions();

The variable name $guidEqualityFunctions exceeds the maximum configured length of 20.

            $left = new FunctionCallExpression($guidEqualityFunctions[0], [$left, $right]);

Consider using a different name than the parameter $left. This often makes code more readable.

            $right = new ConstantExpression(true, new Boolean());

true is of type boolean, but the function expects a string.

Consider using a different name than the parameter $right. This often makes code more readable.

        }

        $binary = new Binary();
        if ($left->typeIs($binary) && $right->typeIs($binary)) {

This code seems to be duplicated across your project.

            $binaryEqualityFunctions = FunctionDescription::binaryEqualityFunctions();

The variable name $binaryEqualityFunctions exceeds the maximum configured length of 20.

            $left = new FunctionCallExpression($binaryEqualityFunctions[0], [$left, $right]);

Consider using a different name than the parameter $left. This often makes code more readable.

            $right = new ConstantExpression(true, new Boolean());

true is of type boolean, but the function expects a string.

Consider using a different name than the parameter $right. This often makes code more readable.

        }

        $null = new Null1();
        if ($left->typeIs($null) || $right->typeIs($null)) {
            // If the end user is responsible for implementing IExpressionProvider
            // then the sub-tree for a nullability check would be:

            //          RelationalExpression(EQ/NE)
            //                    |
            //               ------------
            //               |           |
            //               |           |
            //            CustomerID    NULL

            // Otherwise (In case of default PHPExpressionProvider):

            //  CustomerID eq null
            //  ==================

            //              FunctionCallExpression(is_null)
            //                       |
            //                       |- Signature => bool (typeof(CustomerID))

38% of this comment could be valid code. Did you maybe forget this after debugging?

            //                       |- args => {CustomerID}

37% of this comment could be valid code. Did you maybe forget this after debugging?

            //  CustomerID ne null
            //  ==================

            //              UnaryExpression (not)
            //                       |
            //              FunctionCallExpression(is_null)
            //                       |
            //                       |- Signature => bool (typeof(CustomerID))

38% of this comment could be valid code. Did you maybe forget this after debugging?

            //                       |- args => {CustomerID}

37% of this comment could be valid code. Did you maybe forget this after debugging?

            if ($isPHPExpressionProvider) {
                $arg = $left->typeIs($null) ? $right : $left;
                $isNullFunctionDescription = new FunctionDescription('is_null', new Boolean(), [$arg->getType()]);

The variable name $isNullFunctionDescription exceeds the maximum configured length of 20.

                switch ($expressionToken->Text) {
                    case ODataConstants::KEYWORD_EQUAL:
                        return new FunctionCallExpression($isNullFunctionDescription, [$arg]);
                        break;

break is not strictly necessary here and could be removed.

                    case ODataConstants::KEYWORD_NOT_EQUAL:
                        return new UnaryExpression(
                            new FunctionCallExpression($isNullFunctionDescription, [$arg]),
                            ExpressionType::NOT_LOGICAL,
                            new Boolean()
                        );
                        break;

break is not strictly necessary here and could be removed.

                }
            }
        }

        switch ($expressionToken->Text) {
            case ODataConstants::KEYWORD_EQUAL:
                return new RelationalExpression(
                    $left,
                    $right,
                    ExpressionType::EQUAL
                );
            case ODataConstants::KEYWORD_NOT_EQUAL:
                return new RelationalExpression(
                    $left,
                    $right,
                    ExpressionType::NOTEQUAL
                );
            case ODataConstants::KEYWORD_GREATERTHAN:
                return new RelationalExpression(
                    $left,
                    $right,
                    ExpressionType::GREATERTHAN
                );
            case ODataConstants::KEYWORD_GREATERTHAN_OR_EQUAL:
                return new RelationalExpression(
                    $left,
                    $right,
                    ExpressionType::GREATERTHAN_OR_EQUAL
                );
            case ODataConstants::KEYWORD_LESSTHAN:
                return new RelationalExpression(
                    $left,
                    $right,
                    ExpressionType::LESSTHAN
                );
            default:
                return new RelationalExpression(
                    $left,
                    $right,
                    ExpressionType::LESSTHAN_OR_EQUAL
                );
        }
    }
}