Algo-Web / POData

src/POData/Providers/Metadata/SimpleMetadataProvider.php

Unused Use Statements -2 removed lines

@@ -2,13 +2,11 @@
 
 namespace POData\Providers\Metadata;
 
-use AlgoWeb\ODataMetadata\IsOK;
 use AlgoWeb\ODataMetadata\MetadataManager;
 use AlgoWeb\ODataMetadata\MetadataV3\edm\TComplexTypeType;
 use AlgoWeb\ODataMetadata\MetadataV3\edm\TEntityTypeType;
 use Illuminate\Support\Str;
 use POData\Common\InvalidOperationException;
-use POData\Common\NotImplementedException;
 use POData\Providers\Metadata\Type\IType;
 use POData\Providers\Metadata\Type\TypeCode;
 

Spacing +4 added lines, -4 removed lines

@@ -295,7 +295,7 @@ 
         $type = null;
         if ($typeKind == ResourceTypeKind::ENTITY) {
             list($oet, $entitySet) = $this->metadataManager->addEntityType($name);
-            assert($oet instanceof TEntityTypeType, "Entity type ".$name. " not successfully added");
+            assert($oet instanceof TEntityTypeType, "Entity type " . $name . " not successfully added");
             $type = new ResourceEntityType($refClass, $oet, $this);
             $typeName = $type->getFullName();
             $returnName = Str::plural($typeName);
@@ -584,7 +584,7 @@ 
             );
         }
         if (!in_array($resourceMult, $allowedMult)) {
-            throw new InvalidOperationException("Supplied multiplicity ".$resourceMult." not valid");
+            throw new InvalidOperationException("Supplied multiplicity " . $resourceMult . " not valid");
         }
 
         $resourcePropertyKind = ('*' == $resourceMult)
@@ -852,12 +852,12 @@ 
             throw new \InvalidArgumentException($msg);
         }
         if (array_key_exists($name, $this->resourceSets)) {
-            $msg = "Resource set with same name, ". $name. ", exists";
+            $msg = "Resource set with same name, " . $name . ", exists";
             throw new \InvalidArgumentException($msg);
         }
         $typeName = $returnType->getName();
         if (!array_key_exists($typeName, $this->OdataEntityMap)) {
-            $msg = "Mapping not defined for ".$typeName;
+            $msg = "Mapping not defined for " . $typeName;
             throw new \InvalidArgumentException($msg);
         }
         $metaReturn = $this->OdataEntityMap[$typeName];

src/POData/BaseService.php

Doc Comments +1 added lines

@@ -674,6 +674,7 @@
      *                                               True if response needs to be
      *                                               serialized, False otherwise
      * @param bool         $needToSerializeResponse
+     * @param QueryResult $entryObject
      *
      * @return string|null The ETag for the entry object if it has eTag properties
      *                     NULL otherwise

src/POData/ObjectModel/ObjectModelSerializerBase.php

Indentation +1 added lines, -1 removed lines

@@ -469,7 +469,7 @@
                     ODataConstants::HTTPQUERY_STRING_ORDERBY,
                     ODataConstants::HTTPQUERY_STRING_INLINECOUNT,
                     ODataConstants::HTTPQUERY_STRING_SELECT
-                 ] as $queryOption) {
+                    ] as $queryOption) {
             $value = $this->getService()->getHost()->getQueryStringItem($queryOption);
             if (!is_null($value)) {
                 if (!is_null($queryParameterString)) {

src/POData/ObjectModel/IObjectSerialiser.php

Spacing +4 added lines, -4 removed lines

@@ -30,7 +30,7 @@ 
      *
      * @return ODataFeed
      */
-    public function writeTopLevelElements(QueryResult &$entryObjects);
+    public function writeTopLevelElements(QueryResult & $entryObjects);
 
     /**
      * Write top level url element.
@@ -60,7 +60,7 @@ 
      *
      * @return ODataPropertyContent
      */
-    public function writeTopLevelComplexObject(QueryResult &$complexValue, $propertyName, ResourceType &$resourceType);
+    public function writeTopLevelComplexObject(QueryResult & $complexValue, $propertyName, ResourceType & $resourceType);
 
     /**
      * Write top level bag resource.
@@ -71,7 +71,7 @@ 
      *
      * @return ODataPropertyContent
      */
-    public function writeTopLevelBagObject(QueryResult &$BagValue, $propertyName, ResourceType &$resourceType);
+    public function writeTopLevelBagObject(QueryResult & $BagValue, $propertyName, ResourceType & $resourceType);
 
     /**
      * Write top level primitive value.
@@ -81,7 +81,7 @@ 
      *
      * @return ODataPropertyContent
      */
-    public function writeTopLevelPrimitive(QueryResult &$primitiveValue, ResourceProperty &$resourceProperty = null);
+    public function writeTopLevelPrimitive(QueryResult & $primitiveValue, ResourceProperty & $resourceProperty = null);
 
     /**
      * Gets reference to the request submitted by client.

src/POData/Providers/ProvidersWrapper.php

Doc Comments +2 added lines, -2 removed lines

@@ -629,7 +629,7 @@ 
      * @param InternalOrderByInfo   $orderBy     The orderBy information
      * @param int                   $top         The top count
      * @param int                   $skip        The skip count
-     * @param InternalSkipTokenInfo $skipToken   The skip token
+     * @param SkipTokenInfo $skipToken   The skip token
      *
      * @return QueryResult
      */
@@ -832,7 +832,7 @@ 
 
     /**
      * @param ResourceSet $resourceSet          The entity set containing the entity to fetch
-     * @param object      $sourceEntityInstance The source entity instance
+     * @param KeyDescriptor      $sourceEntityInstance The source entity instance
      * @param object      $data                 The New data for the entity instance.
      *
      * returns object|null returns the newly created model if successful, or null if model creation failed.

src/POData/UriProcessor/UriProcessor.php

Spacing +3 added lines, -3 removed lines

@@ -185,7 +185,7 @@ 
      */
     protected function executePut()
     {
-        $this->executeBase(function ($uriProcessor, $segment) {
+        $this->executeBase(function($uriProcessor, $segment) {
             $requestMethod = $uriProcessor->getService()->getOperationContext()->incomingRequest()->getMethod();
             $resourceSet = $segment->getTargetResourceSetWrapper();
             $keyDescriptor = $segment->getKeyDescriptor();
@@ -218,7 +218,7 @@ 
      */
     protected function executeDelete()
     {
-        $this->executeBase(function ($uriProcessor, $segment) {
+        $this->executeBase(function($uriProcessor, $segment) {
             $requestMethod = $uriProcessor->getService()->getOperationContext()->incomingRequest()->getMethod();
             $resourceSet = $segment->getTargetResourceSetWrapper();
             $keyDescriptor = $segment->getKeyDescriptor();
@@ -387,7 +387,7 @@ 
                     //TODO: why are these null?  see #98
                     null, // $orderby
                     null, // $top
-                    null,  // $skip
+                    null, // $skip
                     $skipToken
                 );
 

src/POData/UriProcessor/UriProcessorNew.php

Unused Use Statements -5 removed lines

@@ -7,16 +7,11 @@
 use POData\Common\ODataException;
 use POData\IService;
 use POData\OperationContext\HTTPRequestMethod;
-use POData\Providers\Metadata\ResourcePropertyKind;
 use POData\Providers\ProvidersWrapper;
-use POData\Providers\Query\QueryResult;
-use POData\Providers\Query\QueryType;
 use POData\UriProcessor\Interfaces\IUriProcessor;
-use POData\UriProcessor\QueryProcessor\QueryProcessor;
 use POData\UriProcessor\ResourcePathProcessor\ResourcePathProcessor;
 use POData\UriProcessor\ResourcePathProcessor\SegmentParser\SegmentDescriptor;
 use POData\UriProcessor\ResourcePathProcessor\SegmentParser\TargetKind;
-use POData\UriProcessor\ResourcePathProcessor\SegmentParser\TargetSource;
 
 /**
  * Class UriProcessorNew.

Doc Comments +4 added lines, -4 removed lines

@@ -297,7 +297,7 @@ 
     /**
      * @param $resourceSet
      * @param $keyDescriptor
-     * @param $requestMethod
+     * @param HTTPRequestMethod $requestMethod
      * @throws ODataException
      */
     protected function checkUriValidForSuppliedVerb($resourceSet, $keyDescriptor, $requestMethod)
@@ -311,7 +311,7 @@ 
     }
 
     /**
-     * @param $segment
+     * @param SegmentDescriptor $segment
      */
     private function executeGetSingleton($segment)
     {
@@ -321,7 +321,7 @@ 
     }
 
     /**
-     * @param $segment
+     * @param SegmentDescriptor $segment
      */
     private function executeGetResource($segment)
     {
@@ -349,7 +349,7 @@ 
     }
 
     /**
-     * @param $segment
+     * @param SegmentDescriptor $segment
      */
     private function executeGetLink($segment)
     {