Completed
Pull Request — master (#61)
by Alex
03:53
created
src/POData/UriProcessor/UriProcessor.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -382,7 +382,7 @@
 block discarded – undo
382 382
             $segment->setResult($entityInstance);
383 383
         } else {
384 384
             $skip = (null == $this->getRequest()) ? 0 : $this->getRequest()->getSkipCount();
385
-            $skip = (null == $skip) ? 0 :$skip;
385
+            $skip = (null == $skip) ? 0 : $skip;
386 386
             $queryResult = $this->getProviders()->getResourceSet(
387 387
                 $this->getRequest()->queryType,
388 388
                 $segment->getTargetResourceSetWrapper(),
Please login to merge, or discard this patch.
src/POData/UriProcessor/SegmentStack.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@
 block discarded – undo
50 50
      *
51 51
      * @return bool true if the segment was push, false otherwise
52 52
      */
53
-    public function pushSegment($segmentName, ResourceSetWrapper &$resourceSetWrapper)
53
+    public function pushSegment($segmentName, ResourceSetWrapper & $resourceSetWrapper)
54 54
     {
55 55
         if (!is_string($segmentName)) {
56 56
             throw new InvalidOperationException('segmentName must be a string');
Please login to merge, or discard this patch.
src/POData/Providers/Metadata/SimpleMetadataProvider.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -446,10 +446,10 @@  discard block
 block discarded – undo
446 446
 
447 447
     /**
448 448
      * @param \ReflectionClass $refClass
449
-     * @param $name
450
-     * @param $namespace
449
+     * @param string $name
450
+     * @param string|null $namespace
451 451
      * @param $typeKind
452
-     * @param $baseResourceType
452
+     * @param null|ResourceType $baseResourceType
453 453
      * @return ResourceType
454 454
      * @throws InvalidOperationException
455 455
      */
@@ -472,7 +472,7 @@  discard block
 block discarded – undo
472 472
     }
473 473
 
474 474
     /**
475
-     * @param $name
475
+     * @param string $name
476 476
      * @param ResourceType $resourceType
477 477
      * @throws InvalidOperationException
478 478
      */
Please login to merge, or discard this patch.
src/POData/Writers/Json/JsonWriter.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -158,8 +158,8 @@
 block discarded – undo
158 158
 
159 159
             case 'Edm.DateTime':
160 160
                 $dateTime = new Carbon($value, new \DateTimeZone('UTC'));
161
-                $formattedDateTime = $dateTime->format('U') * 1000;
162
-                $this->_writeCore('/Date('.$formattedDateTime.')/', /* quotes */ true);
161
+                $formattedDateTime = $dateTime->format('U')*1000;
162
+                $this->_writeCore('/Date(' . $formattedDateTime . ')/', /* quotes */ true);
163 163
                 break;
164 164
 
165 165
             case 'Edm.String':
Please login to merge, or discard this patch.
src/POData/Providers/ProvidersQueryWrapper.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -453,7 +453,7 @@
 block discarded – undo
453 453
     }
454 454
 
455 455
     /**
456
-     * @param $methodName
456
+     * @param string $methodName
457 457
      * @param $entityInstance
458 458
      * @param ResourceSet $resourceSet
459 459
      * @return ResourceType
Please login to merge, or discard this patch.
src/POData/Providers/Metadata/Type/Binary.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -119,7 +119,7 @@
 block discarded – undo
119 119
     public static function validateWithoutPrefix($value, &$outValue)
120 120
     {
121 121
         $length = strlen($value);
122
-        if (0 == $length || 0 != $length % 2) {
122
+        if (0 == $length || 0 != $length%2) {
123 123
             return false;
124 124
         }
125 125
 
Please login to merge, or discard this patch.
src/POData/ObjectModel/ObjectModelSerializer.php 2 patches
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -770,9 +770,9 @@  discard block
 block discarded – undo
770 770
     /**
771 771
      * @param $customObject
772 772
      * @param ResourceType $resourceType
773
-     * @param $relativeUri
773
+     * @param string $relativeUri
774 774
      * @param ODataPropertyContent $odataPropertyContent
775
-     * @param $resourceTypeKind
775
+     * @param ResourceTypeKind $resourceTypeKind
776 776
      * @param $navigationProperties
777 777
      * @return array
778 778
      * @throws ODataException
@@ -879,9 +879,9 @@  discard block
 block discarded – undo
879 879
     /**
880 880
      * @param $customObject
881 881
      * @param ResourceType $resourceType
882
-     * @param $relativeUri
882
+     * @param string $relativeUri
883 883
      * @param ODataPropertyContent $odataPropertyContent
884
-     * @param $projectionNodes
884
+     * @param \POData\UriProcessor\QueryProcessor\ExpandProjectionParser\ProjectionNode[] $projectionNodes
885 885
      * @param $navigationProperties
886 886
      * @return array
887 887
      * @throws ODataException
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -186,7 +186,7 @@  discard block
 block discarded – undo
186 186
     public function writeTopLevelComplexObject(
187 187
         &$complexValue,
188 188
         $propertyName,
189
-        ResourceType &$resourceType
189
+        ResourceType & $resourceType
190 190
     ) {
191 191
         $propertyContent = new ODataPropertyContent();
192 192
         $this->_writeComplexValue(
@@ -330,7 +330,7 @@  discard block
 block discarded – undo
330 330
      */
331 331
     private function _writeFeedElements(
332 332
         &$entryObjects,
333
-        ResourceType &$resourceType,
333
+        ResourceType & $resourceType,
334 334
         $title,
335 335
         $absoluteUri,
336 336
         $relativeUri,
@@ -698,7 +698,7 @@  discard block
 block discarded – undo
698 698
 
699 699
      */
700 700
     private function _primitiveToString(
701
-        ResourceType &$primitiveResourceType,
701
+        ResourceType & $primitiveResourceType,
702 702
         $primitiveValue
703 703
     ) {
704 704
         $type = $primitiveResourceType->getInstanceType();
@@ -779,9 +779,9 @@  discard block
 block discarded – undo
779 779
      */
780 780
     private function writeObjectPropertiesUnexpanded(
781 781
         $customObject,
782
-        ResourceType &$resourceType,
782
+        ResourceType & $resourceType,
783 783
         $relativeUri,
784
-        ODataPropertyContent &$odataPropertyContent,
784
+        ODataPropertyContent & $odataPropertyContent,
785 785
         $resourceTypeKind,
786 786
         $navigationProperties
787 787
     ) {
@@ -888,9 +888,9 @@  discard block
 block discarded – undo
888 888
      */
889 889
     private function writeObjectPropertiesExpanded(
890 890
         $customObject,
891
-        ResourceType &$resourceType,
891
+        ResourceType & $resourceType,
892 892
         $relativeUri,
893
-        ODataPropertyContent &$odataPropertyContent,
893
+        ODataPropertyContent & $odataPropertyContent,
894 894
         $projectionNodes,
895 895
         $navigationProperties
896 896
     ) {
Please login to merge, or discard this patch.
src/POData/Common/Messages/resourceAssociationType.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
      */
14 14
     public static function resourceAssociationTypeEndPropertyMustBeNullOrInstanceofResourceProperty($argumentName)
15 15
     {
16
-        return "The argument '".$argumentName."' must be either null or instance of 'ResourceProperty'.";
16
+        return "The argument '" . $argumentName . "' must be either null or instance of 'ResourceProperty'.";
17 17
     }
18 18
 
19 19
     /**
Please login to merge, or discard this patch.
src/POData/ObjectModel/IObjectSerialiser.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
      *
63 63
      * @return ODataPropertyContent
64 64
      */
65
-    public function writeTopLevelComplexObject(&$complexValue, $propertyName, ResourceType &$resourceType);
65
+    public function writeTopLevelComplexObject(&$complexValue, $propertyName, ResourceType & $resourceType);
66 66
 
67 67
     /**
68 68
      * Write top level bag resource.
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
      *
77 77
      * @return ODataPropertyContent
78 78
      */
79
-    public function writeTopLevelBagObject(&$BagValue, $propertyName, ResourceType &$resourceType);
79
+    public function writeTopLevelBagObject(&$BagValue, $propertyName, ResourceType & $resourceType);
80 80
 
81 81
     /**
82 82
      * Write top level primitive value.
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
      *
91 91
      * @return ODataPropertyContent
92 92
      */
93
-    public function writeTopLevelPrimitive(&$primitiveValue, ResourceProperty &$resourceProperty);
93
+    public function writeTopLevelPrimitive(&$primitiveValue, ResourceProperty & $resourceProperty);
94 94
 
95 95
     /**
96 96
      * Gets reference to the request submitted by client.
Please login to merge, or discard this patch.