Algo-Web / POData

src/POData/Writers/Metadata/MetadataWriter.php

Indentation +2 added lines, -2 removed lines

@@ -98,7 +98,7 @@ 
         $resourceTypesInContainerNamespace = array();
         $containerNamespace = $this->providersWrapper->getContainerNamespace();
         foreach ($this->_metadataManager->getResourceTypesAlongWithNamespace()
-                 as $resourceTypeNamespace => $resourceTypesWithName) {
+                    as $resourceTypeNamespace => $resourceTypesWithName) {
             if ($resourceTypeNamespace == $containerNamespace) {
                 foreach ($resourceTypesWithName as $resourceTypeName => $resourceType) {
                     $resourceTypesInContainerNamespace[] = $resourceType;
@@ -279,7 +279,7 @@ 
     private function _writeProperties(ResourceType $resourceType, $associationTypesInResourceTypeNamespace)
     {
         foreach ($this->_metadataManager->getAllVisiblePropertiesDeclaredOnThisType($resourceType)
-                 as $resourceProperty) {
+                    as $resourceProperty) {
             if ($resourceProperty->isKindOf(ResourcePropertyKind::BAG)) {
                 $this->_writeBagProperty($resourceProperty);
             } elseif ($resourceProperty->isKindOf(ResourcePropertyKind::PRIMITIVE)) {

src/POData/UriProcessor/RequestExpander.php

Doc Comments +10 added lines, -10 removed lines

@@ -170,7 +170,7 @@ 
      * Pushes a segment for the root of the tree
      * Note: Calls to this method should be balanced with calls to popSegment.
      *
-     * @return bool true if the segment was pushed, false otherwise
+     * @return boolean|null true if the segment was pushed, false otherwise
      */
     private function pushSegmentForRoot()
     {
@@ -189,7 +189,7 @@ 
      * @param ResourceProperty &$resourceProperty Current navigation property
      *                                            being written out
      *
-     * @return bool true if a segment was pushed, false otherwise
+     * @return boolean|null true if a segment was pushed, false otherwise
      *
      * @throws InvalidOperationException If this function invoked with non-navigation
      *                                   property instance
@@ -277,7 +277,7 @@ 
      * @param ResourceSetWrapper &$resourceSetWrapper The resource set wrapper
      *                                                to push
      *
-     * @return bool true if the segment was push, false otherwise
+     * @return boolean|null true if the segment was push, false otherwise
      */
     private function pushSegment($segmentName, ResourceSetWrapper &$resourceSetWrapper)
     {
@@ -301,7 +301,7 @@ 
     }
 
     /**
-     * @param $expandedProjectionNode
+     * @param ExpandedProjectionNode $expandedProjectionNode
      * @param $entry
      * @return null|\object[]
      */
@@ -327,10 +327,10 @@ 
     }
 
     /**
-     * @param $expandedProjectionNode
+     * @param ExpandedProjectionNode $expandedProjectionNode
      * @param $entry
-     * @param $resourceType
-     * @param $expandedPropertyName
+     * @param \POData\Providers\Metadata\ResourceType $resourceType
+     * @param string $expandedPropertyName
      * @throws InvalidOperationException
      * @throws \POData\Common\ODataException
      */
@@ -360,9 +360,9 @@ 
     /**
      * @param $entry
      * @param $result
-     * @param $expandedProjectionNode
-     * @param $resourceType
-     * @param $expandedPropertyName
+     * @param ExpandedProjectionNode $expandedProjectionNode
+     * @param \POData\Providers\Metadata\ResourceType $resourceType
+     * @param string $expandedPropertyName
      * @throws InvalidOperationException
      */
     private function executeCollectionExpansionProcessExpansion(

Spacing +2 added lines, -2 removed lines

@@ -194,7 +194,7 @@ 
      * @throws InvalidOperationException If this function invoked with non-navigation
      *                                   property instance
      */
-    private function pushSegmentForNavigationProperty(ResourceProperty &$resourceProperty)
+    private function pushSegmentForNavigationProperty(ResourceProperty & $resourceProperty)
     {
         if ($resourceProperty->getTypeKind() == ResourceTypeKind::ENTITY) {
             assert(!empty($this->getStack()->getSegmentNames()), '!is_empty($this->getStack()->getSegmentNames())');
@@ -279,7 +279,7 @@ 
      *
      * @return bool true if the segment was push, false otherwise
      */
-    private function pushSegment($segmentName, ResourceSetWrapper &$resourceSetWrapper)
+    private function pushSegment($segmentName, ResourceSetWrapper & $resourceSetWrapper)
     {
         $this->getStack()->pushSegment($segmentName, $resourceSetWrapper);
     }

src/POData/UriProcessor/UriProcessor.php

Unused Use Statements -6 removed lines

@@ -2,15 +2,10 @@ 
 
 namespace POData\UriProcessor;
 
-use Illuminate\Support\Str;
 use POData\Providers\ProvidersWrapper;
 use POData\Providers\Metadata\ResourcePropertyKind;
-use POData\Providers\Metadata\ResourceTypeKind;
-use POData\Providers\Metadata\ResourceSetWrapper;
-use POData\Providers\Metadata\ResourceProperty;
 use POData\Providers\Query\QueryType;
 use POData\UriProcessor\QueryProcessor\QueryProcessor;
-use POData\UriProcessor\QueryProcessor\ExpandProjectionParser\ExpandedProjectionNode;
 use POData\UriProcessor\ResourcePathProcessor\ResourcePathProcessor;
 use POData\UriProcessor\ResourcePathProcessor\SegmentParser\SegmentDescriptor;
 use POData\UriProcessor\ResourcePathProcessor\SegmentParser\TargetKind;
@@ -18,7 +13,6 @@ 
 use POData\IService;
 use POData\Common\Messages;
 use POData\Common\ODataException;
-use POData\Common\InvalidOperationException;
 use POData\Common\ODataConstants;
 use POData\Providers\Query\QueryResult;
 use POData\OperationContext\HTTPRequestMethod;

Spacing +1 added lines, -1 removed lines

@@ -382,7 +382,7 @@
             $segment->setResult($entityInstance);
         } else {
             $skip = (null == $this->getRequest()) ? 0 : $this->getRequest()->getSkipCount();
-            $skip = (null == $skip) ? 0 :$skip;
+            $skip = (null == $skip) ? 0 : $skip;
             $queryResult = $this->getProviders()->getResourceSet(
                 $this->getRequest()->queryType,
                 $segment->getTargetResourceSetWrapper(),

src/POData/UriProcessor/SegmentStack.php

Spacing +1 added lines, -1 removed lines

@@ -50,7 +50,7 @@
      *
      * @return bool true if the segment was push, false otherwise
      */
-    public function pushSegment($segmentName, ResourceSetWrapper &$resourceSetWrapper)
+    public function pushSegment($segmentName, ResourceSetWrapper & $resourceSetWrapper)
     {
         if (!is_string($segmentName)) {
             throw new InvalidOperationException('segmentName must be a string');

src/POData/Providers/Metadata/SimpleMetadataProvider.php

Doc Comments +4 added lines, -4 removed lines

@@ -446,10 +446,10 @@ 
 
     /**
      * @param \ReflectionClass $refClass
-     * @param $name
-     * @param $namespace
+     * @param string $name
+     * @param string|null $namespace
      * @param $typeKind
-     * @param $baseResourceType
+     * @param null|ResourceType $baseResourceType
      * @return ResourceType
      * @throws InvalidOperationException
      */
@@ -472,7 +472,7 @@ 
     }
 
     /**
-     * @param $name
+     * @param string $name
      * @param ResourceType $resourceType
      * @throws InvalidOperationException
      */

src/POData/Writers/Json/JsonWriter.php

Spacing +2 added lines, -2 removed lines

@@ -158,8 +158,8 @@
 
             case 'Edm.DateTime':
                 $dateTime = new Carbon($value, new \DateTimeZone('UTC'));
-                $formattedDateTime = $dateTime->format('U') * 1000;
-                $this->_writeCore('/Date('.$formattedDateTime.')/', /* quotes */ true);
+                $formattedDateTime = $dateTime->format('U')*1000;
+                $this->_writeCore('/Date(' . $formattedDateTime . ')/', /* quotes */ true);
                 break;
 
             case 'Edm.String':

src/POData/Providers/ProvidersQueryWrapper.php

Doc Comments +1 added lines, -1 removed lines

@@ -453,7 +453,7 @@
     }
 
     /**
-     * @param $methodName
+     * @param string $methodName
      * @param $entityInstance
      * @param ResourceSet $resourceSet
      * @return ResourceType

src/POData/Providers/Metadata/Type/Binary.php

Spacing +1 added lines, -1 removed lines

@@ -119,7 +119,7 @@
     public static function validateWithoutPrefix($value, &$outValue)
     {
         $length = strlen($value);
-        if (0 == $length || 0 != $length % 2) {
+        if (0 == $length || 0 != $length%2) {
             return false;
         }
 

src/POData/ObjectModel/ObjectModelSerializer.php

Doc Comments +4 added lines, -4 removed lines

@@ -770,9 +770,9 @@ 
     /**
      * @param $customObject
      * @param ResourceType $resourceType
-     * @param $relativeUri
+     * @param string $relativeUri
      * @param ODataPropertyContent $odataPropertyContent
-     * @param $resourceTypeKind
+     * @param ResourceTypeKind $resourceTypeKind
      * @param $navigationProperties
      * @return array
      * @throws ODataException
@@ -879,9 +879,9 @@ 
     /**
      * @param $customObject
      * @param ResourceType $resourceType
-     * @param $relativeUri
+     * @param string $relativeUri
      * @param ODataPropertyContent $odataPropertyContent
-     * @param $projectionNodes
+     * @param \POData\UriProcessor\QueryProcessor\ExpandProjectionParser\ProjectionNode[] $projectionNodes
      * @param $navigationProperties
      * @return array
      * @throws ODataException

Indentation -1 removed lines

@@ -695,7 +695,6 @@
      *                                            whose value need to be converted
      * @param mixed $primitiveValue Primitive value to convert
      * @return string
-
      */
     private function _primitiveToString(
         ResourceType &$primitiveResourceType,

Spacing +7 added lines, -7 removed lines

@@ -186,7 +186,7 @@ 
     public function writeTopLevelComplexObject(
         &$complexValue,
         $propertyName,
-        ResourceType &$resourceType
+        ResourceType & $resourceType
     ) {
         $propertyContent = new ODataPropertyContent();
         $this->_writeComplexValue(
@@ -330,7 +330,7 @@ 
      */
     private function _writeFeedElements(
         &$entryObjects,
-        ResourceType &$resourceType,
+        ResourceType & $resourceType,
         $title,
         $absoluteUri,
         $relativeUri,
@@ -698,7 +698,7 @@ 
 
      */
     private function _primitiveToString(
-        ResourceType &$primitiveResourceType,
+        ResourceType & $primitiveResourceType,
         $primitiveValue
     ) {
         $type = $primitiveResourceType->getInstanceType();
@@ -779,9 +779,9 @@ 
      */
     private function writeObjectPropertiesUnexpanded(
         $customObject,
-        ResourceType &$resourceType,
+        ResourceType & $resourceType,
         $relativeUri,
-        ODataPropertyContent &$odataPropertyContent,
+        ODataPropertyContent & $odataPropertyContent,
         $resourceTypeKind,
         $navigationProperties
     ) {
@@ -888,9 +888,9 @@ 
      */
     private function writeObjectPropertiesExpanded(
         $customObject,
-        ResourceType &$resourceType,
+        ResourceType & $resourceType,
         $relativeUri,
-        ODataPropertyContent &$odataPropertyContent,
+        ODataPropertyContent & $odataPropertyContent,
         $projectionNodes,
         $navigationProperties
     ) {