POData\ObjectModel\ODataExpandedResult

Complexity

Total Complexity

8

Size/Duplication

Total Lines	58
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

6 Methods

Rating	Name	Duplication	Size	Complexity
A	getEntry()	0	3	2
A	setFeed()	0	4	1
A	__construct()	0	3	1
A	setEntry()	0	4	1
A	getFeed()	0	3	2
A	getData()	0	3	1

<?php

declare(strict_types=1);
/**
 * Created by PhpStorm.
 * User: Barnso
 * Date: 16/08/2017
 * Time: 5:41 AM.
 */
namespace POData\ObjectModel;

/**
 * Class ODataExpandedResult.
 * @package POData\ObjectModel
 */
class ODataExpandedResult
{
    /**
     * Term.
     *
     * @var ODataContainerBase|null
     */
    private $data;

    /**
     * ODataExpandedResult constructor.
     *
     * @param ODataContainerBase|null $data
     */
    public function __construct(ODataContainerBase $data = null)
    {
        $this->data = $data;
    }

    /**
     * @return ODataEntry|null
     */
    public function getEntry(): ?ODataEntry
    {
        return $this->data instanceof ODataEntry ? $this->data : null;
    }

    /**
     * @param ODataEntry|null $entry
     * @return ODataExpandedResult
     */
    public function setEntry(?ODataEntry $entry): ODataExpandedResult
    {
        $this->entry = $entry;

The property entry does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        return $this;
    }

    /**
     * @return ODataFeed|null
     */
    public function getFeed(): ?ODataFeed
    {
        return $this->data instanceof ODataFeed ? $this->data : null;
    }

    /**
     * @param ODataFeed|null $feed
     * @return ODataExpandedResult
     */
    public function setFeed(?ODataFeed $feed): ODataExpandedResult
    {
        $this->feed = $feed;

The property feed does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        return $this;
    }

    public function getData(): ODataContainerBase
    {
        return $this->data;

The expression return $this->data could return the type null which is incompatible with the type-hinted return POData\ObjectModel\ODataContainerBase. Consider adding an additional type-check to rule them out.

    }
}