POData\OperationContext\Web\Illuminate\IncomingIlluminateRequest

Complexity

Total Complexity

11

Size/Duplication

Total Lines	132
Duplicated Lines	6.06 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	8	8	1
A	getRawUrl()	0	6	1
A	getRequestHeader()	0	10	3
A	getMethod()	0	4	1
A	getAllInput()	0	5	2
A	getQueryParameters()	0	23	3

<?php

namespace POData\OperationContext\Web\Illuminate;

use Illuminate\Http\Request;
use POData\OperationContext\HTTPRequestMethod;
use POData\OperationContext\IHTTPRequest;

class IncomingIlluminateRequest implements IHTTPRequest
{
    /**
     * The Illuminate request.
     *
     * @var Request
     */
    private $request;

    /**
     * The request headers.
     *
     * @var array
     */
    private $headers = [];

    /**
     * The incoming url in raw format.
     *
     * @var string
     */
    private $rawUrl = null;

    /**
     * The request method (GET, POST, PUT, DELETE or MERGE).
     *
     * @var HTTPRequestMethod HttpVerb
     */
    private $method;

    /**
     * The query options as key value.
     *
     * @var array(string, string);
     */
    private $queryOptions = [];

    /**
     * A collection that represents mapping between query
     * option and its count.
     *
     * @var array(string, int)
     */
    private $queryOptionsCount = [];

    /**
     * IncomingIlluminateRequest constructor.
     *
     * @param Request $request
     */
    public function __construct(Request $request)

You have injected the Request via parameter $request. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via getCurrentRequest().

This method seems to be duplicated in your project.

    {
        $this->request = $request;
        $this->headers = [];
        $this->queryOptions = [];
        $this->queryOptionsCount = [];
        $this->method = new HTTPRequestMethod($this->request->getMethod());
    }

    /**
     * @return string RequestURI called by User with the value of QueryString
     */
    public function getRawUrl()
    {
        $this->rawUrl = $this->request->fullUrl();

        return $this->rawUrl;
    }

    /**
     * @param string $key The header name
     *
     * @return array|null|string
     */
    public function getRequestHeader($key)
    {
        $result = $this->request->header($key);

The expression $this->request->header($key); of type string|array adds the type array to the return on line 91 which is incompatible with the return type declared by the interface POData\OperationContext\IHTTPRequest::getRequestHeader of type string|null.

        //Zend returns false for a missing header...POData needs a null
        if (false === $result || '' === $result) {
            return null;
        }

        return $result;
    }

    /**
     * Returns the Query String Parameters (QSPs) as an array of KEY-VALUE pairs.  If a QSP appears twice
     * it will have two entries in this array.
     *
     * @return array
     */
    public function getQueryParameters()
    {
        //TODO: the contract is more specific than this, it requires the name and values to be decoded

Comments for TODO tasks are often forgotten in the code; it might be better to use a dedicated issue tracker.

        //not sure how to test that...
        //Have to convert to the stranger format known to POData that deals with multiple query strings.
        //this makes this request a bit non compliant as it doesn't expose duplicate keys, something POData will
        //check for instead whatever parameter was last in the query string is set.  IE
        //odata.svc/?$format=xml&$format=json the format will be json
        $this->queryOptions = [];
        $this->queryOptionsCount = [];

        foreach ($this->request->all() as $key => $value) {
            $keyBitz = explode(';', $key);
            $newKey = strtolower($keyBitz[count($keyBitz) - 1]);
            $this->queryOptions[] = [$newKey => $value];
            if (!array_key_exists($key, $this->queryOptionsCount)) {
                $this->queryOptionsCount[$newKey] = 0;
            }
            $this->queryOptionsCount[$newKey]++;
        }

        return $this->queryOptions;
    }

    /**
     * @return HTTPRequestMethod
     */
    public function getMethod()
    {
        return $this->method;
    }

    /**
     * @return array|mixed

Consider making the return type a bit more specific; maybe use resource|string|array.

     */
    public function getAllInput()
    {
        $content = $this->request->all();
        return !empty($content) ? $content : $this->request->getContent();
    }
}