Passed
Pull Request — master (#121)
by Alex
03:55
created
src/POData/Common/Messages/streamProviderWrapper.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -87,7 +87,7 @@
 block discarded – undo
87 87
      */
88 88
     public static function streamProviderWrapperMustNotSetContentTypeAndEtag($methodName)
89 89
     {
90
-        return 'The method '.$methodName.' must not set the HTTP response headers \'Content-Type\' and \'ETag\'';
90
+        return 'The method ' . $methodName . ' must not set the HTTP response headers \'Content-Type\' and \'ETag\'';
91 91
     }
92 92
 
93 93
     /**
Please login to merge, or discard this patch.
src/POData/Common/Messages/common.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -15,8 +15,8 @@  discard block
 block discarded – undo
15 15
      */
16 16
     public static function commonArgumentShouldBeInteger($argument, $functionName)
17 17
     {
18
-        return 'The argument to the function '.$functionName.' should be integer, non-integer value \''
19
-               .$argument.'\' passed';
18
+        return 'The argument to the function ' . $functionName . ' should be integer, non-integer value \''
19
+               .$argument . '\' passed';
20 20
     }
21 21
 
22 22
     /**
@@ -30,8 +30,8 @@  discard block
 block discarded – undo
30 30
      */
31 31
     public static function commonArgumentShouldBeNonNegative($argument, $functionName)
32 32
     {
33
-        return 'The argument to the function '.$functionName.' should be non-negative, negative value \''
34
-               .$argument.'\' passed';
33
+        return 'The argument to the function ' . $functionName . ' should be non-negative, negative value \''
34
+               .$argument . '\' passed';
35 35
     }
36 36
 
37 37
     /**
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
      */
46 46
     public static function commonNotValidPrimitiveEDMType($argumentName, $functionName)
47 47
     {
48
-        return 'The argument \''.$argumentName.'\' to '.$functionName.' is not a valid EdmPrimitiveType Enum value.';
48
+        return 'The argument \'' . $argumentName . '\' to ' . $functionName . ' is not a valid EdmPrimitiveType Enum value.';
49 49
     }
50 50
 
51 51
     /**
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
      */
71 71
     public static function failedToAccessProperty($propertyName, $parentObjectName)
72 72
     {
73
-        return 'Data Service failed to access or initialize the property '.$propertyName.' of '.$parentObjectName.'.';
73
+        return 'Data Service failed to access or initialize the property ' . $propertyName . ' of ' . $parentObjectName . '.';
74 74
     }
75 75
 
76 76
     /**
@@ -93,9 +93,9 @@  discard block
 block discarded – undo
93 93
      */
94 94
     public static function badRequestInvalidPropertyNameSpecified($resourceTypeName, $propertyName)
95 95
     {
96
-        return 'Error processing request stream. The property name '.$propertyName.' specified for type '
97
-               .$resourceTypeName.' is not valid. (Check the resource set of the navigation property \''
98
-               .$propertyName.'\' is visible)';
96
+        return 'Error processing request stream. The property name ' . $propertyName . ' specified for type '
97
+               .$resourceTypeName . ' is not valid. (Check the resource set of the navigation property \''
98
+               .$propertyName . '\' is visible)';
99 99
     }
100 100
 
101 101
     /**
Please login to merge, or discard this patch.
src/POData/Common/Messages/expressionLexer.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
      */
52 52
     public static function expressionLexerInvalidCharacter($ch, $pos)
53 53
     {
54
-        return 'Invalid character \''.$ch.'\' at position '.$pos;
54
+        return 'Invalid character \'' . $ch . '\' at position ' . $pos;
55 55
     }
56 56
 
57 57
     /**
@@ -68,8 +68,8 @@  discard block
 block discarded – undo
68 68
         $protoTypes,
69 69
         $position
70 70
     ) {
71
-        return 'No applicable function found for \''.$functionName.'\' at position '.$position.' with the specified'
72
-               .' arguments. The functions considered are: '.$protoTypes;
71
+        return 'No applicable function found for \'' . $functionName . '\' at position ' . $position . ' with the specified'
72
+               .' arguments. The functions considered are: ' . $protoTypes;
73 73
     }
74 74
 
75 75
     /**
@@ -83,6 +83,6 @@  discard block
 block discarded – undo
83 83
      */
84 84
     public static function expressionLexerNoPropertyInType($property, $type, $position)
85 85
     {
86
-        return 'No property \''.$property.'\' exists in type \''.$type.'\' at position '.$position;
86
+        return 'No property \'' . $property . '\' exists in type \'' . $type . '\' at position ' . $position;
87 87
     }
88 88
 }
Please login to merge, or discard this patch.
src/POData/Common/Messages/skipTokenParser.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
      */
15 15
     public static function skipTokenParserSyntaxError($skipToken)
16 16
     {
17
-        return 'Bad Request - Error in the syntax of skiptoken \''.$skipToken.'\'';
17
+        return 'Bad Request - Error in the syntax of skiptoken \'' . $skipToken . '\'';
18 18
     }
19 19
 
20 20
     /**
@@ -40,8 +40,8 @@  discard block
 block discarded – undo
40 40
      */
41 41
     public static function skipTokenParserSkipTokenNotMatchingOrdering($skipTokenValuesCount, $skipToken, $expectedCount)
42 42
     {
43
-        return 'The number of keys \''.$skipTokenValuesCount.'\' in skip token with value \''.$skipToken
44
-               .'\' did not match the number of ordering constraints \''.$expectedCount.'\' for the resource type.';
43
+        return 'The number of keys \'' . $skipTokenValuesCount . '\' in skip token with value \'' . $skipToken
44
+               .'\' did not match the number of ordering constraints \'' . $expectedCount . '\' for the resource type.';
45 45
     }
46 46
 
47 47
     /**
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
      */
55 55
     public static function skipTokenParserNullNotAllowedForKeys($skipToken)
56 56
     {
57
-        return 'The skiptoken value '.$skipToken.' contain null value for key';
57
+        return 'The skiptoken value ' . $skipToken . ' contain null value for key';
58 58
     }
59 59
 
60 60
     /**
@@ -72,8 +72,8 @@  discard block
 block discarded – undo
72 72
      */
73 73
     public static function skipTokenParserInCompatibleTypeAtPosition($skipToken, $expectedTypeName, $position, $typeProvidedInSkipTokenName)
74 74
     {
75
-        return 'The skiptoken value \''.$skipToken.'\' contains a value of type \''.$typeProvidedInSkipTokenName
76
-               .'\' at position '.$position.' which is not compatible with the type \''.$expectedTypeName
75
+        return 'The skiptoken value \'' . $skipToken . '\' contains a value of type \'' . $typeProvidedInSkipTokenName
76
+               .'\' at position ' . $position . ' which is not compatible with the type \'' . $expectedTypeName
77 77
                .'\' of corresponding orderby constraint.';
78 78
     }
79 79
 }
Please login to merge, or discard this patch.
src/POData/Common/Messages/segmentParser.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@  discard block
 block discarded – undo
15 15
     public static function segmentParserKeysMustBeNamed($segment)
16 16
     {
17 17
         return 'Segments with multiple key values must specify them in \'name=value\' form. For the segment'
18
-               . $segment.' use named keys';
18
+               . $segment . ' use named keys';
19 19
     }
20 20
 
21 21
     /**
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
      */
30 30
     public static function segmentParserMustBeLeafSegment($leafSegment)
31 31
     {
32
-        return 'The request URI is not valid. The segment \''.$leafSegment.'\' must be the last segment in'
32
+        return 'The request URI is not valid. The segment \'' . $leafSegment . '\' must be the last segment in'
33 33
                .' the URI because it is one of the following: $batch, $value, $metadata, $count, a bag property,'
34 34
                .' a named media resource, or a service operation that does not return a value.';
35 35
     }
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
      */
44 44
     public static function segmentParserNoSegmentAllowedAfterPostLinkSegment($postPostLinkSegment)
45 45
     {
46
-        return 'The request URI is not valid. The segment \''.$postPostLinkSegment.'\' is not valid. Since the'
46
+        return 'The request URI is not valid. The segment \'' . $postPostLinkSegment . '\' is not valid. Since the'
47 47
                .' uri contains the $links segment, there must be only one segment specified after that.';
48 48
     }
49 49
 
@@ -59,8 +59,8 @@  discard block
 block discarded – undo
59 59
      */
60 60
     public static function segmentParserOnlyValueSegmentAllowedAfterPrimitivePropertySegment($segment, $primitivePropertySegment)
61 61
     {
62
-        return 'The segment \''.$segment.'\' in the request URI is not valid. Since the segment \''
63
-               .$primitivePropertySegment.'\' refers to a primitive type property, the only supported value from'
62
+        return 'The segment \'' . $segment . '\' in the request URI is not valid. Since the segment \''
63
+               .$primitivePropertySegment . '\' refers to a primitive type property, the only supported value from'
64 64
                .' the next segment is \'$value\'.';
65 65
     }
66 66
 
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
      */
74 74
     public static function segmentParserCannotQueryCollection($collectionSegment)
75 75
     {
76
-        return 'The request URI is not valid. Since the segment \''.$collectionSegment.'\' refers to a'
76
+        return 'The request URI is not valid. Since the segment \'' . $collectionSegment . '\' refers to a'
77 77
                .' collection, this must be the last segment in the request URI. All intermediate segments must'
78 78
                .' refer to a single resource.';
79 79
     }
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
      */
88 88
     public static function segmentParserCountCannotFollowSingleton($segment)
89 89
     {
90
-        return 'The request URI is not valid, since the segment \''.$segment.'\' refers to a singleton,'
90
+        return 'The request URI is not valid, since the segment \'' . $segment . '\' refers to a singleton,'
91 91
                .' and the segment \'$count\' can only follow a resource collection.';
92 92
     }
93 93
 
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
      */
102 102
     public static function segmentParserLinkSegmentMustBeFollowedByEntitySegment($segment)
103 103
     {
104
-        return 'The request URI is not valid. The segment \''.$segment.'\' must refer to a navigation property'
104
+        return 'The request URI is not valid. The segment \'' . $segment . '\' must refer to a navigation property'
105 105
                .' since the previous segment identifier is \'$links\'.';
106 106
     }
107 107
 
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
      */
127 127
     public static function segmentParserSegmentNotAllowedOnRoot($segment)
128 128
     {
129
-        return 'The request URI is not valid, the segment \''.$segment.'\' cannot be applied to the root of the'
129
+        return 'The request URI is not valid, the segment \'' . $segment . '\' cannot be applied to the root of the'
130 130
                .' service';
131 131
     }
132 132
 
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
      */
151 151
     public static function segmentParserUnExpectedPropertyKind($expectedKind)
152 152
     {
153
-        return 'Parsing of segments failed expecting '.$expectedKind.', contact provider';
153
+        return 'Parsing of segments failed expecting ' . $expectedKind . ', contact provider';
154 154
     }
155 155
 
156 156
     /**
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
      */
163 163
     public static function segmentParserCountCannotBeApplied($segment)
164 164
     {
165
-        return 'The request URI is not valid, $count cannot be applied to the segment \''.$segment.'\' since '
165
+        return 'The request URI is not valid, $count cannot be applied to the segment \'' . $segment . '\' since '
166 166
                .'$count can only follow a resource segment.';
167 167
     }
168 168
 }
Please login to merge, or discard this patch.
src/POData/Common/Messages/metadataWriter.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -27,8 +27,8 @@
 block discarded – undo
27 27
      */
28 28
     public static function metadataWriterNoResourceAssociationSetForNavigationProperty($navigationPropertyName, $resourceTypeName)
29 29
     {
30
-        return 'No visible ResourceAssociationSet found for navigation property \''.$navigationPropertyName.
31
-               '\' on type \''.$resourceTypeName.'\'. There must be at least one ResourceAssociationSet for'.
30
+        return 'No visible ResourceAssociationSet found for navigation property \'' . $navigationPropertyName .
31
+               '\' on type \'' . $resourceTypeName . '\'. There must be at least one ResourceAssociationSet for' .
32 32
                ' each navigation property.';
33 33
     }
34 34
 }
Please login to merge, or discard this patch.
src/POData/Common/Messages/expressionParser.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@  discard block
 block discarded – undo
15 15
      */
16 16
     public static function expressionParserInCompatibleTypes($operator, $str, $pos)
17 17
     {
18
-        return 'Operator \''.$operator.'\' incompatible with operand types '.$str.' at position '.$pos;
18
+        return 'Operator \'' . $operator . '\' incompatible with operand types ' . $str . ' at position ' . $pos;
19 19
     }
20 20
 
21 21
     /**
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
      */
29 29
     public static function expressionParserOperatorNotSupportNull($operator, $pos)
30 30
     {
31
-        return 'The operator \''.$operator.'\' at position '.$pos.' is not supported for the \'null\''
31
+        return 'The operator \'' . $operator . '\' at position ' . $pos . ' is not supported for the \'null\''
32 32
                .' literal; only equality checks are supported';
33 33
     }
34 34
 
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
      */
43 43
     public static function expressionParserOperatorNotSupportGuid($operator, $pos)
44 44
     {
45
-        return 'The operator \''.$operator.'\' at position '.$pos.' is not supported for the Edm.Guid;'
45
+        return 'The operator \'' . $operator . '\' at position ' . $pos . ' is not supported for the Edm.Guid;'
46 46
                .' only equality checks are supported';
47 47
     }
48 48
 
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
      */
57 57
     public static function expressionParserOperatorNotSupportBinary($operator, $pos)
58 58
     {
59
-        return 'The operator \''.$operator.'\' at position '.$pos.' is not supported for the Edm.Binary;'
59
+        return 'The operator \'' . $operator . '\' at position ' . $pos . ' is not supported for the Edm.Binary;'
60 60
                .' only equality checks are supported';
61 61
     }
62 62
 
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
      */
72 72
     public static function expressionParserUnrecognizedLiteral($type, $literal, $pos)
73 73
     {
74
-        return 'Unrecognized \''.$type.'\' literal \''.$literal.'\' in position \''.$pos.'\'.';
74
+        return 'Unrecognized \'' . $type . '\' literal \'' . $literal . '\' in position \'' . $pos . '\'.';
75 75
     }
76 76
 
77 77
     /**
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
      */
85 85
     public static function expressionParserUnknownFunction($str, $pos)
86 86
     {
87
-        return 'Unknown function \''.$str.'\' at position '.$pos;
87
+        return 'Unknown function \'' . $str . '\' at position ' . $pos;
88 88
     }
89 89
 
90 90
     /**
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
      */
107 107
     public static function expressionParser2UnexpectedExpression($expressionClassName)
108 108
     {
109
-        return 'Unexpected expression of type \''.$expressionClassName.'\' found';
109
+        return 'Unexpected expression of type \'' . $expressionClassName . '\' found';
110 110
     }
111 111
 
112 112
     /**
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
      */
132 132
     public static function expressionParserEntityCollectionNotAllowedInFilter($property, $parentProperty, $pos)
133 133
     {
134
-        return 'The \''.$property.'\' is an entity collection property of \''.$parentProperty.'\' (position: '.$pos
134
+        return 'The \'' . $property . '\' is an entity collection property of \'' . $parentProperty . '\' (position: ' . $pos
135 135
                .'), which cannot be used in $filter query option';
136 136
     }
137 137
 }
Please login to merge, or discard this patch.
src/POData/Common/Messages/resourceAssociationSet.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
      */
15 15
     public static function resourceAssociationSetPropertyMustBeNullOrInstanceofResourceProperty($argumentName)
16 16
     {
17
-        return 'The argument \''.$argumentName.'\' must be either null or instance of \'ResourceProperty\'.';
17
+        return 'The argument \'' . $argumentName . '\' must be either null or instance of \'ResourceProperty\'.';
18 18
     }
19 19
 
20 20
     /**
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
      */
29 29
     public static function resourceAssociationSetEndPropertyMustBeNavigationProperty($propertyName, $resourceTypeName)
30 30
     {
31
-        return 'The property '.$propertyName.' must be a navigation property of the resource type '.$resourceTypeName;
31
+        return 'The property ' . $propertyName . ' must be a navigation property of the resource type ' . $resourceTypeName;
32 32
     }
33 33
 
34 34
     /**
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
      */
43 43
     public static function resourceAssociationSetEndResourceTypeMustBeAssignableToResourceSet($resourceTypeName, $resourceSetName)
44 44
     {
45
-        return 'The resource type '.$resourceTypeName.' must be assignable to the resource set '.$resourceSetName.'.';
45
+        return 'The resource type ' . $resourceTypeName . ' must be assignable to the resource set ' . $resourceSetName . '.';
46 46
     }
47 47
 
48 48
     /**
Please login to merge, or discard this patch.
src/POData/Common/Messages/request.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -16,8 +16,8 @@  discard block
 block discarded – undo
16 16
      */
17 17
     public static function requestVersionTooLow($requestedVersion, $requiredVersion)
18 18
     {
19
-        return 'Request version \''.$requestedVersion.'\' is not supported for the request payload. The only'
20
-               .' supported version is \''.$requiredVersion.'\'.';
19
+        return 'Request version \'' . $requestedVersion . '\' is not supported for the request payload. The only'
20
+               .' supported version is \'' . $requiredVersion . '\'.';
21 21
     }
22 22
 
23 23
     /**
@@ -31,8 +31,8 @@  discard block
 block discarded – undo
31 31
      */
32 32
     public static function requestVersionIsBiggerThanProtocolVersion($requiredVersion, $configuredVersion)
33 33
     {
34
-        return 'The response requires that version '.$requiredVersion.' of the protocol be used, but the'
35
-               .' MaxProtocolVersion of the data service is set to '.$configuredVersion.'.';
34
+        return 'The response requires that version ' . $requiredVersion . ' of the protocol be used, but the'
35
+               .' MaxProtocolVersion of the data service is set to ' . $configuredVersion . '.';
36 36
     }
37 37
 
38 38
     /**
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
      */
47 47
     public static function requestDescriptionInvalidVersionHeader($versionAsString, $headerName)
48 48
     {
49
-        return 'The header '.$headerName.' has malformed version value '.$versionAsString;
49
+        return 'The header ' . $headerName . ' has malformed version value ' . $versionAsString;
50 50
     }
51 51
 
52 52
     /**
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
      */
62 62
     public static function requestDescriptionUnSupportedVersion($requestHeaderName, $requestedVersion, $availableVersions)
63 63
     {
64
-        return 'The version value '.$requestedVersion.' in the header '.$requestHeaderName.' is not'
65
-               .' supported, available versions are '.$availableVersions;
64
+        return 'The version value ' . $requestedVersion . ' in the header ' . $requestHeaderName . ' is not'
65
+               .' supported, available versions are ' . $availableVersions;
66 66
     }
67 67
 }
Please login to merge, or discard this patch.