Passed
Pull Request — master (#130)
by Alex
04:29
created
src/POData/UriProcessor/RequestDescription.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -666,7 +666,7 @@  discard block
 block discarded – undo
666 666
      *
667 667
      * @param InternalOrderByInfo &$internalOrderByInfo The sorting information
668 668
      */
669
-    public function setInternalOrderByInfo(InternalOrderByInfo &$internalOrderByInfo)
669
+    public function setInternalOrderByInfo(InternalOrderByInfo & $internalOrderByInfo)
670 670
     {
671 671
         $this->internalOrderByInfo = $internalOrderByInfo;
672 672
     }
@@ -687,7 +687,7 @@  discard block
 block discarded – undo
687 687
      * @param InternalSkipTokenInfo &$internalSkipTokenInfo The paging information
688 688
      */
689 689
     public function setInternalSkipTokenInfo(
690
-        InternalSkipTokenInfo &$internalSkipTokenInfo
690
+        InternalSkipTokenInfo & $internalSkipTokenInfo
691 691
     ) {
692 692
         $this->internalSkipTokenInfo = $internalSkipTokenInfo;
693 693
     }
@@ -713,7 +713,7 @@  discard block
 block discarded – undo
713 713
      *
714 714
      * @param RootProjectionNode &$rootProjectionNode Root of the projection tree
715 715
      */
716
-    public function setRootProjectionNode(RootProjectionNode &$rootProjectionNode)
716
+    public function setRootProjectionNode(RootProjectionNode & $rootProjectionNode)
717 717
     {
718 718
         $this->rootProjectionNode = $rootProjectionNode;
719 719
     }
Please login to merge, or discard this patch.
src/POData/BaseService.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -682,7 +682,7 @@  discard block
 block discarded – undo
682 682
      */
683 683
     protected function compareETag(
684 684
         &$entryObject,
685
-        ResourceType &$resourceType,
685
+        ResourceType & $resourceType,
686 686
         &$needToSerializeResponse
687 687
     ) {
688 688
         $needToSerializeResponse = true;
@@ -775,7 +775,7 @@  discard block
 block discarded – undo
775 775
      *                     for use in a URI) there are etag properties, NULL if
776 776
      *                     there is no etag property
777 777
      */
778
-    protected function getETagForEntry(&$entryObject, ResourceType &$resourceType)
778
+    protected function getETagForEntry(&$entryObject, ResourceType & $resourceType)
779 779
     {
780 780
         $eTag = null;
781 781
         $comma = null;
Please login to merge, or discard this patch.
src/POData/OperationContext/ServiceHost.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
                     );
224 224
                 }
225 225
 
226
-                $serviceUri = $requestUriScheme .'://' . $this->getAbsoluteRequestUri()->getHost();
226
+                $serviceUri = $requestUriScheme . '://' . $this->getAbsoluteRequestUri()->getHost();
227 227
 
228 228
                 if (($requestUriScheme == 'http' && $requestUriPort != '80') ||
229 229
                     ($requestUriScheme == 'https' && $requestUriPort != '443')
@@ -513,7 +513,7 @@  discard block
 block discarded – undo
513 513
             $this->getOperationContext()->outgoingResponse()->setContentLength($value);
514 514
         } else {
515 515
             throw ODataException::notAcceptableError(
516
-                'ContentLength: '.$value.' is invalid'
516
+                'ContentLength: ' . $value . ' is invalid'
517 517
             );
518 518
         }
519 519
     }
@@ -556,7 +556,7 @@  discard block
 block discarded – undo
556 556
     public function setResponseStatusCode($value)
557 557
     {
558 558
         if (!is_numeric($value)) {
559
-            $msg = 'Invalid, non-numeric, status code: '.$value;
559
+            $msg = 'Invalid, non-numeric, status code: ' . $value;
560 560
             throw ODataException::createInternalServerError($msg);
561 561
         }
562 562
         $floor = floor($value/100);
Please login to merge, or discard this patch.
UriProcessor/QueryProcessor/SkipTokenParser/InternalSkipTokenInfo.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -68,9 +68,9 @@
 block discarded – undo
68 68
      * @param ResourceType        &$resourceType            Reference to the resource type pointed to by the request uri
69 69
      */
70 70
     public function __construct(
71
-        InternalOrderByInfo &$internalOrderByInfo,
71
+        InternalOrderByInfo & $internalOrderByInfo,
72 72
         $orderByValuesInSkipToken,
73
-        ResourceType &$resourceType
73
+        ResourceType & $resourceType
74 74
     ) {
75 75
         $this->internalOrderByInfo = $internalOrderByInfo;
76 76
         $this->orderByValuesInSkipToken = $orderByValuesInSkipToken;
Please login to merge, or discard this patch.
src/POData/Common/Messages/resourceProperty.php 2 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
     public static function resourcePropertyInvalidKindParameter($argumentName)
15 15
     {
16 16
         return 'The argument \''.$argumentName.'\' is not a valid ResourcePropertyKind enum value or'
17
-               .' valid combination of ResourcePropertyKind enum values';
17
+                .' valid combination of ResourcePropertyKind enum values';
18 18
     }
19 19
 
20 20
     /**
@@ -30,6 +30,6 @@  discard block
 block discarded – undo
30 30
         $resourceTypeArgName
31 31
     ) {
32 32
         return 'The \''.$resourcePropertyKindArgName.'\' parameter does not match with the type of the resource'
33
-               .' type in parameter \''.$resourceTypeArgName.'\'';
33
+                .' type in parameter \''.$resourceTypeArgName.'\'';
34 34
     }
35 35
 }
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@  discard block
 block discarded – undo
13 13
      */
14 14
     public static function resourcePropertyInvalidKindParameter($argumentName)
15 15
     {
16
-        return 'The argument \''.$argumentName.'\' is not a valid ResourcePropertyKind enum value or'
16
+        return 'The argument \'' . $argumentName . '\' is not a valid ResourcePropertyKind enum value or'
17 17
                .' valid combination of ResourcePropertyKind enum values';
18 18
     }
19 19
 
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
         $resourcePropertyKindArgName,
30 30
         $resourceTypeArgName
31 31
     ) {
32
-        return 'The \''.$resourcePropertyKindArgName.'\' parameter does not match with the type of the resource'
33
-               .' type in parameter \''.$resourceTypeArgName.'\'';
32
+        return 'The \'' . $resourcePropertyKindArgName . '\' parameter does not match with the type of the resource'
33
+               .' type in parameter \'' . $resourceTypeArgName . '\'';
34 34
     }
35 35
 }
Please login to merge, or discard this patch.
src/POData/Common/Messages/skipTokenParser.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@
 block discarded – undo
44 44
         $expectedCount
45 45
     ) {
46 46
         return 'The number of keys \'' . $skipTokenValuesCount . '\' in skip token with value \'' . $skipToken .
47
-               '\' did not match the number of ordering constraints \'' . $expectedCount . '\' for the resource type.';
47
+                '\' did not match the number of ordering constraints \'' . $expectedCount . '\' for the resource type.';
48 48
     }
49 49
 
50 50
     /**
Please login to merge, or discard this patch.
src/POData/Common/Messages/request.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@  discard block
 block discarded – undo
17 17
     public static function requestVersionTooLow($requestedVersion, $requiredVersion)
18 18
     {
19 19
         return 'Request version \''.$requestedVersion.'\' is not supported for the request payload. The only'
20
-               .' supported version is \''.$requiredVersion.'\'.';
20
+                .' supported version is \''.$requiredVersion.'\'.';
21 21
     }
22 22
 
23 23
     /**
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
     public static function requestVersionIsBiggerThanProtocolVersion($requiredVersion, $configuredVersion)
33 33
     {
34 34
         return 'The response requires that version '.$requiredVersion.' of the protocol be used, but the'
35
-               .' MaxProtocolVersion of the data service is set to '.$configuredVersion.'.';
35
+                .' MaxProtocolVersion of the data service is set to '.$configuredVersion.'.';
36 36
     }
37 37
 
38 38
     /**
@@ -65,6 +65,6 @@  discard block
 block discarded – undo
65 65
         $availableVersions
66 66
     ) {
67 67
         return 'The version value '.$requestedVersion.' in the header '.$requestHeaderName.' is not'
68
-               .' supported, available versions are '.$availableVersions;
68
+                .' supported, available versions are '.$availableVersions;
69 69
     }
70 70
 }
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -16,8 +16,8 @@  discard block
 block discarded – undo
16 16
      */
17 17
     public static function requestVersionTooLow($requestedVersion, $requiredVersion)
18 18
     {
19
-        return 'Request version \''.$requestedVersion.'\' is not supported for the request payload. The only'
20
-               .' supported version is \''.$requiredVersion.'\'.';
19
+        return 'Request version \'' . $requestedVersion . '\' is not supported for the request payload. The only'
20
+               .' supported version is \'' . $requiredVersion . '\'.';
21 21
     }
22 22
 
23 23
     /**
@@ -31,8 +31,8 @@  discard block
 block discarded – undo
31 31
      */
32 32
     public static function requestVersionIsBiggerThanProtocolVersion($requiredVersion, $configuredVersion)
33 33
     {
34
-        return 'The response requires that version '.$requiredVersion.' of the protocol be used, but the'
35
-               .' MaxProtocolVersion of the data service is set to '.$configuredVersion.'.';
34
+        return 'The response requires that version ' . $requiredVersion . ' of the protocol be used, but the'
35
+               .' MaxProtocolVersion of the data service is set to ' . $configuredVersion . '.';
36 36
     }
37 37
 
38 38
     /**
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
      */
47 47
     public static function requestDescriptionInvalidVersionHeader($versionAsString, $headerName)
48 48
     {
49
-        return 'The header '.$headerName.' has malformed version value '.$versionAsString;
49
+        return 'The header ' . $headerName . ' has malformed version value ' . $versionAsString;
50 50
     }
51 51
 
52 52
     /**
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
         $requestedVersion,
65 65
         $availableVersions
66 66
     ) {
67
-        return 'The version value '.$requestedVersion.' in the header '.$requestHeaderName.' is not'
68
-               .' supported, available versions are '.$availableVersions;
67
+        return 'The version value ' . $requestedVersion . ' in the header ' . $requestHeaderName . ' is not'
68
+               .' supported, available versions are ' . $availableVersions;
69 69
     }
70 70
 }
Please login to merge, or discard this patch.
src/POData/Common/Messages/orderByInfo.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
     public static function orderByParserPropertyNotFound($resourceTypeName, $propertyName)
51 51
     {
52 52
         return 'Error in the \'orderby\' clause. Type ' . $resourceTypeName
53
-               . ' does not have a property named \'' . $propertyName . '\'.';
53
+                . ' does not have a property named \'' . $propertyName . '\'.';
54 54
     }
55 55
 
56 56
     /**
@@ -179,6 +179,6 @@  discard block
 block discarded – undo
179 179
     public static function orderByParserFailedToAccessOrInitializeProperty($propertyName, $parentObjectName)
180 180
     {
181 181
         return 'OrderBy parser failed to access or initialize the property ' . $propertyName .
182
-               ' of ' . $parentObjectName;
182
+                ' of ' . $parentObjectName;
183 183
     }
184 184
 }
Please login to merge, or discard this patch.
src/POData/UriProcessor/SegmentStack.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@
 block discarded – undo
50 50
      * @throws InvalidOperationException
51 51
      * @return bool true if the segment was push, false otherwise
52 52
      */
53
-    public function pushSegment($segmentName, ResourceSetWrapper &$resourceSetWrapper)
53
+    public function pushSegment($segmentName, ResourceSetWrapper & $resourceSetWrapper)
54 54
     {
55 55
         if (!is_string($segmentName)) {
56 56
             throw new InvalidOperationException('segmentName must be a string');
Please login to merge, or discard this patch.