Algo-Web /
POData-Laravel
| Conditions | 10 |
| Paths | 24 |
| Total Lines | 35 |
| Code Lines | 23 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 26 | public function bulkSerialise($model) |
||
| 27 | { |
||
| 28 | $class = get_class($model); |
||
| 29 | assert($model instanceof Model, $class); |
||
| 30 | // dig up metadata |
||
| 31 | if (!isset(self::$metadataCache[$class])) { |
||
| 32 | self::$metadataCache[$class] = $model->metadata(); |
||
| 33 | } |
||
| 34 | $meta = self::$metadataCache[$class]; |
||
| 35 | $keys = array_keys($meta); |
||
| 36 | // dig up getter list - we only care about the mutators that end up in metadata |
||
| 37 | if (!isset(self::$mutatorCache[$class])) { |
||
| 38 | $getterz = []; |
||
| 39 | $datez = $model->getDates(); |
||
| 40 | $castz = $model->retrieveCasts(); |
||
| 41 | foreach ($keys as $key) { |
||
| 42 | if ($model->hasGetMutator($key) || in_array($key, $datez) || array_key_exists($key, $castz)) { |
||
| 43 | $getterz[] = $key; |
||
| 44 | } |
||
| 45 | } |
||
| 46 | self::$mutatorCache[$class] = $getterz; |
||
| 47 | } |
||
| 48 | $getterz = self::$mutatorCache[$class]; |
||
| 49 | $result = array_intersect_key($model->getAttributes(), $meta); |
||
| 50 | foreach ($keys as $key) { |
||
| 51 | if (!isset($result[$key])) { |
||
| 52 | $result[$key] = null; |
||
| 53 | } |
||
| 54 | } |
||
| 55 | foreach ($getterz as $getter) { |
||
| 56 | $result[$getter] = $model->$getter; |
||
| 57 | } |
||
| 58 | |||
| 59 | return $result; |
||
| 60 | } |
||
| 61 | |||
| 68 |
