MetadataRouteProvider::setupRoute() - Code Metrics - Inspection of "Hook up stateless auth" - Algo-Web/POData-Laravel - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Pull Request — master (#50)

by Alex

created 2017-05-29 16:15 UTC

MetadataRouteProvider::setupRoute() A

↳ Parent: MetadataRouteProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines	14
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	14
rs	9.4285
cc	1
eloc	9
nc	1
nop	0

<?php

namespace AlgoWeb\PODataLaravel\Providers;

use Illuminate\Support\Facades\Route;
use Illuminate\Support\ServiceProvider;

class MetadataRouteProvider extends ServiceProvider
{
    /**
     * Bootstrap the application services.
     *
     * @return void
     */
    public function boot()
    {
        self::setupRoute();
    }

    private static function setupRoute()
    {
        $valueArray = [];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        Route::any(
            'odata.svc/{section}',
            [ 'uses' => 'AlgoWeb\PODataLaravel\Controllers\ODataController@index', 'middleware' => 'auth.basic']
        )
            ->where(['section' => '.*']);
        Route::any(
            'odata.svc',
            [ 'uses' => 'AlgoWeb\PODataLaravel\Controllers\ODataController@index', 'middleware' => 'auth.basic']
        );
    }

    /**
     * Register the application services.
     *
     * @return void
     */
    public function register()
    {
        //
    }
}


1			<?php
2
3			namespace AlgoWeb\PODataLaravel\Providers;
4
5			use Illuminate\Support\Facades\Route;
6			use Illuminate\Support\ServiceProvider;
7
8			class MetadataRouteProvider extends ServiceProvider
9			{
10			/**
11			* Bootstrap the application services.
12			*
13			* @return void
14			*/
15			public function boot()
16			{
17			self::setupRoute();
18			}
19
20			private static function setupRoute()
21			{
22			$valueArray = [];
			0 ignored issues – show Unused Code introduced 2017-05-29 16:18 UTC by Report Bug Copy Issue Report `$valueArray` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
23
24			Route::any(
25			'odata.svc/{section}',
26			[ 'uses' => 'AlgoWeb\PODataLaravel\Controllers\ODataController@index', 'middleware' => 'auth.basic']
27			)
28			->where(['section' => '.*']);
29			Route::any(
30			'odata.svc',
31			[ 'uses' => 'AlgoWeb\PODataLaravel\Controllers\ODataController@index', 'middleware' => 'auth.basic']
32			);
33			}
34
35			/**
36			* Register the application services.
37			*
38			* @return void
39			*/
40			public function register()
41			{
42			//
43			}
44			}
45

Algo-Web / POData-Laravel

Pull Request — master (#50)

MetadataRouteProvider::setupRoute() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like