MetadataRouteProvider::getAuthMiddleware() - Code Metrics - Inspection of "Hook up auth-bypass switch" - Algo-Web/POData-Laravel - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#87)

by Alex

created 2017-08-08 15:18 UTC

MetadataRouteProvider::getAuthMiddleware() A

↳ Parent: MetadataRouteProvider

Complexity

Conditions	4
Paths	4

Size

Total Lines	16
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
c	3
b	0
f	0
dl	0
loc	16
rs	9.2
cc	4
eloc	9
nc	4
nop	0

<?php

namespace AlgoWeb\PODataLaravel\Providers;

use Illuminate\Support\Facades\App;
use Illuminate\Support\Facades\Route;
use Illuminate\Support\ServiceProvider;

class MetadataRouteProvider extends ServiceProvider
{
    /**
     * Bootstrap the application services.
     *
     * @return void
     */
    public function boot()
    {
        $this->setupRoute();
    }

    private function setupRoute()
    {
        $authMiddleware = $this->getAuthMiddleware();
        $controllerMethod = 'AlgoWeb\PODataLaravel\Controllers\ODataController@index';

        Route::get('odata.svc/$metadata', ['uses' => $controllerMethod, 'middleware' => null]);

        Route::any('odata.svc/{section}', ['uses' => $controllerMethod, 'middleware' => $authMiddleware])
            ->where(['section' => '.*']);
        Route::any('odata.svc', ['uses' => $controllerMethod, 'middleware' => null]);
    }

    /**
     * Register the application services.
     *
     * @return void
     */
    public function register()
    {
    }

    private function getAuthMiddleware()
    {
        $disable = $this->getAuthDisable();
        if ($disable) {
            return null;
        }

        $authMiddleware = 'auth.basic';

        if (interface_exists(\Illuminate\Contracts\Auth\Factory::class)) {
            $manager = App::make(\Illuminate\Contracts\Auth\Factory::class);
            $authMiddleware = $manager->guard('api') ? 'auth:api' : $authMiddleware;
        }

        return $authMiddleware;
    }

    /**
     * @return bool
     */
    protected function getAuthDisable()

    {
        return true === config('APP_DISABLE_AUTH', null);
    }
}


1			<?php
2
3			namespace AlgoWeb\PODataLaravel\Providers;
4
5			use Illuminate\Support\Facades\App;
6			use Illuminate\Support\Facades\Route;
7			use Illuminate\Support\ServiceProvider;
8
9			class MetadataRouteProvider extends ServiceProvider
10			{
11			/**
12			* Bootstrap the application services.
13			*
14			* @return void
15			*/
16			public function boot()
17			{
18			$this->setupRoute();
19			}
20
21			private function setupRoute()
22			{
23			$authMiddleware = $this->getAuthMiddleware();
24			$controllerMethod = 'AlgoWeb\PODataLaravel\Controllers\ODataController@index';
25
26			Route::get('odata.svc/$metadata', ['uses' => $controllerMethod, 'middleware' => null]);
27
28			Route::any('odata.svc/{section}', ['uses' => $controllerMethod, 'middleware' => $authMiddleware])
29			->where(['section' => '.*']);
30			Route::any('odata.svc', ['uses' => $controllerMethod, 'middleware' => null]);
31			}
32
33			/**
34			* Register the application services.
35			*
36			* @return void
37			*/
38			public function register()
39			{
40			}
41
42			private function getAuthMiddleware()
43			{
44			$disable = $this->getAuthDisable();
45			if ($disable) {
46			return null;
47			}
48
49			$authMiddleware = 'auth.basic';
50
51			if (interface_exists(\Illuminate\Contracts\Auth\Factory::class)) {
52			$manager = App::make(\Illuminate\Contracts\Auth\Factory::class);
53			$authMiddleware = $manager->guard('api') ? 'auth:api' : $authMiddleware;
54			}
55
56			return $authMiddleware;
57			}
58
59			/**
60			* @return bool
61			*/
62			protected function getAuthDisable()
			0 ignored issues – show Coding Style introduced 2017-08-08 15:21 UTC by Report Bug Copy Issue Report `function getAuthDisable()` does not seem to conform to the naming convention (`^(?:is\|has\|should\|may\|supports)`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
63			{
64			return true === config('APP_DISABLE_AUTH', null);
65			}
66			}
67

Algo-Web / POData-Laravel

Pull Request — master (#87)

MetadataRouteProvider::getAuthMiddleware() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like