AlgoWeb\PODataLaravel\Models\Association::isOk()

Complexity

Conditions	7
Paths	5

Size

Total Lines	18
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function isOk()
    {
        $first = $this->getFirst();
        $last = $this->getLast();
        if (null === $first || !$first->isOk()) {
            return false;
        }
        if (null === $last || !$last->isOk()) {
            return false;
        }
        if (!$first->isCompatible($last)) {
            return false;
        }
        if (-1 !== $first->compare($last)) {

This if statement, and the following return statement can be replaced with return !(-1 !== $first->compare($last));.

            return false;
        }
        return true;
    }
}