ODataController::isDumping() - Code Metrics - Inspection of "Add dry run parameter (#103)" - Algo-Web/POData-Laravel - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( a0b87a...51cb17 )

by Alex

created 2017-08-29 05:27 UTC

ODataController::isDumping() A

↳ Parent: ODataController

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	3
nc	1
nop	0
dl	0
loc	5
ccs	0
cts	0
cp	0
crap	2
rs	9.4285
c	0
b	0
f	0

<?php

namespace AlgoWeb\PODataLaravel\Controllers;

use AlgoWeb\PODataLaravel\Serialisers\IronicSerialiser;
use Carbon\Carbon;
use Illuminate\Http\Request;
use Illuminate\Http\Response;
use AlgoWeb\PODataLaravel\Controllers\Controller as BaseController;
use Illuminate\Support\Facades\App;
use Illuminate\Support\Facades\DB;
use Illuminate\Support\Facades\Storage;
use POData\OperationContext\ServiceHost as ServiceHost;
use POData\SimpleDataService as DataService;
use POData\OperationContext\Web\Illuminate\IlluminateOperationContext as OperationContextAdapter;
use voku\helper\AntiXSS;

class ODataController extends BaseController
{
    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)
    {
        $dump = $this->isDumping();
        $dryRun = $this->isDryRun();
        $commitCall = $dryRun ? 'rollBack' : 'commit';

        try {
            DB::beginTransaction();
            $context = new OperationContextAdapter($request);
            $host = new ServiceHost($context, $request);
            $host->setServiceUri('/odata.svc/');

            $query = App::make('odataquery');
            $meta = App::make('metadata');

            $service = new DataService($query, $meta, $host);
            $cereal = new IronicSerialiser($service, null);
            $service = new DataService($query, $meta, $host, $cereal);
            $service->handleRequest();

            $odataResponse = $context->outgoingResponse();

            if (true === $dump) {
                // iff XTest header is set, containing class and method name
                // dump outgoing odataResponse, metadata, and incoming request
                $xTest = $request->header('XTest');
                $date = Carbon::now(0);
                $timeString = $date->toTimeString();
                $xTest = (null !== $xTest) ? $xTest
                    : $request->method() . ';' . str_replace('/', '-', $request->path()) . ';' . $timeString . ';';
                if (null != $xTest) {
                    $reflectionClass = new \ReflectionClass('Illuminate\Http\Request');
                    $reflectionProperty = $reflectionClass->getProperty('userResolver');
                    $reflectionProperty->setAccessible(true);
                    $reflectionProperty->setValue($request, null);
                    $reflectionProperty = $reflectionClass->getProperty('routeResolver');
                    $reflectionProperty->setAccessible(true);
                    $reflectionProperty->setValue($request, null);
                    $cerealRequest = serialize($request);
                    $cerealMeta = serialize($meta);
                    $cerealResponse = serialize($odataResponse);
                    Storage::put($xTest . 'request', $cerealRequest);
                    Storage::put($xTest . 'metadata', $cerealMeta);
                    Storage::put($xTest . 'response', $cerealResponse);
                }
            }

            $content = $odataResponse->getStream();

            $headers = $odataResponse->getHeaders();
            $responseCode = $headers[\POData\Common\ODataConstants::HTTPRESPONSE_HEADER_STATUS_CODE];
            $responseCode = isset($responseCode) ? intval($responseCode) : 200;
            $response = new Response($content, $responseCode);
// for HTML
$sanitized = htmlentities($tainted, ENT_QUOTES);

// for URLs
$sanitized = urlencode($tainted);
            $response->setStatusCode($headers['Status']);

            foreach ($headers as $headerName => $headerValue) {
                if (!is_null($headerValue)) {
                    $response->headers->set($headerName, $headerValue);
                }
            }
            DB::$commitCall();
        } catch (\Exception $e) {
            DB::rollBack();
            throw $e;
        }
        return $response;
    }

    /**
     * @return bool
     */
    protected function isDumping()
    {
        $configDump = env('APP_DUMP_REQUESTS', false);
        return true === $configDump;
    }

    /**
     * Is application dry-running (ie, not committing) non-READ requests?
     *
     * @return bool
     */
    protected function isDryRun()
    {
        $configDump = env('APP_DRY_RUN', false);
        return true === $configDump;
    }
}


Push — master ( a0b87a...51cb17 )

ODataController::isDumping() A

Complexity

Size

Duplication

Code Coverage

Importance

9 paths for user data to reach this point

Used in output context

Preventing Cross-Site-Scripting Attacks

General Strategies to prevent injection

1			<?php
2
3			namespace AlgoWeb\PODataLaravel\Controllers;
4
5			use AlgoWeb\PODataLaravel\Serialisers\IronicSerialiser;
6			use Carbon\Carbon;
7			use Illuminate\Http\Request;
8			use Illuminate\Http\Response;
9			use AlgoWeb\PODataLaravel\Controllers\Controller as BaseController;
10			use Illuminate\Support\Facades\App;
11			use Illuminate\Support\Facades\DB;
12			use Illuminate\Support\Facades\Storage;
13			use POData\OperationContext\ServiceHost as ServiceHost;
14			use POData\SimpleDataService as DataService;
15			use POData\OperationContext\Web\Illuminate\IlluminateOperationContext as OperationContextAdapter;
16			use voku\helper\AntiXSS;
17
18			class ODataController extends BaseController
19			{
20			/**
21			* Display a listing of the resource.
22			*
23			* @return \Illuminate\Http\Response
24			*/
25			public function index(Request $request)
26			{
27			$dump = $this->isDumping();
28			$dryRun = $this->isDryRun();
29			$commitCall = $dryRun ? 'rollBack' : 'commit';
30
31			try {
32			DB::beginTransaction();
33			$context = new OperationContextAdapter($request);
34			$host = new ServiceHost($context, $request);
35			$host->setServiceUri('/odata.svc/');
36
37			$query = App::make('odataquery');
38			$meta = App::make('metadata');
39
40			$service = new DataService($query, $meta, $host);

Algo-Web / POData-Laravel

Push — master ( a0b87a...51cb17 )

ODataController::isDumping() A

Complexity

Size

Duplication

Code Coverage

Importance

9 paths for user data to reach this point

Used in output context

Preventing Cross-Site-Scripting Attacks

General Strategies to prevent injection

Duplication Side-by-Side

Filter issues like