AlgoWeb\PODataLaravel\Controllers\ODataController::index()

Complexity

Conditions	10
Paths	654

Size

Total Lines	70
Code Lines	52

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	110

Importance

Changes

0

<?php
    public function index(Request $request)
    {
        $dump = $this->isDumping();
        $dryRun = $this->isDryRun();
        $commitCall = $dryRun ? 'rollBack' : 'commit';

        try {
            DB::beginTransaction();
            $context = new OperationContextAdapter($request);
            $host = new ServiceHost($context, $request);
            $host->setServiceUri('/odata.svc/');

            $query = App::make('odataquery');
            $meta = App::make('metadata');

            $service = new DataService($query, $meta, $host);
            $cereal = new IronicSerialiser($service, null);
            $service = new DataService($query, $meta, $host, $cereal);
            $pageSize = $this->getAppPageSize();
            if (null !== $pageSize) {
                $service->maxPageSize = intval($pageSize);
            }
            $service->handleRequest();

            $odataResponse = $context->outgoingResponse();

            if (true === $dump) {
                // iff XTest header is set, containing class and method name
                // dump outgoing odataResponse, metadata, and incoming request
                $xTest = $request->header('XTest');
                $date = Carbon::now(0);
                $timeString = $date->toTimeString();
                $xTest = (null !== $xTest) ? $xTest
                    : $request->method() . ';' . str_replace('/', '-', $request->path()) . ';' . $timeString . ';';
                if (null != $xTest) {

It seems like you are loosely comparing $xTest of type mixed|string against null; this is ambiguous if the string can be empty. Consider using a strict comparison !== instead.

                    $reflectionClass = new \ReflectionClass('Illuminate\Http\Request');
                    $reflectionProperty = $reflectionClass->getProperty('userResolver');
                    $reflectionProperty->setAccessible(true);
                    $reflectionProperty->setValue($request, null);
                    $reflectionProperty = $reflectionClass->getProperty('routeResolver');
                    $reflectionProperty->setAccessible(true);
                    $reflectionProperty->setValue($request, null);
                    $cerealRequest = serialize($request);
                    $cerealMeta = serialize($meta);
                    $cerealResponse = serialize($odataResponse);
                    Storage::put($xTest . 'request', $cerealRequest);
                    Storage::put($xTest . 'metadata', $cerealMeta);
                    Storage::put($xTest . 'response', $cerealResponse);
                }
            }

            $content = $odataResponse->getStream();

            $headers = $odataResponse->getHeaders();
            $responseCode = $headers[\POData\Common\ODataConstants::HTTPRESPONSE_HEADER_STATUS_CODE];
            $responseCode = isset($responseCode) ? intval($responseCode) : 200;
            $response = new Response($content, $responseCode);
            $response->setStatusCode($headers['Status']);

$headers['Status'] of type string is incompatible with the type integer expected by parameter $code of Symfony\Component\HttpFoundation\Response::setStatusCode().

            foreach ($headers as $headerName => $headerValue) {
                if (null !== $headerValue) {
                    $response->headers->set($headerName, $headerValue);
                }
            }
            DB::$commitCall();
        } catch (\Exception $e) {
            DB::rollBack();
            throw $e;
        }
        return $response;
    }