Algo-Web / ODataMetadata

src/MetadataV3/edm/Groups/GExpressionTrait.php

Spacing +6 added lines, -6 removed lines

@@ -687,29 +687,29 @@ 
                 $counter += isset($this->$name) ? 1 : 0;
             }
             if (-1 < $this->gExpressionMinimum && $counter < $this->gExpressionMinimum) {
-                $msg = $counter . " fields not null.  Need minimum of ".$this->gExpressionMinimum. ": "
+                $msg = $counter." fields not null.  Need minimum of ".$this->gExpressionMinimum.": "
                         . get_class($this);
                 return false;
             }
             if (-1 < $this->gExpressionMaximum && $counter > $this->gExpressionMaximum) {
-                $msg = $counter . " fields not null.  Need maximum of ".$this->gExpressionMaximum. ": "
+                $msg = $counter." fields not null.  Need maximum of ".$this->gExpressionMaximum.": "
                         . get_class($this);
                 return false;
             }
         }
 
         if (null != $this->guid && !$this->isTGuidLiteralValid($this->guid)) {
-            $msg = "Guid must be a valid TGuidLiteral: " . get_class($this);
+            $msg = "Guid must be a valid TGuidLiteral: ".get_class($this);
             return false;
         }
 
         if (null != $this->enum && !$this->isTQualifiedNameValid($this->enum)) {
-            $msg = "Enum must be a valid TQualifiedName: " . get_class($this);
+            $msg = "Enum must be a valid TQualifiedName: ".get_class($this);
             return false;
         }
 
         if (null != $this->path && !$this->isTQualifiedNameValid($this->path)) {
-            $msg = "Path must be a valid TQualifiedName: " . get_class($this);
+            $msg = "Path must be a valid TQualifiedName: ".get_class($this);
             return false;
         }
 
@@ -725,7 +725,7 @@ 
                 return false;
             }
             if (!$this->isObjectNullOrType($type, $this->$key)) {
-                $msg = 'Type mismatch - should be ' . $type . ", is " . get_class($this->$key) . ": " . get_class($this);
+                $msg = 'Type mismatch - should be '.$type.", is ".get_class($this->$key).": ".get_class($this);
                 return false;
             }
         }

Doc Comments +1 added lines, -1 removed lines

@@ -142,7 +142,7 @@
     /**
      * Sets a new binary
      *
-     * @param  mixed $binary
+     * @param  string $binary
      * @return self
      */
     public function setBinary($binary)

src/IsOKTraits/IsOKToolboxTrait.php

Spacing +3 added lines, -3 removed lines

@@ -75,7 +75,7 @@ 
             return true;
         }
         if (!$object instanceof $instanceOf) {
-            $msg = "Supplied object not an instance of " . $instanceOf . ": " . get_class($this);
+            $msg = "Supplied object not an instance of ".$instanceOf.": ".get_class($this);
             return false;
         }
         return $object->isOK($msg);
@@ -85,7 +85,7 @@ 
     {
         $result = $this->isValidArray($arr, $instanceOf, $minCount, $maxCount);
         if (!$result) {
-            $msg = "Supplied array not a valid array: " . get_class($this);
+            $msg = "Supplied array not a valid array: ".get_class($this);
             return false;
         }
 
@@ -117,7 +117,7 @@ 
         }
         foreach ($arr as $item) {
             if (!($item instanceof IsOK)) {
-                $msg = "Child item is not an instance of IsOK: " . get_class($this);
+                $msg = "Child item is not an instance of IsOK: ".get_class($this);
                 return false;
             }
             if (!$item->isOK($msg)) {

src/StringTraits/XSDTopLevelTrait.php

Spacing +1 added lines, -1 removed lines

@@ -82,7 +82,7 @@
             $rawDate = $input;
         }
 
-        return $rawDate->format('Y-m-d') . 'T' . $rawDate->format('H:i:s');
+        return $rawDate->format('Y-m-d').'T'.$rawDate->format('H:i:s');
     }
 
     public function hexBinary($input)

src/MetadataV3/edm/IsOKTraits/EDMSimpleTypeTrait.php

Spacing +1 added lines, -1 removed lines

@@ -14,7 +14,7 @@
     public function isEDMSimpleTypeValid($string)
     {
         if (!is_string($string)) {
-            $msg = "Input must be a string: " . get_class($this);
+            $msg = "Input must be a string: ".get_class($this);
             throw new \InvalidArgumentException($msg);
         }
         if (!in_array($string, static::$v3EDMSimpleType)) {

src/MetadataV3/edm/EntityContainer/AssociationSetAnonymousType.php

Doc Comments +2 added lines, -2 removed lines

@@ -111,7 +111,7 @@ 
     /**
      * isset end
      *
-     * @param  scalar $index
+     * @param  integer $index
      * @return boolean
      */
     public function issetEnd($index)
@@ -122,7 +122,7 @@ 
     /**
      * unset end
      *
-     * @param  scalar $index
+     * @param  integer $index
      * @return void
      */
     public function unsetEnd($index)

src/MetadataV3/edm/EntityContainer/FunctionImportAnonymousType.php

Spacing +1 added lines, -1 removed lines

@@ -146,7 +146,7 @@
             for ($j = $i + 1; $j < $numParms; $j++) {
                 assert(
                     $this->parameter[$j] instanceof TFunctionImportParameterType,
-                    get_class($this->parameter[$j]). ' ' . $j
+                    get_class($this->parameter[$j]).' '.$j
                 );
                 $inName = $this->parameter[$j]->getName();
                 if ($outName == $inName) {

src/MetadataV3/edm/IsOKTraits/TQualifiedNameTrait.php

Doc Comments +3 added lines

@@ -9,6 +9,9 @@
 {
     use xsdRestrictions;
 
+    /**
+     * @return boolean
+     */
     public function isTQualifiedNameValid($string)
     {
         assert($this instanceof IsOK);

src/MetadataV3/edm/IsOKTraits/TPropertyTypeTrait.php

Spacing +1 added lines, -1 removed lines

@@ -17,7 +17,7 @@
         //$regex = "/[\p{L}\p{Nl}][\p{L}\p{Nl}\p{Nd}\p{Mn}\p{Mc}\p{Pc}\p{Cf}]{0,}(\.[\p{L}\p{Nl}][\p{L}\p{Nl}\p{Nd}\p{Mn}\p{Mc}\p{Pc}\p{Cf}]{0,}){0,}/";
 
         if (!is_string($string)) {
-            $msg = "Input must be a string: " . get_class($this);
+            $msg = "Input must be a string: ".get_class($this);
             throw new \InvalidArgumentException($msg);
         }
         if (isset(static::$v3PropertyTypeCache[$string])) {

tests/MetadataManagerNavigationTest.php

Unused Use Statements -14 removed lines

@@ -2,21 +2,7 @@
 
 namespace AlgoWeb\ODataMetadata\Tests;
 
-use AlgoWeb\ODataMetadata\IsOK;
 use AlgoWeb\ODataMetadata\MetadataManager;
-use AlgoWeb\ODataMetadata\MetadataV3\edm\EntityContainer;
-use AlgoWeb\ODataMetadata\MetadataV3\edm\Schema;
-use AlgoWeb\ODataMetadata\MetadataV3\edm\TAssociationType;
-use AlgoWeb\ODataMetadata\MetadataV3\edm\TComplexTypePropertyType;
-use AlgoWeb\ODataMetadata\MetadataV3\edm\TComplexTypeType;
-use AlgoWeb\ODataMetadata\MetadataV3\edm\TEntityPropertyType;
-use AlgoWeb\ODataMetadata\MetadataV3\edm\TEntityTypeType;
-use AlgoWeb\ODataMetadata\MetadataV3\edm\TFunctionReturnTypeType;
-use AlgoWeb\ODataMetadata\MetadataV3\edm\TFunctionType;
-use AlgoWeb\ODataMetadata\MetadataV3\edm\TNavigationPropertyType;
-use AlgoWeb\ODataMetadata\MetadataV3\edm\TTextType;
-use AlgoWeb\ODataMetadata\MetadataV3\edmx\Edmx;
-use Mockery as m;
 
 class MetadataManagerNavigationTest extends \PHPUnit_Framework_TestCase
 {

Spacing +2 added lines, -2 removed lines

@@ -27,7 +27,7 @@ 
         $result = null;
 
         list($CategoryType, $result) = $metadataManager->addEntityType("Category");
-        $this->assertNotFalse($CategoryType, "Etype is false not type " . $metadataManager->getLastError());
+        $this->assertNotFalse($CategoryType, "Etype is false not type ".$metadataManager->getLastError());
         $metadataManager->addPropertyToEntityType($CategoryType, "CategoryID", "Int32", null, false, true, "Identity");
         $metadataManager->addPropertyToEntityType($CategoryType, "CategoryName", "String");
         $metadataManager->addPropertyToEntityType($CategoryType, "Description", "String");
@@ -113,7 +113,7 @@ 
         $this->assertTrue($metadataManager->getEdmx()->isOK($msg), $msg);
 
         $expectedRelation = "Data.Category_Products_Product_Category";
-        list($principalNav, ) = $metadataManager->addNavigationPropertyToEntityType(
+        list($principalNav,) = $metadataManager->addNavigationPropertyToEntityType(
             $CategoryType, "*", "Products", $ProductType, "1", "Category", ["CategoryID"], ["CategoryID"]
         );
         $this->assertEquals($expectedRelation, $principalNav->getRelationship());