TOperandTypeTest::testSetStringEmptyArrayAsString() - Code Metrics - Inspection of "Fix string thinko" - Algo-Web/ODataMetadata - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#109)

by Alex

created 2017-06-14 03:48 UTC

testSetStringEmptyArrayAsString() A

↳ Parent: TOperandTypeTest

Complexity

Conditions	2
Paths	2

Size

Total Lines	13
Code Lines	9

Duplication

Lines	13
Ratio	100 %

Importance

Changes

Metric	Value
dl	13
loc	13
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	9
nc	2
nop	0

<?php

namespace AlgoWeb\ODataMetadata\Tests\v3\edm;

use AlgoWeb\ODataMetadata\MetadataV3\edm\TOperandType;
use AlgoWeb\ODataMetadata\Tests\TestCase;

class TOperandTypeTest extends TestCase

{
    public function testSetStringNullString()
    {
        $foo = new TOperandType();
        $foo->setString(null);
        $this->assertEquals(null, $foo->getString());
    }

    public function testSetStringActualString()
    {
        $foo = new TOperandType();
        $foo->setString("string");
        $this->assertEquals('string', $foo->getString());
    }

    public function testSetStringEmptyArrayAsString()
    {
        $expected = "String must be a string";
        $actual = null;

        $foo = new TOperandType();
        try {
            $foo->setString([]);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        } catch (\InvalidArgumentException $e) {
            $actual = $e->getMessage();
        }
        $this->assertEquals($expected, $actual);
    }

    public function testSetStringNonEmptyArrayAsString()
    {
        $expected = "String must be a string";
        $actual = null;

        $foo = new TOperandType();
        try {
            $foo->setString(['a']);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        } catch (\InvalidArgumentException $e) {
            $actual = $e->getMessage();
        }
        $this->assertEquals($expected, $actual);
    }

    public function testSetStringObjectAsString()
    {
        $expected = "String must be a string";
        $actual = null;

        $foo = new TOperandType();
        try {
            $foo->setString(new \DateTime());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        } catch (\InvalidArgumentException $e) {
            $actual = $e->getMessage();
        }
        $this->assertEquals($expected, $actual);
    }
}


1		<?php
2
3		namespace AlgoWeb\ODataMetadata\Tests\v3\edm;
4
5		use AlgoWeb\ODataMetadata\MetadataV3\edm\TOperandType;
6		use AlgoWeb\ODataMetadata\Tests\TestCase;
7
8	View Code Duplication	class TOperandTypeTest extends TestCase
		0 ignored issues – show Duplication introduced 2017-06-14 03:53 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
9		{
10		public function testSetStringNullString()
11		{
12		$foo = new TOperandType();
13		$foo->setString(null);
14		$this->assertEquals(null, $foo->getString());
15		}
16
17		public function testSetStringActualString()
18		{
19		$foo = new TOperandType();
20		$foo->setString("string");
21		$this->assertEquals('string', $foo->getString());
22		}
23
24		public function testSetStringEmptyArrayAsString()
25		{
26		$expected = "String must be a string";
27		$actual = null;
28
29		$foo = new TOperandType();
30		try {
31		$foo->setString([]);
		1 ignored issue – show Documentation introduced 2017-06-14 03:53 UTC by Report Bug Copy Issue Report `array()` is of type `array`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
32		} catch (\InvalidArgumentException $e) {
33		$actual = $e->getMessage();
34		}
35		$this->assertEquals($expected, $actual);
36		}
37
38		public function testSetStringNonEmptyArrayAsString()
39		{
40		$expected = "String must be a string";
41		$actual = null;
42
43		$foo = new TOperandType();
44		try {
45		$foo->setString(['a']);
		1 ignored issue – show Documentation introduced 2017-06-14 03:53 UTC by Report Bug Copy Issue Report `array('a')` is of type `array<integer,string,{"0":"string"}>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
46		} catch (\InvalidArgumentException $e) {
47		$actual = $e->getMessage();
48		}
49		$this->assertEquals($expected, $actual);
50		}
51
52		public function testSetStringObjectAsString()
53		{
54		$expected = "String must be a string";
55		$actual = null;
56
57		$foo = new TOperandType();
58		try {
59		$foo->setString(new \DateTime());
		1 ignored issue – show Documentation introduced 2017-06-14 03:53 UTC by Report Bug Copy Issue Report `new \DateTime()` is of type `object<DateTime>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
60		} catch (\InvalidArgumentException $e) {
61		$actual = $e->getMessage();
62		}
63		$this->assertEquals($expected, $actual);
64		}
65		}
66

Algo-Web / ODataMetadata

Pull Request — master (#109)

testSetStringEmptyArrayAsString() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like