Algo-Web /
ODataMetadata
| Conditions | 15 |
| Paths | 1176 |
| Total Lines | 70 |
| Code Lines | 41 |
| Lines | 8 |
| Ratio | 11.43 % |
| Changes | 3 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 113 | public function isStructureOK(&$msg = null) |
||
| 114 | { |
||
| 115 | $entityTypeNames = []; |
||
| 116 | $associationNames = []; |
||
| 117 | $navigationProperties = []; |
||
| 118 | $assocationSets = []; |
||
| 119 | $namespaceLen = strlen($this->namespace); |
||
| 120 | if (0 != $namespaceLen) { |
||
| 121 | $namespaceLen++; |
||
| 122 | } |
||
| 123 | |||
| 124 | foreach ($this->getEntityType() as $entityType) { |
||
| 125 | $entityTypeNames[] = $entityType->getName(); |
||
| 126 | foreach ($entityType->getNavigationProperty() as $navigationProperty) { |
||
| 127 | $navigationProperties[substr($navigationProperty->getRelationship(), $namespaceLen)][] = $navigationProperty; |
||
| 128 | } |
||
| 129 | } |
||
| 130 | |||
| 131 | foreach ($this->association as $association) { |
||
| 132 | $associationNames[$association->getName()] = $association->getEnd(); |
||
| 133 | } |
||
| 134 | foreach ($this->getEntityContainer()[0]->getAssociationSet as $assocationSet) { |
||
| 135 | $assocationSets[substr($assocationSet->getAssociation(), $namespaceLen)] = $assocationSet->getEnd(); |
||
| 136 | } |
||
| 137 | |||
| 138 | |||
| 139 | $entitySets = $this->getEntityContainer()[0]->getEntitySet(); |
||
| 140 | foreach ($entitySets as $eset) { |
||
| 141 | $eSetType = $eset->getEntityType(); |
||
| 142 | /*if (substr($eSetType, 0, strlen($this->getNamespace())) != $this->getNamespace()) { |
||
| 143 | $msg = "Types for Entity Sets should have the namespace at the beginning " . __CLASS__; |
||
| 144 | die($this->getNamespace()); |
||
| 145 | return false; |
||
| 146 | }*/ |
||
| 147 | $eSetType = str_replace($this->getNamespace() . ".", "", $eSetType); |
||
| 148 | if (!in_array($eSetType, $entityTypeNames)) { |
||
| 149 | $msg = "entitySet Types should have a matching type name in entity Types"; |
||
| 150 | return false; |
||
| 151 | } |
||
| 152 | } |
||
| 153 | |||
| 154 | // Check Associations to assocationSets |
||
| 155 | if (count($assocationSets) != count($associationNames)) { |
||
| 156 | $msg = "we have " . count($assocationSets) . "assocation sets and " . count($associationNames) . " Assocations, they should be the same"; |
||
| 157 | } |
||
| 158 | if (count($associationNames) * 2 < $navigationProperties) { |
||
| 159 | $msg = "we have two many navigation propertys. should have no more then double the number of assocations."; |
||
| 160 | } |
||
| 161 | |||
| 162 | foreach ($associationNames as $assocationName => $assocationEnds) { |
||
| 163 | if (!array_key_exists($assocationName, $assocationSets)) { |
||
| 164 | $msg = "assocation " . $assocationName . " exists without matching assocationSet"; |
||
| 165 | return false; |
||
| 166 | } |
||
| 167 | |||
| 168 | if (!array_key_exists($assocationName, $navigationProperties)) { |
||
| 169 | $msg = "assocation " . $assocationName . " exists without matching Natvigation Property"; |
||
| 170 | return false; |
||
| 171 | } |
||
| 172 | View Code Duplication | if (!in_array($assocationSets[$assocationName][0]->getName, [$assocationEnds[0]->getName, $assocationEnds[1]->getName])) { |
|
| 173 | $msg = "assocation Set role " . $assocationSets[$assocationName][0]->getName . "lacks a matching property in the attached assocation"; |
||
| 174 | return false; |
||
| 175 | } |
||
| 176 | View Code Duplication | if (!in_array($assocationSets[$assocationName][1]->getName, [$assocationEnds[0]->getName, $assocationEnds[1]->getName])) { |
|
| 177 | $msg = "assocation Set role " . $assocationSets[$assocationName][0]->getName . "lacks a matching property in the attached assocation"; |
||
| 178 | return false; |
||
| 179 | } |
||
| 180 | } |
||
| 181 | return true; |
||
| 182 | } |
||
| 183 | |||
| 210 |
Loading history...
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.