Issues in IsOK.php - All Issues - Inspection of "Clean up codebase semantics" - Algo-Web/ODataMetadata - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 26efa5...f69765 )

by Alex

created 2017-04-30 09:34 UTC

IsOK.php (2 issues)

Labels

Duplication 2

Severity

Informational 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace AlgoWeb\ODataMetadata;

abstract class IsOK
{
    protected function isStringNotNullOrEmpty($str)
    {
        if (!$this->isStringNotNull($str)) {
            return false;
        }
        if (empty(trim($str))) {
            return false;
        }
        return true;
    }

    protected function isStringNotNull($str)
    {
        if (null == $str) {
            return false;
        }
        if (!is_string($str)) {
            return false;
        }
        return true;
    }

    protected function isNotNullInstanceOf($var, $instanceOf)

    {
        if (null == $var) {
            return false;
        }
        if (!($var instanceof $instanceOf)) {
            return false;
        }
        return true;
    }

    protected function isNullInstanceOf($var, $instanceOf)

    {
        if (null == $var) {
            return true;
        }
        if (!($var instanceof $instanceOf)) {
            return false;
        }
        return false;
    }

    protected function isValidArray($arr, $instanceOf, $minCount = -1, $maxCount = -1)
    {
        if (null == $arr) {
            return false;
        }
        if (!is_array($arr)) {
            return false;
        }
        $numberOfItem = count($arr);
        if (-1 != $minCount && $numberOfItem < $minCount) {
            return false;
        }
        if (-1 != $maxCount && $numberOfItem > $maxCount) {
            return false;
        }
        foreach ($arr as $item) {
            if (!($item instanceof $instanceOf)) {
                return false;
            }
        }
        return true;
    }

    protected function isChildArrayOK(array $arr, &$msg)
    {
        foreach ($arr as $item) {
            if (!($item instanceof IsOK)) {
                $msg = "Child item is not an instance of IsOK";
                return false;
            }
            if (!$item->isOK($msg)) {
                return false;
            }
        }
    }

    abstract protected function isOK(&$msg = null);

    protected function isURLValid($url)
    {
        if (!isStringNotNull($url)) {
            return false;
        }
        if (false === filter_var($url, FILTER_VALIDATE_URL)) {
            return false;
        }
        return true;
    }
}


1		<?php
2		namespace AlgoWeb\ODataMetadata;
3
4		abstract class IsOK
5		{
6		protected function isStringNotNullOrEmpty($str)
7		{
8		if (!$this->isStringNotNull($str)) {
9		return false;
10		}
11		if (empty(trim($str))) {
12		return false;
13		}
14		return true;
15		}
16
17		protected function isStringNotNull($str)
18		{
19		if (null == $str) {
20		return false;
21		}
22		if (!is_string($str)) {
23		return false;
24		}
25		return true;
26		}
27
28	View Code Duplication	protected function isNotNullInstanceOf($var, $instanceOf)
		0 ignored issues – show Duplication introduced 2017-04-29 15:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
29		{
30		if (null == $var) {
31		return false;
32		}
33		if (!($var instanceof $instanceOf)) {
34		return false;
35		}
36		return true;
37		}
38
39	View Code Duplication	protected function isNullInstanceOf($var, $instanceOf)
		0 ignored issues – show Duplication introduced 2017-04-29 15:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
40		{
41		if (null == $var) {
42		return true;
43		}
44		if (!($var instanceof $instanceOf)) {
45		return false;
46		}
47		return false;
48		}
49
50		protected function isValidArray($arr, $instanceOf, $minCount = -1, $maxCount = -1)
51		{
52		if (null == $arr) {
53		return false;
54		}
55		if (!is_array($arr)) {
56		return false;
57		}
58		$numberOfItem = count($arr);
59		if (-1 != $minCount && $numberOfItem < $minCount) {
60		return false;
61		}
62		if (-1 != $maxCount && $numberOfItem > $maxCount) {
63		return false;
64		}
65		foreach ($arr as $item) {
66		if (!($item instanceof $instanceOf)) {
67		return false;
68		}
69		}
70		return true;
71		}
72
73		protected function isChildArrayOK(array $arr, &$msg)
74		{
75		foreach ($arr as $item) {
76		if (!($item instanceof IsOK)) {
77		$msg = "Child item is not an instance of IsOK";
78		return false;
79		}
80		if (!$item->isOK($msg)) {
81		return false;
82		}
83		}
84		}
85
86		abstract protected function isOK(&$msg = null);
87
88		protected function isURLValid($url)
89		{
90		if (!isStringNotNull($url)) {
91		return false;
92		}
93		if (false === filter_var($url, FILTER_VALIDATE_URL)) {
94		return false;
95		}
96		return true;
97		}
98		}
99

Algo-Web / ODataMetadata

Push — master ( 26efa5...f69765 )

IsOK.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like