Conditions | 1 |
Paths | 1 |
Total Lines | 109 |
Code Lines | 92 |
Lines | 0 |
Ratio | 0 % |
Changes | 5 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
68 | public function testEntitysAndPropertiesAndNavigationProperties() |
||
69 | { |
||
70 | $msg = null; |
||
71 | $metadataManager = new MetadataManager(); |
||
72 | |||
73 | $CategoryType = $metadataManager->addEntityType("Category"); |
||
74 | $this->assertNotFalse($CategoryType, "Etype is false not type " . $metadataManager->getLastError()); |
||
75 | $metadataManager->addPropertyToEntityType($CategoryType, "CategoryID", "Int32", null, false, true, "Identity"); |
||
76 | $metadataManager->addPropertyToEntityType($CategoryType, "CategoryName", "String"); |
||
77 | $metadataManager->addPropertyToEntityType($CategoryType, "Description", "String"); |
||
78 | $metadataManager->addPropertyToEntityType($CategoryType, "Picture", "Binary"); |
||
79 | $this->assertTrue($metadataManager->getEdmx()->isOK($msg), $msg); |
||
80 | |||
81 | $CustomerDemographicType = $metadataManager->addEntityType("CustomerDemographic"); |
||
82 | $metadataManager->addPropertyToEntityType($CustomerDemographicType, "CustomerTypeID", "String", null, false, true); |
||
83 | $metadataManager->addPropertyToEntityType($CustomerDemographicType, "CustomerDesc", "String"); |
||
84 | $this->assertTrue($metadataManager->getEdmx()->isOK($msg), $msg); |
||
85 | |||
86 | $CustomerType = $metadataManager->addEntityType("Customer"); |
||
87 | $metadataManager->addPropertyToEntityType($CustomerType, "CustomerID", "String", null, false, true); |
||
88 | $metadataManager->addPropertyToEntityType($CustomerType, "CompanyName", "String"); |
||
89 | $metadataManager->addPropertyToEntityType($CustomerType, "ContactName", "String"); |
||
90 | $metadataManager->addPropertyToEntityType($CustomerType, "ContactTitle", "String"); |
||
91 | $metadataManager->addPropertyToEntityType($CustomerType, "Address", "String"); |
||
92 | $metadataManager->addPropertyToEntityType($CustomerType, "City", "String"); |
||
93 | $metadataManager->addPropertyToEntityType($CustomerType, "Region", "String"); |
||
94 | $metadataManager->addPropertyToEntityType($CustomerType, "PostalCode", "String"); |
||
95 | $metadataManager->addPropertyToEntityType($CustomerType, "Country", "String"); |
||
96 | $metadataManager->addPropertyToEntityType($CustomerType, "Phone", "String"); |
||
97 | $metadataManager->addPropertyToEntityType($CustomerType, "Fax", "String"); |
||
98 | $this->assertTrue($metadataManager->getEdmx()->isOK($msg), $msg); |
||
99 | |||
100 | $EmployeeType = $metadataManager->addEntityType("Employee"); |
||
101 | $metadataManager->addPropertyToEntityType($EmployeeType, "EmployeeID", "Int32", null, false, true, "Identity"); |
||
102 | $metadataManager->addPropertyToEntityType($EmployeeType, "LastName", "String"); |
||
103 | $metadataManager->addPropertyToEntityType($EmployeeType, "FirstName", "String"); |
||
104 | $metadataManager->addPropertyToEntityType($EmployeeType, "Title", "String"); |
||
105 | $metadataManager->addPropertyToEntityType($EmployeeType, "TitleOfCourtesy", "String"); |
||
106 | $metadataManager->addPropertyToEntityType($EmployeeType, "BirthDate", "DateTime"); |
||
107 | $metadataManager->addPropertyToEntityType($EmployeeType, "HireDate", "DateTime"); |
||
108 | $metadataManager->addPropertyToEntityType($EmployeeType, "Address", "String"); |
||
109 | $metadataManager->addPropertyToEntityType($EmployeeType, "City", "String"); |
||
110 | $metadataManager->addPropertyToEntityType($EmployeeType, "Region", "String"); |
||
111 | $metadataManager->addPropertyToEntityType($EmployeeType, "PostalCode", "String"); |
||
112 | $metadataManager->addPropertyToEntityType($EmployeeType, "Country", "String"); |
||
113 | $metadataManager->addPropertyToEntityType($EmployeeType, "HomePhone", "String"); |
||
114 | $metadataManager->addPropertyToEntityType($EmployeeType, "Extension", "String"); |
||
115 | $metadataManager->addPropertyToEntityType($EmployeeType, "Photo", "Binary"); |
||
116 | $metadataManager->addPropertyToEntityType($EmployeeType, "Notes", "String"); |
||
117 | $metadataManager->addPropertyToEntityType($EmployeeType, "ReportsTo", "Int32"); |
||
118 | $metadataManager->addPropertyToEntityType($EmployeeType, "PhotoPath", "String"); |
||
119 | $this->assertTrue($metadataManager->getEdmx()->isOK($msg), $msg); |
||
120 | |||
121 | $Order_DetailType = $metadataManager->addEntityType("Order_Detail"); |
||
122 | $metadataManager->addPropertyToEntityType($Order_DetailType, "OrderID", "Int32", null, false, true); |
||
123 | $metadataManager->addPropertyToEntityType($Order_DetailType, "ProductID", "Int32", null, false, true); |
||
124 | $metadataManager->addPropertyToEntityType($Order_DetailType, "UnitPrice", "Decimal"); |
||
125 | $metadataManager->addPropertyToEntityType($Order_DetailType, "Quantity", "Int16"); |
||
126 | $metadataManager->addPropertyToEntityType($Order_DetailType, "Discount", "Single"); |
||
127 | $this->assertTrue($metadataManager->getEdmx()->isOK($msg), $msg); |
||
128 | |||
129 | $OrderType = $metadataManager->addEntityType("Order"); |
||
130 | $metadataManager->addPropertyToEntityType($OrderType, "OrderID", "Int32", null, false, true, "Identity"); |
||
131 | $metadataManager->addPropertyToEntityType($OrderType, "CustomerID", "String"); |
||
132 | $metadataManager->addPropertyToEntityType($OrderType, "EmployeeID", "Int32"); |
||
133 | $metadataManager->addPropertyToEntityType($OrderType, "OrderDate", "DateTime"); |
||
134 | $metadataManager->addPropertyToEntityType($OrderType, "RequiredDate", "DateTime"); |
||
135 | $metadataManager->addPropertyToEntityType($OrderType, "ShippedDate", "DateTime"); |
||
136 | $metadataManager->addPropertyToEntityType($OrderType, "ShipVia", "DateTime"); |
||
137 | $metadataManager->addPropertyToEntityType($OrderType, "Freight", "Decimal"); |
||
138 | $metadataManager->addPropertyToEntityType($OrderType, "ShipName", "String"); |
||
139 | $metadataManager->addPropertyToEntityType($OrderType, "ShipAddress", "String"); |
||
140 | $metadataManager->addPropertyToEntityType($OrderType, "ShipCity", "String"); |
||
141 | $metadataManager->addPropertyToEntityType($OrderType, "ShipRegion", "String"); |
||
142 | $metadataManager->addPropertyToEntityType($OrderType, "ShipPostalCode", "String"); |
||
143 | $metadataManager->addPropertyToEntityType($OrderType, "ShipCountry", "String"); |
||
144 | $this->assertTrue($metadataManager->getEdmx()->isOK($msg), $msg); |
||
145 | |||
146 | $ProductType = $metadataManager->addEntityType("Product"); |
||
147 | $metadataManager->addPropertyToEntityType($ProductType, "ProductID", "Int32", null, false, true, "Identity"); |
||
148 | $metadataManager->addPropertyToEntityType($ProductType, "ProductName", "String"); |
||
149 | $metadataManager->addPropertyToEntityType($ProductType, "SupplierID", "Int32"); |
||
150 | $metadataManager->addPropertyToEntityType($ProductType, "CategoryID", "Int32"); |
||
151 | $metadataManager->addPropertyToEntityType($ProductType, "QuantityPerUnit", "String"); |
||
152 | $metadataManager->addPropertyToEntityType($ProductType, "UnitPrice", "Decimal"); |
||
153 | $metadataManager->addPropertyToEntityType($ProductType, "UnitsInStock", "Int16"); |
||
154 | $metadataManager->addPropertyToEntityType($ProductType, "UnitsOnOrder", "Int16"); |
||
155 | $metadataManager->addPropertyToEntityType($ProductType, "ReorderLevel", "Int16"); |
||
156 | $metadataManager->addPropertyToEntityType($ProductType, "Discontinued", "Boolean"); |
||
157 | $this->assertTrue($metadataManager->getEdmx()->isOK($msg), $msg); |
||
158 | |||
159 | |||
160 | $metadataManager->addNavigationPropertyToEntityType( |
||
161 | $CategoryType, "*", "Products", $ProductType, "0..1", "Category", ["CategoryID"], ["CategoryID"] |
||
162 | ); |
||
163 | $metadataManager->addNavigationPropertyToEntityType( |
||
164 | $Order_DetailType, "1", "Order", $ProductType, "*", "Order_Details", ["OrderID"], ["CategoryID"] |
||
165 | ); |
||
166 | // <NavigationProperty Name="Order_Details" Relationship="NorthwindModel.FK_Order_Details_Products" ToRole="Order_Details" FromRole="Products"/> |
||
167 | |||
168 | |||
169 | $msg = null; |
||
170 | $edmx = $metadataManager->getEdmx(); |
||
171 | $this->assertTrue($edmx->isOK($msg), $msg); |
||
172 | $this->assertNull($msg); |
||
173 | |||
174 | $d = $metadataManager->getEdmxXML(); |
||
175 | $this->v3MetadataAgainstXSD($d); |
||
176 | } |
||
177 | |||
243 |
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVar
assignment in line 1 and the$higher
assignment in line 2 are dead. The first because$myVar
is never used and the second because$higher
is always overwritten for every possible time line.