Passed
Pull Request — master (#156)
by Alex
03:41
created
src/Edm/Validation/Internal/InterfaceValidator/VisitorOfIExpression.php 3 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@
 block discarded – undo
61 61
         $this->lookup[ExpressionKind::ValueTermReference()->getValue()]         = IValueTermReferenceExpression::class;
62 62
         $this->lookup[ExpressionKind::EntitySetReference()->getValue()]         = IEntitySetReferenceExpression::class;
63 63
         $this->lookup[ExpressionKind::EnumMemberReference()->getValue()]        = IEnumMemberReferenceExpression::class;
64
-        $this->lookup[ExpressionKind::If()->getValue()]                         = IIfExpression::class;
64
+        $this->lookup[ExpressionKind::If ()->getValue()]                         = IIfExpression::class;
65 65
         $this->lookup[ExpressionKind::AssertType()->getValue()]                 = IAssertTypeExpression::class;
66 66
         $this->lookup[ExpressionKind::IsType()->getValue()]                     = IIsTypeExpression::class;
67 67
         $this->lookup[ExpressionKind::FunctionApplication()->getValue()]        = IApplyExpression::class;
Please login to merge, or discard this patch.
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -61,7 +61,9 @@
 block discarded – undo
61 61
         $this->lookup[ExpressionKind::ValueTermReference()->getValue()]         = IValueTermReferenceExpression::class;
62 62
         $this->lookup[ExpressionKind::EntitySetReference()->getValue()]         = IEntitySetReferenceExpression::class;
63 63
         $this->lookup[ExpressionKind::EnumMemberReference()->getValue()]        = IEnumMemberReferenceExpression::class;
64
-        $this->lookup[ExpressionKind::If()->getValue()]                         = IIfExpression::class;
64
+        $this->lookup[ExpressionKind::If() {
65
+         ->getValue()]                         = IIfExpression::class;
66
+        }
65 67
         $this->lookup[ExpressionKind::AssertType()->getValue()]                 = IAssertTypeExpression::class;
66 68
         $this->lookup[ExpressionKind::IsType()->getValue()]                     = IIsTypeExpression::class;
67 69
         $this->lookup[ExpressionKind::FunctionApplication()->getValue()]        = IApplyExpression::class;
Please login to merge, or discard this patch.
Upper-Lower-Casing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
         $this->lookup[ExpressionKind::DecimalConstant()->getValue()]            = IDecimalConstantExpression::class;
52 52
         $this->lookup[ExpressionKind::FloatingConstant()->getValue()]           = IFloatingConstantExpression::class;
53 53
         $this->lookup[ExpressionKind::GuidConstant()->getValue()]               = IGuidConstantExpression::class;
54
-        $this->lookup[ExpressionKind::Null()->getValue()]                       = INullExpression::class;
54
+        $this->lookup[ExpressionKind::null()->getValue()]                       = INullExpression::class;
55 55
         $this->lookup[ExpressionKind::Record()->getValue()]                     = IRecordExpression::class;
56 56
         $this->lookup[ExpressionKind::Collection()->getValue()]                 = ICollectionExpression::class;
57 57
         $this->lookup[ExpressionKind::Path()->getValue()]                       = IPathExpression::class;
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
         $this->lookup[ExpressionKind::ValueTermReference()->getValue()]         = IValueTermReferenceExpression::class;
62 62
         $this->lookup[ExpressionKind::EntitySetReference()->getValue()]         = IEntitySetReferenceExpression::class;
63 63
         $this->lookup[ExpressionKind::EnumMemberReference()->getValue()]        = IEnumMemberReferenceExpression::class;
64
-        $this->lookup[ExpressionKind::If()->getValue()]                         = IIfExpression::class;
64
+        $this->lookup[ExpressionKind::if()->getValue()]                         = IIfExpression::class;
65 65
         $this->lookup[ExpressionKind::AssertType()->getValue()]                 = IAssertTypeExpression::class;
66 66
         $this->lookup[ExpressionKind::IsType()->getValue()]                     = IIsTypeExpression::class;
67 67
         $this->lookup[ExpressionKind::FunctionApplication()->getValue()]        = IApplyExpression::class;
Please login to merge, or discard this patch.
Internal/InterfaceValidator/VisitorOfIStructuredTypeReference.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@
 block discarded – undo
14 14
     {
15 15
         assert($typeRef instanceof IStructuredTypeReference);
16 16
         return null !== $typeRef->getDefinition() && !$typeRef->getDefinition()->getTypeKind()->IsStructured()
17
-            ? [ InterfaceValidator::CreateTypeRefInterfaceTypeKindValueMismatchError($typeRef) ] : null;
17
+            ? [InterfaceValidator::CreateTypeRefInterfaceTypeKindValueMismatchError($typeRef)] : null;
18 18
     }
19 19
 
20 20
     public function forType(): string
Please login to merge, or discard this patch.
Validation/Internal/InterfaceValidator/VisitorOfITemporalTypeReference.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@
 block discarded – undo
17 17
         $primitive = $typeRef->getDefinition();
18 18
         assert($primitive instanceof IPrimitiveType);
19 19
         return null !== $typeRef->getDefinition() && !$primitive->getPrimitiveKind()->IsTemporal()
20
-            ? [ InterfaceValidator::CreateTypeRefInterfaceTypeKindValueMismatchError($typeRef) ] : null;
20
+            ? [InterfaceValidator::CreateTypeRefInterfaceTypeKindValueMismatchError($typeRef)] : null;
21 21
     }
22 22
 
23 23
     public function forType(): string
Please login to merge, or discard this patch.
Validation/Internal/InterfaceValidator/VisitorOfIComplexTypeReference.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@
 block discarded – undo
14 14
     {
15 15
         assert($typeRef instanceof IComplexTypeReference);
16 16
         return null !== $typeRef->getDefinition() && !$typeRef->getDefinition()->getTypeKind()->isComplex()
17
-            ? [ InterfaceValidator::CreateTypeRefInterfaceTypeKindValueMismatchError($typeRef) ] : null;
17
+            ? [InterfaceValidator::CreateTypeRefInterfaceTypeKindValueMismatchError($typeRef)] : null;
18 18
     }
19 19
 
20 20
     public function forType(): string
Please login to merge, or discard this patch.
Validation/Internal/InterfaceValidator/VisitorOfIStringTypeReference.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@
 block discarded – undo
17 17
         $primitive = $typeRef->getDefinition();
18 18
         assert($primitive instanceof IPrimitiveType);
19 19
         return null !== $typeRef->getDefinition() && !$primitive->getPrimitiveKind()->isString()
20
-            ? [ InterfaceValidator::CreateTypeRefInterfaceTypeKindValueMismatchError($typeRef) ] : null;
20
+            ? [InterfaceValidator::CreateTypeRefInterfaceTypeKindValueMismatchError($typeRef)] : null;
21 21
     }
22 22
 
23 23
     public function forType(): string
Please login to merge, or discard this patch.
StructuralPropertyInvalidPropertyTypeConcurrencyMode.php 1 patch
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -43,8 +43,7 @@
 block discarded – undo
43 43
                 StringConst::EdmModel_Validator_Semantic_InvalidPropertyTypeConcurrencyMode(
44 44
                     (
45 45
                         $propType->IsCollection() ?
46
-                        EdmConstants::Type_Collection :
47
-                        $key
46
+                        EdmConstants::Type_Collection : $key
48 47
                     )
49 48
                 )
50 49
             );
Please login to merge, or discard this patch.
IStructuralProperty/StructuralPropertyInvalidPropertyType.php 1 patch
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -24,8 +24,7 @@
 block discarded – undo
24 24
         assert($property instanceof IStructuralProperty);
25 25
         if ($property->getDeclaringType()->getTypeKind()->isRow()) {
26 26
             $validatedType = $property->getType()->IsCollection() ?
27
-                $property->getType()->AsCollection()->ElementType()->getDefinition() :
28
-                $property->getType()->getDefinition();
27
+                $property->getType()->AsCollection()->ElementType()->getDefinition() : $property->getType()->getDefinition();
29 28
 
30 29
             EdmUtil::checkArgumentNull($validatedType, 'validatedType');
31 30
             if (!$validatedType->getTypeKind()->isPrimitive() &&
Please login to merge, or discard this patch.
IDirectValueAnnotation/DirectValueAnnotationHasXmlSerializableName.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@
 block discarded – undo
36 36
             // Note: this check can be done without the try/catch block, but we need XmlConvert.IsStartNCNameChar and
37 37
             // XmlConvert.IsNCNameChar, which are not available in 3.5.
38 38
             if (!XmlConvert::VerifyNCName($annotation->getName())) {
39
-                $value         = $annotation->getValue() ;
39
+                $value         = $annotation->getValue();
40 40
                 $errorLocation = ($value === null || !($value instanceof IValue)) ? null : $value->Location();
41 41
                 $error         = new EdmError(
42 42
                     $errorLocation,
Please login to merge, or discard this patch.
src/Library/Expressions/EdmIfExpression.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@
 block discarded – undo
47 47
      */
48 48
     public function getExpressionKind(): ExpressionKind
49 49
     {
50
-        return ExpressionKind::If();
50
+        return ExpressionKind::If ();
51 51
     }
52 52
 
53 53
     /**
Please login to merge, or discard this patch.
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@
 block discarded – undo
47 47
      */
48 48
     public function getExpressionKind(): ExpressionKind
49 49
     {
50
-        return ExpressionKind::If();
50
+        return ExpressionKind::if();
51 51
     }
52 52
 
53 53
     /**
Please login to merge, or discard this patch.