Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
13 | View Code Duplication | class TOptionsType extends IsOK |
|
|
|||
14 | { |
||
15 | |||
16 | /** |
||
17 | * @property \AlgoWeb\ODataMetadata\MetadataV3\edmx\TDesignerPropertyType[] $designerInfoPropertySet |
||
18 | */ |
||
19 | private $designerInfoPropertySet = []; |
||
20 | |||
21 | /** |
||
22 | * Adds as designerProperty |
||
23 | * |
||
24 | * @return self |
||
25 | * @param \AlgoWeb\ODataMetadata\MetadataV3\edmx\TDesignerPropertyType $designerProperty |
||
26 | */ |
||
27 | public function addToDesignerInfoPropertySet(TDesignerPropertyType $designerProperty) |
||
32 | |||
33 | /** |
||
34 | * isset designerInfoPropertySet |
||
35 | * |
||
36 | * @param scalar $index |
||
37 | * @return boolean |
||
38 | */ |
||
39 | public function issetDesignerInfoPropertySet($index) |
||
43 | |||
44 | /** |
||
45 | * unset designerInfoPropertySet |
||
46 | * |
||
47 | * @param scalar $index |
||
48 | * @return void |
||
49 | */ |
||
50 | public function unsetDesignerInfoPropertySet($index) |
||
54 | |||
55 | /** |
||
56 | * Gets as designerInfoPropertySet |
||
57 | * |
||
58 | * @return \AlgoWeb\ODataMetadata\MetadataV3\edmx\TDesignerPropertyType[] |
||
59 | */ |
||
60 | public function getDesignerInfoPropertySet() |
||
64 | |||
65 | /** |
||
66 | * Sets a new designerInfoPropertySet |
||
67 | * |
||
68 | * @param \AlgoWeb\ODataMetadata\MetadataV3\edmx\TDesignerPropertyType[] $designerInfoPropertySet |
||
69 | * @return self |
||
70 | */ |
||
71 | public function setDesignerInfoPropertySet(array $designerInfoPropertySet) |
||
76 | |||
77 | public function isOK(&$msg = null) |
||
90 | } |
||
91 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.