TPropertyType - Code Metrics - Inspection of "Add string parameter->isOK checks for v3 ssdl name..." - Algo-Web/ODataMetadata - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 0f618b...fb6850 )

by Alex

created 2017-05-09 14:44 UTC

TPropertyType C

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	396
Duplicated Lines	25.76 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

Metric	Value
wmc	62
lcom	1
cbo	4
dl	102
loc	396
rs	5.9493
c	0
b	0
f	0

23 Methods

Rating	Name	Duplication	Size	Complexity
A	getName()	0	4	1
A	setName()	14	14	3
A	getType()	0	4	1
A	setType()	14	14	3
A	getNullable()	0	4	1
A	setNullable()	0	5	1
A	getDefaultValue()	0	4	1
A	setDefaultValue()	10	10	3
A	getMaxLength()	0	4	1
A	setMaxLength()	0	10	4
A	getFixedLength()	0	4	1
A	setFixedLength()	0	5	1
A	getPrecision()	0	4	1
A	setPrecision()	10	10	4
A	getScale()	0	4	1
A	setScale()	10	10	4
A	getUnicode()	0	4	1
A	setUnicode()	0	5	1
A	getCollation()	0	4	1
A	setCollation()	10	10	3
A	getSRID()	0	4	1
A	setSRID()	10	10	3
D	isOK()	24	47	21

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like TPropertyType often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use TPropertyType, and based on these observations, apply Extract Interface, too.

<?php

namespace AlgoWeb\ODataMetadata\MetadataV3\edm\ssdl;

use AlgoWeb\ODataMetadata\IsOK;
use AlgoWeb\ODataMetadata\MetadataV3\edm\ssdl\IsOKTraits\TPropertyTypeTrait;
use AlgoWeb\ODataMetadata\MetadataV3\edm\ssdl\IsOKTraits\TSimpleIdentifierTrait;

/**
 * Class representing TPropertyType
 *
 *
 * XSD Type: TProperty
 */
class TPropertyType extends IsOK
{
    use TSimpleIdentifierTrait, TPropertyTypeTrait, GEmptyElementExtensibilityTrait;
    /**
     * @property string $name
     */
    private $name = null;

    /**
     * @property string $type
     */
    private $type = null;

    /**
     * @property boolean $nullable
     */
    private $nullable = true;

    /**
     * @property string $defaultValue
     */
    private $defaultValue = null;

    /**
     * @property string $maxLength
     */
    private $maxLength = null;

    /**
     * @property boolean $fixedLength
     */
    private $fixedLength = null;

    /**
     * @property integer $precision
     */
    private $precision = null;

    /**
     * @property integer $scale
     */
    private $scale = null;

    /**
     * @property boolean $unicode
     */
    private $unicode = null;

    /**
     * @property string $collation
     */
    private $collation = null;

    /**
     * @property string $sRID
     */
    private $sRID = null;

    /**
     * Gets as name
     *
     * @return string
     */
    public function getName()
    {
        return $this->name;
    }

    /**
     * Sets a new name
     *
     * @param string $name
     * @return self
     */
    public function setName($name)

    {
        $msg = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if (!$this->isStringNotNullOrEmpty($name)) {
            $msg = "Name cannot be null or empty";
            throw new \InvalidArgumentException($msg);
        }
        if (!$this->isTSimpleIdentifierValid($name)) {
            $msg = "Name must be valid TSimpleIdentifier";
            throw new \InvalidArgumentException($msg);
        }
        $this->name = $name;
        return $this;
    }

    /**
     * Gets as type
     *
     * @return string
     */
    public function getType()
    {
        return $this->type;
    }

    /**
     * Sets a new type
     *
     * @param string $type
     * @return self
     */
    public function setType($type)

    {
        $msg = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if (!$this->isStringNotNullOrEmpty($type)) {
            $msg = "Type cannot be null or empty";
            throw new \InvalidArgumentException($msg);
        }
        if (!$this->isTPropertyTypeValid($type)) {
            $msg = "Type must be valid TPropertyType";
            throw new \InvalidArgumentException($msg);
        }
        $this->type = $type;
        return $this;
    }

    /**
     * Gets as nullable
     *
     * @return boolean
     */
    public function getNullable()
    {
        return $this->nullable;
    }

    /**
     * Sets a new nullable
     *
     * @param boolean $nullable
     * @return self
     */
    public function setNullable($nullable)
    {
        $this->nullable = boolval($nullable);
        return $this;
    }

    /**
     * Gets as defaultValue
     *
     * @return string
     */
    public function getDefaultValue()
    {
        return $this->defaultValue;
    }

    /**
     * Sets a new defaultValue
     *
     * @param string $defaultValue
     * @return self
     */
    public function setDefaultValue($defaultValue)

    {
        $msg = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if (null != $defaultValue && !$this->isStringNotNullOrEmpty($defaultValue)) {
            $msg = "Default value cannot be empty";
            throw new \InvalidArgumentException($msg);
        }
        $this->defaultValue = $defaultValue;
        return $this;
    }

    /**
     * Gets as maxLength
     *
     * @return string
     */
    public function getMaxLength()
    {
        return $this->maxLength;
    }

    /**
     * Sets a new maxLength
     *
     * @param string $maxLength
     * @return self
     */
    public function setMaxLength($maxLength)
    {
        $msg = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if (null != $maxLength && !(is_numeric($maxLength) && 0 <= $maxLength)) {
            $msg = "Max length must be numeric and non-negative";
            throw new \InvalidArgumentException($msg);
        }
        $this->maxLength = $maxLength;
        return $this;
    }

    /**
     * Gets as fixedLength
     *
     * @return boolean
     */
    public function getFixedLength()
    {
        return $this->fixedLength;
    }

    /**
     * Sets a new fixedLength
     *
     * @param boolean $fixedLength
     * @return self
     */
    public function setFixedLength($fixedLength)
    {
        $this->fixedLength = boolval($fixedLength);
        return $this;
    }

    /**
     * Gets as precision
     *
     * @return integer
     */
    public function getPrecision()
    {
        return $this->precision;
    }

    /**
     * Sets a new precision
     *
     * @param integer $precision
     * @return self
     */
    public function setPrecision($precision)

    {
        $msg = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if (null != $precision && !(is_numeric($precision) && 0 <= $precision)) {
            $msg = "Precision must be numeric and non-negative";
            throw new \InvalidArgumentException($msg);
        }
        $this->precision = $precision;
        return $this;
    }

    /**
     * Gets as scale
     *
     * @return integer
     */
    public function getScale()
    {
        return $this->scale;
    }

    /**
     * Sets a new scale
     *
     * @param integer $scale
     * @return self
     */
    public function setScale($scale)

    {
        $msg = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if (null != $scale && !(is_numeric($scale) && 0 <= $scale)) {
            $msg = "Scale must be numeric and non-negative";
            throw new \InvalidArgumentException($msg);
        }
        $this->scale = $scale;
        return $this;
    }

    /**
     * Gets as unicode
     *
     * @return boolean
     */
    public function getUnicode()
    {
        return $this->unicode;
    }

    /**
     * Sets a new unicode
     *
     * @param boolean $unicode
     * @return self
     */
    public function setUnicode($unicode)
    {
        $this->unicode = $unicode;
        return $this;
    }

    /**
     * Gets as collation
     *
     * @return string
     */
    public function getCollation()
    {
        return $this->collation;
    }

    /**
     * Sets a new collation
     *
     * @param string $collation
     * @return self
     */
    public function setCollation($collation)

    {
        $msg = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if (null != $collation && !$this->isStringNotNullOrEmpty($collation)) {
            $msg = "Collation value cannot be empty";
            throw new \InvalidArgumentException($msg);
        }
        $this->collation = $collation;
        return $this;
    }

    /**
     * Gets as sRID
     *
     * @return string
     */
    public function getSRID()
    {
        return $this->sRID;
    }

    /**
     * Sets a new sRID
     *
     * @param string $sRID
     * @return self
     */
    public function setSRID($sRID)

    {
        $msg = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if (null != $sRID && !$this->isStringNotNullOrEmpty($sRID)) {
            $msg = "SRID value cannot be empty";
            throw new \InvalidArgumentException($msg);
        }
        $this->sRID = $sRID;
        return $this;
    }

    public function isOK(&$msg = null)
    {
        if (!$this->isStringNotNullOrEmpty($this->name)) {
            $msg = "Name cannot be null or empty";
            return false;
        }
        if (!$this->isStringNotNullOrEmpty($this->type)) {
            $msg = "Type cannot be null or empty";
            return false;
        }
        if (null != $this->defaultValue && !$this->isStringNotNullOrEmpty($this->defaultValue)) {

            $msg = "Default value cannot be empty";
            return false;
        }
        if (null != $this->sRID && !$this->isStringNotNullOrEmpty($this->sRID)) {

            $msg = "SRID value cannot be empty";
            return false;
        }
        if (null != $this->collation && !$this->isStringNotNullOrEmpty($this->collation)) {

            $msg = "Collation value cannot be empty";
            return false;
        }
        if (null != $this->maxLength && !(is_numeric($this->maxLength) && 0 <= $this->maxLength)) {

            $msg = "Max length must be numeric and non-negative";
            return false;
        }
        if (null != $this->precision && !(is_numeric($this->precision) && 0 <= $this->precision)) {

            $msg = "Precision must be numeric and non-negative";
            return false;
        }
        if (null != $this->scale && !(is_numeric($this->scale) && 0 <= $this->scale)) {

            $msg = "Scale must be numeric and non-negative";
            return false;
        }
        if (!$this->isTSimpleIdentifierValid($this->name)) {
            $msg = "Name must be valid TSimpleIdentifier";
            return false;
        }
        if (!$this->isTPropertyTypeValid($this->type)) {
            $msg = "Type must be valid TPropertyType";
            return false;
        }
        if (!$this->isExtensibilityElementOK($msg)) {
            return false;
        }
        return true;
    }
}


1		<?php
2
3		namespace AlgoWeb\ODataMetadata\MetadataV3\edm\ssdl;
4
5		use AlgoWeb\ODataMetadata\IsOK;
6		use AlgoWeb\ODataMetadata\MetadataV3\edm\ssdl\IsOKTraits\TPropertyTypeTrait;
7		use AlgoWeb\ODataMetadata\MetadataV3\edm\ssdl\IsOKTraits\TSimpleIdentifierTrait;
8
9		/**
10		* Class representing TPropertyType
11		*
12		*
13		* XSD Type: TProperty
14		*/
15		class TPropertyType extends IsOK
16		{
17		use TSimpleIdentifierTrait, TPropertyTypeTrait, GEmptyElementExtensibilityTrait;
18		/**
19		* @property string $name
20		*/
21		private $name = null;
22
23		/**
24		* @property string $type
25		*/
26		private $type = null;
27
28		/**
29		* @property boolean $nullable
30		*/
31		private $nullable = true;
32
33		/**
34		* @property string $defaultValue
35		*/
36		private $defaultValue = null;
37
38		/**
39		* @property string $maxLength
40		*/
41		private $maxLength = null;
42
43		/**
44		* @property boolean $fixedLength
45		*/
46		private $fixedLength = null;
47
48		/**
49		* @property integer $precision
50		*/
51		private $precision = null;
52
53		/**
54		* @property integer $scale
55		*/
56		private $scale = null;
57
58		/**
59		* @property boolean $unicode
60		*/
61		private $unicode = null;
62
63		/**
64		* @property string $collation
65		*/
66		private $collation = null;
67
68		/**
69		* @property string $sRID
70		*/
71		private $sRID = null;
72
73		/**
74		* Gets as name
75		*
76		* @return string
77		*/
78		public function getName()
79		{
80		return $this->name;
81		}
82
83		/**
84		* Sets a new name
85		*
86		* @param string $name
87		* @return self
88		*/
89	View Code Duplication	public function setName($name)
		0 ignored issues – show Duplication introduced 2017-05-09 14:54 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
90		{
91		$msg = null;
		0 ignored issues – show Unused Code introduced 2017-05-09 14:54 UTC by Report Bug Copy Issue Report `$msg` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
92		if (!$this->isStringNotNullOrEmpty($name)) {
93		$msg = "Name cannot be null or empty";
94		throw new \InvalidArgumentException($msg);
95		}
96		if (!$this->isTSimpleIdentifierValid($name)) {
97		$msg = "Name must be valid TSimpleIdentifier";
98		throw new \InvalidArgumentException($msg);
99		}
100		$this->name = $name;
101		return $this;
102		}
103
104		/**
105		* Gets as type
106		*
107		* @return string
108		*/
109		public function getType()
110		{
111		return $this->type;
112		}
113
114		/**
115		* Sets a new type
116		*
117		* @param string $type
118		* @return self
119		*/
120	View Code Duplication	public function setType($type)
		0 ignored issues – show Duplication introduced 2017-05-09 14:54 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
121		{
122		$msg = null;
		0 ignored issues – show Unused Code introduced 2017-05-09 14:54 UTC by Report Bug Copy Issue Report `$msg` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
123		if (!$this->isStringNotNullOrEmpty($type)) {
124		$msg = "Type cannot be null or empty";
125		throw new \InvalidArgumentException($msg);
126		}
127		if (!$this->isTPropertyTypeValid($type)) {
128		$msg = "Type must be valid TPropertyType";
129		throw new \InvalidArgumentException($msg);
130		}
131		$this->type = $type;
132		return $this;
133		}
134
135		/**
136		* Gets as nullable
137		*
138		* @return boolean
139		*/
140		public function getNullable()
141		{
142		return $this->nullable;
143		}
144
145		/**
146		* Sets a new nullable
147		*
148		* @param boolean $nullable
149		* @return self
150		*/
151		public function setNullable($nullable)
152		{
153		$this->nullable = boolval($nullable);
154		return $this;
155		}
156
157		/**
158		* Gets as defaultValue
159		*
160		* @return string
161		*/
162		public function getDefaultValue()
163		{
164		return $this->defaultValue;
165		}
166
167		/**
168		* Sets a new defaultValue
169		*
170		* @param string $defaultValue
171		* @return self
172		*/
173	View Code Duplication	public function setDefaultValue($defaultValue)
		0 ignored issues – show Duplication introduced 2017-05-09 14:54 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
174		{
175		$msg = null;
		0 ignored issues – show Unused Code introduced 2017-05-09 14:54 UTC by Report Bug Copy Issue Report `$msg` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
176		if (null != $defaultValue && !$this->isStringNotNullOrEmpty($defaultValue)) {
177		$msg = "Default value cannot be empty";
178		throw new \InvalidArgumentException($msg);
179		}
180		$this->defaultValue = $defaultValue;
181		return $this;
182		}
183
184		/**
185		* Gets as maxLength
186		*
187		* @return string
188		*/
189		public function getMaxLength()
190		{
191		return $this->maxLength;
192		}
193
194		/**
195		* Sets a new maxLength
196		*
197		* @param string $maxLength
198		* @return self
199		*/
200		public function setMaxLength($maxLength)
201		{
202		$msg = null;
		0 ignored issues – show Unused Code introduced 2017-05-09 14:54 UTC by Report Bug Copy Issue Report `$msg` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
203		if (null != $maxLength && !(is_numeric($maxLength) && 0 <= $maxLength)) {
204		$msg = "Max length must be numeric and non-negative";
205		throw new \InvalidArgumentException($msg);
206		}
207		$this->maxLength = $maxLength;
208		return $this;
209		}
210
211		/**
212		* Gets as fixedLength
213		*
214		* @return boolean
215		*/
216		public function getFixedLength()
217		{
218		return $this->fixedLength;
219		}
220
221		/**
222		* Sets a new fixedLength
223		*
224		* @param boolean $fixedLength
225		* @return self
226		*/
227		public function setFixedLength($fixedLength)
228		{
229		$this->fixedLength = boolval($fixedLength);
230		return $this;
231		}
232
233		/**
234		* Gets as precision
235		*
236		* @return integer
237		*/
238		public function getPrecision()
239		{
240		return $this->precision;
241		}
242
243		/**
244		* Sets a new precision
245		*
246		* @param integer $precision
247		* @return self
248		*/
249	View Code Duplication	public function setPrecision($precision)
		0 ignored issues – show Duplication introduced 2017-05-09 14:54 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
250		{
251		$msg = null;
		0 ignored issues – show Unused Code introduced 2017-05-09 14:54 UTC by Report Bug Copy Issue Report `$msg` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
252		if (null != $precision && !(is_numeric($precision) && 0 <= $precision)) {
253		$msg = "Precision must be numeric and non-negative";
254		throw new \InvalidArgumentException($msg);
255		}
256		$this->precision = $precision;
257		return $this;
258		}
259
260		/**
261		* Gets as scale
262		*
263		* @return integer
264		*/
265		public function getScale()
266		{
267		return $this->scale;
268		}
269
270		/**
271		* Sets a new scale
272		*
273		* @param integer $scale
274		* @return self
275		*/
276	View Code Duplication	public function setScale($scale)
		0 ignored issues – show Duplication introduced 2017-05-09 14:54 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
277		{
278		$msg = null;
		0 ignored issues – show Unused Code introduced 2017-05-09 14:54 UTC by Report Bug Copy Issue Report `$msg` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
279		if (null != $scale && !(is_numeric($scale) && 0 <= $scale)) {
280		$msg = "Scale must be numeric and non-negative";
281		throw new \InvalidArgumentException($msg);
282		}
283		$this->scale = $scale;
284		return $this;
285		}
286
287		/**
288		* Gets as unicode
289		*
290		* @return boolean
291		*/
292		public function getUnicode()
293		{
294		return $this->unicode;
295		}
296
297		/**
298		* Sets a new unicode
299		*
300		* @param boolean $unicode
301		* @return self
302		*/
303		public function setUnicode($unicode)
304		{
305		$this->unicode = $unicode;
306		return $this;
307		}
308
309		/**
310		* Gets as collation
311		*
312		* @return string
313		*/
314		public function getCollation()
315		{
316		return $this->collation;
317		}
318
319		/**
320		* Sets a new collation
321		*
322		* @param string $collation
323		* @return self
324		*/
325	View Code Duplication	public function setCollation($collation)
		0 ignored issues – show Duplication introduced 2017-05-09 14:54 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
326		{
327		$msg = null;
		0 ignored issues – show Unused Code introduced 2017-05-09 14:54 UTC by Report Bug Copy Issue Report `$msg` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
328		if (null != $collation && !$this->isStringNotNullOrEmpty($collation)) {
329		$msg = "Collation value cannot be empty";
330		throw new \InvalidArgumentException($msg);
331		}
332		$this->collation = $collation;
333		return $this;
334		}
335
336		/**
337		* Gets as sRID
338		*
339		* @return string
340		*/
341		public function getSRID()
342		{
343		return $this->sRID;
344		}
345
346		/**
347		* Sets a new sRID
348		*
349		* @param string $sRID
350		* @return self
351		*/
352	View Code Duplication	public function setSRID($sRID)
		0 ignored issues – show Duplication introduced 2017-05-09 14:54 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
353		{
354		$msg = null;
		0 ignored issues – show Unused Code introduced 2017-05-09 14:54 UTC by Report Bug Copy Issue Report `$msg` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
355		if (null != $sRID && !$this->isStringNotNullOrEmpty($sRID)) {
356		$msg = "SRID value cannot be empty";
357		throw new \InvalidArgumentException($msg);
358		}
359		$this->sRID = $sRID;
360		return $this;
361		}
362
363		public function isOK(&$msg = null)
364		{
365		if (!$this->isStringNotNullOrEmpty($this->name)) {
366		$msg = "Name cannot be null or empty";
367		return false;
368		}
369		if (!$this->isStringNotNullOrEmpty($this->type)) {
370		$msg = "Type cannot be null or empty";
371		return false;
372		}
373	View Code Duplication	if (null != $this->defaultValue && !$this->isStringNotNullOrEmpty($this->defaultValue)) {
		0 ignored issues – show Duplication introduced 2017-05-01 17:02 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
374		$msg = "Default value cannot be empty";
375		return false;
376		}
377	View Code Duplication	if (null != $this->sRID && !$this->isStringNotNullOrEmpty($this->sRID)) {
		0 ignored issues – show Duplication introduced 2017-05-01 17:02 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
378		$msg = "SRID value cannot be empty";
379		return false;
380		}
381	View Code Duplication	if (null != $this->collation && !$this->isStringNotNullOrEmpty($this->collation)) {
		0 ignored issues – show Duplication introduced 2017-05-01 17:02 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
382		$msg = "Collation value cannot be empty";
383		return false;
384		}
385	View Code Duplication	if (null != $this->maxLength && !(is_numeric($this->maxLength) && 0 <= $this->maxLength)) {
		0 ignored issues – show Duplication introduced 2017-05-01 17:02 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
386		$msg = "Max length must be numeric and non-negative";
387		return false;
388		}
389	View Code Duplication	if (null != $this->precision && !(is_numeric($this->precision) && 0 <= $this->precision)) {
		0 ignored issues – show Duplication introduced 2017-05-01 17:02 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
390		$msg = "Precision must be numeric and non-negative";
391		return false;
392		}
393	View Code Duplication	if (null != $this->scale && !(is_numeric($this->scale) && 0 <= $this->scale)) {
		0 ignored issues – show Duplication introduced 2017-05-01 17:02 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
394		$msg = "Scale must be numeric and non-negative";
395		return false;
396		}
397		if (!$this->isTSimpleIdentifierValid($this->name)) {
398		$msg = "Name must be valid TSimpleIdentifier";
399		return false;
400		}
401		if (!$this->isTPropertyTypeValid($this->type)) {
402		$msg = "Type must be valid TPropertyType";
403		return false;
404		}
405		if (!$this->isExtensibilityElementOK($msg)) {
406		return false;
407		}
408		return true;
409		}
410		}
411

Algo-Web / ODataMetadata