TDataServicesType::issetSchema() - Code Metrics - Inspection of "Fix document failures - data service version and X..." - Algo-Web/ODataMetadata - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#95)

by Alex

created 2017-05-25 16:35 UTC

TDataServicesType::issetSchema() A

↳ Parent: TDataServicesType

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	1

<?php
namespace AlgoWeb\ODataMetadata\MetadataV3\edmx;

use AlgoWeb\ODataMetadata\IsOK;
use AlgoWeb\ODataMetadata\IsOKTraits\IsOKToolboxTrait;
use AlgoWeb\ODataMetadata\MetadataV3\edm\Schema;

class TDataServicesType extends IsOK
{
    use IsOKToolboxTrait;
    /**
     * @property \AlgoWeb\ODataMetadata\MetadataV3\edm\Schema[] $schema
     */
    private $schema = [];

    /**
     * @property string $maxDataServiceVersion
     */
    private $maxDataServiceVersion;

    /**
     * @property string $dataServiceVersion
     */
    private $dataServiceVersion;

    public function __construct($maxDataServiceVersion = '3.0', $dataServiceVersion = '3.0')
    {
        if ('3.0' == $this->maxDataServiceVersion && '4.0' == $this->dataServiceVersion) {

            $msg = "Data service version cannot be greater than maximum service version";
            throw new \InvalidArgumentException($msg);
        }
        $this->setDataServiceVersion($dataServiceVersion);
        $this->setMaxDataServiceVersion($maxDataServiceVersion);
    }

    /**
     * Gets as MaxDataServiceVersion
     *
     * @return string
     */
    public function getMaxDataServiceVersion()
    {
        return $this->maxDataServiceVersion;
    }

    /**
     * Sets a new DataServiceVersion
     *
     * @param string $maxDataServiceVersion
     * @return self
     */
    public function setMaxDataServiceVersion($maxDataServiceVersion)
    {
        $maxDataValid = ['3.0', '4.0'];
        if (!in_array($maxDataServiceVersion, $maxDataValid)) {
            $msg = "Maximum data service version must be 3.0 or 4.0";
            throw new \InvalidArgumentException($msg);
        }
        $this->maxDataServiceVersion = $maxDataServiceVersion;
        return $this;
    }

    /**
     * Gets as DataServiceVersion
     *
     * @return string
     */
    public function getDataServiceVersion()
    {
        return $this->dataServiceVersion;
    }

    /**
     * Sets a new DataServiceVersion
     *
     * @param string $dataServiceVersion
     * @return self
     */
    public function setDataServiceVersion($dataServiceVersion)
    {
        $dataValid = ['1.0', '2.0', '3.0', '4.0'];
        if (!in_array($dataServiceVersion, $dataValid)) {
            $msg = "Data service version must be 1.0, 2.0, 3.0 or 4.0";
            throw new \InvalidArgumentException($msg);
        }
        $this->dataServiceVersion = $dataServiceVersion;
        return $this;
    }
    /**
     * Adds as schema
     *
     * @return self
     * @param \AlgoWeb\ODataMetadata\MetadataV3\edm\Schema $schema
     */
    public function addToSchema(Schema $schema)
    {
        $msg = null;
        if (!$schema->isOK($msg)) {
            throw new \InvalidArgumentException($msg);
        }
        $this->schema[] = $schema;
        return $this;
    }

    /**
     * isset schema
     *
     * @param scalar $index
     * @return boolean
     */
    public function issetSchema($index)
    {
        return isset($this->schema[$index]);
    }

    /**
     * unset schema
     *
     * @param scalar $index
     * @return void
     */
    public function unsetSchema($index)
    {
        unset($this->schema[$index]);
    }

    /**
     * Gets as schema
     *
     * @return \AlgoWeb\ODataMetadata\MetadataV3\edm\Schema[]
     */
    public function getSchema()
    {
        return $this->schema;
    }

    /**
     * Sets a new schema
     *
     * @param \AlgoWeb\ODataMetadata\MetadataV3\edm\Schema[] $dataServices
     * @return self
     */
    public function setSchema(array $dataServices)
    {
        if (!$this->isValidArrayOK(
            $dataServices,
            '\AlgoWeb\ODataMetadata\MetadataV3\edm\Schema'
        )) {
            $msg = "Data services array not a valid array";
            throw new \InvalidArgumentException($msg);
        }
        $this->dataServices = $dataServices;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        return $this;
    }

    public function isOK(&$msg = null)
    {
        $dataValid = ['1.0', '2.0', '3.0', '4.0'];
        $maxDataValid = ['3.0', '4.0'];
        if (!in_array($this->maxDataServiceVersion, $maxDataValid)) {
            $msg = "Maximum data service version must be 3.0 or 4.0";
            return false;
        }
        if (!in_array($this->dataServiceVersion, $dataValid)) {
            $msg = "Data service version must be 1.0, 2.0, 3.0 or 4.0";
            return false;
        }
        if ('3.0' == $this->maxDataServiceVersion && '4.0' == $this->dataServiceVersion) {

            $msg = "Data service version cannot be greater than maximum service version";
            return false;
        }

        if (!$this->isValidArrayOK($this->schema, '\AlgoWeb\ODataMetadata\MetadataV3\edm\Schema', $msg, 1)) {
            return false;
        }

        return true;
    }
}


1		<?php
2		namespace AlgoWeb\ODataMetadata\MetadataV3\edmx;
3
4		use AlgoWeb\ODataMetadata\IsOK;
5		use AlgoWeb\ODataMetadata\IsOKTraits\IsOKToolboxTrait;
6		use AlgoWeb\ODataMetadata\MetadataV3\edm\Schema;
7
8		class TDataServicesType extends IsOK
9		{
10		use IsOKToolboxTrait;
11		/**
12		* @property \AlgoWeb\ODataMetadata\MetadataV3\edm\Schema[] $schema
13		*/
14		private $schema = [];
15
16		/**
17		* @property string $maxDataServiceVersion
18		*/
19		private $maxDataServiceVersion;
20
21		/**
22		* @property string $dataServiceVersion
23		*/
24		private $dataServiceVersion;
25
26		public function __construct($maxDataServiceVersion = '3.0', $dataServiceVersion = '3.0')
27		{
28	View Code Duplication	if ('3.0' == $this->maxDataServiceVersion && '4.0' == $this->dataServiceVersion) {
		1 ignored issue – show Duplication introduced 2017-05-25 16:39 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
29		$msg = "Data service version cannot be greater than maximum service version";
30		throw new \InvalidArgumentException($msg);
31		}
32		$this->setDataServiceVersion($dataServiceVersion);
33		$this->setMaxDataServiceVersion($maxDataServiceVersion);
34		}
35
36		/**
37		* Gets as MaxDataServiceVersion
38		*
39		* @return string
40		*/
41		public function getMaxDataServiceVersion()
42		{
43		return $this->maxDataServiceVersion;
44		}
45
46		/**
47		* Sets a new DataServiceVersion
48		*
49		* @param string $maxDataServiceVersion
50		* @return self
51		*/
52		public function setMaxDataServiceVersion($maxDataServiceVersion)
53		{
54		$maxDataValid = ['3.0', '4.0'];
55		if (!in_array($maxDataServiceVersion, $maxDataValid)) {
56		$msg = "Maximum data service version must be 3.0 or 4.0";
57		throw new \InvalidArgumentException($msg);
58		}
59		$this->maxDataServiceVersion = $maxDataServiceVersion;
60		return $this;
61		}
62
63		/**
64		* Gets as DataServiceVersion
65		*
66		* @return string
67		*/
68		public function getDataServiceVersion()
69		{
70		return $this->dataServiceVersion;
71		}
72
73		/**
74		* Sets a new DataServiceVersion
75		*
76		* @param string $dataServiceVersion
77		* @return self
78		*/
79		public function setDataServiceVersion($dataServiceVersion)
80		{
81		$dataValid = ['1.0', '2.0', '3.0', '4.0'];
82		if (!in_array($dataServiceVersion, $dataValid)) {
83		$msg = "Data service version must be 1.0, 2.0, 3.0 or 4.0";
84		throw new \InvalidArgumentException($msg);
85		}
86		$this->dataServiceVersion = $dataServiceVersion;
87		return $this;
88		}
89		/**
90		* Adds as schema
91		*
92		* @return self
93		* @param \AlgoWeb\ODataMetadata\MetadataV3\edm\Schema $schema
94		*/
95		public function addToSchema(Schema $schema)
96		{
97		$msg = null;
98		if (!$schema->isOK($msg)) {
99		throw new \InvalidArgumentException($msg);
100		}
101		$this->schema[] = $schema;
102		return $this;
103		}
104
105		/**
106		* isset schema
107		*
108		* @param scalar $index
109		* @return boolean
110		*/
111		public function issetSchema($index)
112		{
113		return isset($this->schema[$index]);
114		}
115
116		/**
117		* unset schema
118		*
119		* @param scalar $index
120		* @return void
121		*/
122		public function unsetSchema($index)
123		{
124		unset($this->schema[$index]);
125		}
126
127		/**
128		* Gets as schema
129		*
130		* @return \AlgoWeb\ODataMetadata\MetadataV3\edm\Schema[]
131		*/
132		public function getSchema()
133		{
134		return $this->schema;
135		}
136
137		/**
138		* Sets a new schema
139		*
140		* @param \AlgoWeb\ODataMetadata\MetadataV3\edm\Schema[] $dataServices
141		* @return self
142		*/
143		public function setSchema(array $dataServices)
144		{
145		if (!$this->isValidArrayOK(
146		$dataServices,
147		'\AlgoWeb\ODataMetadata\MetadataV3\edm\Schema'
148		)) {
149		$msg = "Data services array not a valid array";
150		throw new \InvalidArgumentException($msg);
151		}
152		$this->dataServices = $dataServices;
		0 ignored issues – show Bug introduced 2017-05-25 16:39 UTC by Report Bug Copy Issue Report The property `dataServices` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
153		return $this;
154		}
155
156		public function isOK(&$msg = null)
157		{
158		$dataValid = ['1.0', '2.0', '3.0', '4.0'];
159		$maxDataValid = ['3.0', '4.0'];
160		if (!in_array($this->maxDataServiceVersion, $maxDataValid)) {
161		$msg = "Maximum data service version must be 3.0 or 4.0";
162		return false;
163		}
164		if (!in_array($this->dataServiceVersion, $dataValid)) {
165		$msg = "Data service version must be 1.0, 2.0, 3.0 or 4.0";
166		return false;
167		}
168	View Code Duplication	if ('3.0' == $this->maxDataServiceVersion && '4.0' == $this->dataServiceVersion) {
		1 ignored issue – show Duplication introduced 2017-05-25 16:39 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
169		$msg = "Data service version cannot be greater than maximum service version";
170		return false;
171		}
172
173		if (!$this->isValidArrayOK($this->schema, '\AlgoWeb\ODataMetadata\MetadataV3\edm\Schema', $msg, 1)) {
174		return false;
175		}
176
177		return true;
178		}
179		}
180

Algo-Web / ODataMetadata

Pull Request — master (#95)

TDataServicesType::issetSchema() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like