TFunctionImportParameterAttributesTrait::isTFunctionImportParameterAttributesValid() - Code Metrics - Inspection of "Hook up groups for V3 edm namespace" - Algo-Web/ODataMetadata - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( feaee9...2b3e4e )

by Alex

created 2017-05-03 15:40 UTC

isTFunctionImportParameterAttributesValid() C

↳ Parent: TFunctionImportParameterAttributesTrait

Complexity

Conditions	13
Paths	8

Size

Total Lines	33
Code Lines	23

Duplication

Lines	12
Ratio	36.36 %

Importance

Changes

Metric	Value
dl	12
loc	33
rs	5.1234
c	0
b	0
f	0
cc	13
eloc	23
nc	8
nop	1

How to fix Complexity

<?php

namespace AlgoWeb\ODataMetadata\MetadataV3\edm\Groups;

use AlgoWeb\ODataMetadata\MetadataV3\edm\IsOKTraits\TFunctionImportParameterAndReturnTypeTrait;
use AlgoWeb\ODataMetadata\MetadataV3\edm\IsOKTraits\TMaxLengthFacetTrait;
use AlgoWeb\ODataMetadata\MetadataV3\edm\IsOKTraits\TParameterModeTrait;
use AlgoWeb\ODataMetadata\MetadataV3\edm\IsOKTraits\TPrecisionFacetTrait;
use AlgoWeb\ODataMetadata\MetadataV3\edm\IsOKTraits\TScaleFacetTrait;
use AlgoWeb\ODataMetadata\MetadataV3\edm\IsOKTraits\TSimpleIdentifierTrait;
use AlgoWeb\ODataMetadata\MetadataV3\edm\IsOKTraits\TSridFacetTrait;

trait TFunctionImportParameterAttributesTrait
{
    use TSimpleIdentifierTrait, TParameterModeTrait, TFunctionImportParameterAndReturnTypeTrait, TMaxLengthFacetTrait,
        TPrecisionFacetTrait, TScaleFacetTrait, TSridFacetTrait;

    /*
     * @property string $name
     */
    private $name = null;

    /**
     * @property string $type
     */
    private $type = null;

    /**
     * @property string $mode
     */
    private $mode = null;

    /**
     * @property string $maxLength
     */
    private $maxLength = null;

    /**
     * @property integer $precision
     */
    private $precision = null;

    /**
     * @property integer $scale
     */
    private $scale = null;

    /**
     * @property string $sRID
     */
    private $sRID = null;

    /**
     * Gets as name
     *
     * @return string
     */
    public function getName()
    {
        return $this->name;
    }

    /**
     * Sets a new name
     *
     * @param string $name
     * @return self
     */
    public function setName($name)
    {
        $this->name = $name;
        return $this;
    }

    /**
     * Gets as type
     *
     * @return string
     */
    public function getType()
    {
        return $this->type;
    }

    /**
     * Sets a new type
     *
     * @param string $type
     * @return self
     */
    public function setType($type)
    {
        $this->type = $type;
        return $this;
    }

    /**
     * Gets as mode
     *
     * @return string
     */
    public function getMode()
    {
        return $this->mode;
    }

    /**
     * Sets a new mode
     *
     * @param string $mode
     * @return self
     */
    public function setMode($mode)
    {
        $this->mode = $mode;
        return $this;
    }

    /**
     * Gets as maxLength
     *
     * @return string
     */
    public function getMaxLength()
    {
        return $this->maxLength;
    }

    /**
     * Sets a new maxLength
     *
     * @param string $maxLength
     * @return self
     */
    public function setMaxLength($maxLength)
    {
        $this->maxLength = $maxLength;
        return $this;
    }

    /**
     * Gets as precision
     *
     * @return integer
     */
    public function getPrecision()
    {
        return $this->precision;
    }

    /**
     * Sets a new precision
     *
     * @param integer $precision
     * @return self
     */
    public function setPrecision($precision)
    {
        $this->precision = $precision;
        return $this;
    }

    /**
     * Gets as scale
     *
     * @return integer
     */
    public function getScale()
    {
        return $this->scale;
    }

    /**
     * Sets a new scale
     *
     * @param integer $scale
     * @return self
     */
    public function setScale($scale)
    {
        $this->scale = $scale;
        return $this;
    }

    /**
     * Gets as sRID
     *
     * @return string
     */
    public function getSRID()
    {
        return $this->sRID;
    }

    /**
     * Sets a new sRID
     *
     * @param string $sRID
     * @return self
     */
    public function setSRID($sRID)
    {
        $this->sRID = $sRID;
        return $this;
    }

    public function isTFunctionImportParameterAttributesValid(&$msg = null)
    {
        if (!$this->isTSimpleIdentifierValid($this->name)) {
            $msg = "Name must be a valid TSimpleIdentifier";
            return false;
        }
        if (!$this->isTFunctionImportParameterAndReturnTypeValid($this->type)) {
            $msg = "Type must be a valid TFunctionImportParameterAndReturnType";
            return false;
        }
        if (null != $this->mode && !$this->isTParameterModeValid($this->mode)) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $msg = "Mode must be a valid TParameterMode";
            return false;
        }
        if (null != $this->maxLength && !$this->isTMaxLengthFacetValid($this->maxLength)) {

            $msg = "Max length must be a valid TMaxLengthFacet";
            return false;
        }
        if (null != $this->precision && !$this->isTPrecisionFacetValid($this->precision)) {

            $msg = "Precision must be a valid TPrecisionFacet";
            return false;
        }
        if (null != $this->scale && !$this->isTPrecisionFacetValid($this->scale)) {
            $msg = "Scale must be a valid TScaleFacet";
            return false;
        }
        if (null != $this->sRID && !$this->isTPrecisionFacetValid($this->sRID)) {
            $msg = "SRID must be a valid TSRIDFacet";
            return false;
        }

        return true;
    }
}


1		<?php
2
3		namespace AlgoWeb\ODataMetadata\MetadataV3\edm\Groups;
4
5		use AlgoWeb\ODataMetadata\MetadataV3\edm\IsOKTraits\TFunctionImportParameterAndReturnTypeTrait;
6		use AlgoWeb\ODataMetadata\MetadataV3\edm\IsOKTraits\TMaxLengthFacetTrait;
7		use AlgoWeb\ODataMetadata\MetadataV3\edm\IsOKTraits\TParameterModeTrait;
8		use AlgoWeb\ODataMetadata\MetadataV3\edm\IsOKTraits\TPrecisionFacetTrait;
9		use AlgoWeb\ODataMetadata\MetadataV3\edm\IsOKTraits\TScaleFacetTrait;
10		use AlgoWeb\ODataMetadata\MetadataV3\edm\IsOKTraits\TSimpleIdentifierTrait;
11		use AlgoWeb\ODataMetadata\MetadataV3\edm\IsOKTraits\TSridFacetTrait;
12
13		trait TFunctionImportParameterAttributesTrait
14		{
15		use TSimpleIdentifierTrait, TParameterModeTrait, TFunctionImportParameterAndReturnTypeTrait, TMaxLengthFacetTrait,
16		TPrecisionFacetTrait, TScaleFacetTrait, TSridFacetTrait;
17
18		/*
19		* @property string $name
20		*/
21		private $name = null;
22
23		/**
24		* @property string $type
25		*/
26		private $type = null;
27
28		/**
29		* @property string $mode
30		*/
31		private $mode = null;
32
33		/**
34		* @property string $maxLength
35		*/
36		private $maxLength = null;
37
38		/**
39		* @property integer $precision
40		*/
41		private $precision = null;
42
43		/**
44		* @property integer $scale
45		*/
46		private $scale = null;
47
48		/**
49		* @property string $sRID
50		*/
51		private $sRID = null;
52
53		/**
54		* Gets as name
55		*
56		* @return string
57		*/
58		public function getName()
59		{
60		return $this->name;
61		}
62
63		/**
64		* Sets a new name
65		*
66		* @param string $name
67		* @return self
68		*/
69		public function setName($name)
70		{
71		$this->name = $name;
72		return $this;
73		}
74
75		/**
76		* Gets as type
77		*
78		* @return string
79		*/
80		public function getType()
81		{
82		return $this->type;
83		}
84
85		/**
86		* Sets a new type
87		*
88		* @param string $type
89		* @return self
90		*/
91		public function setType($type)
92		{
93		$this->type = $type;
94		return $this;
95		}
96
97		/**
98		* Gets as mode
99		*
100		* @return string
101		*/
102		public function getMode()
103		{
104		return $this->mode;
105		}
106
107		/**
108		* Sets a new mode
109		*
110		* @param string $mode
111		* @return self
112		*/
113		public function setMode($mode)
114		{
115		$this->mode = $mode;
116		return $this;
117		}
118
119		/**
120		* Gets as maxLength
121		*
122		* @return string
123		*/
124		public function getMaxLength()
125		{
126		return $this->maxLength;
127		}
128
129		/**
130		* Sets a new maxLength
131		*
132		* @param string $maxLength
133		* @return self
134		*/
135		public function setMaxLength($maxLength)
136		{
137		$this->maxLength = $maxLength;
138		return $this;
139		}
140
141		/**
142		* Gets as precision
143		*
144		* @return integer
145		*/
146		public function getPrecision()
147		{
148		return $this->precision;
149		}
150
151		/**
152		* Sets a new precision
153		*
154		* @param integer $precision
155		* @return self
156		*/
157		public function setPrecision($precision)
158		{
159		$this->precision = $precision;
160		return $this;
161		}
162
163		/**
164		* Gets as scale
165		*
166		* @return integer
167		*/
168		public function getScale()
169		{
170		return $this->scale;
171		}
172
173		/**
174		* Sets a new scale
175		*
176		* @param integer $scale
177		* @return self
178		*/
179		public function setScale($scale)
180		{
181		$this->scale = $scale;
182		return $this;
183		}
184
185		/**
186		* Gets as sRID
187		*
188		* @return string
189		*/
190		public function getSRID()
191		{
192		return $this->sRID;
193		}
194
195		/**
196		* Sets a new sRID
197		*
198		* @param string $sRID
199		* @return self
200		*/
201		public function setSRID($sRID)
202		{
203		$this->sRID = $sRID;
204		return $this;
205		}
206
207		public function isTFunctionImportParameterAttributesValid(&$msg = null)
208		{
209		if (!$this->isTSimpleIdentifierValid($this->name)) {
210		$msg = "Name must be a valid TSimpleIdentifier";
211		return false;
212		}
213		if (!$this->isTFunctionImportParameterAndReturnTypeValid($this->type)) {
214		$msg = "Type must be a valid TFunctionImportParameterAndReturnType";
215		return false;
216		}
217	View Code Duplication	if (null != $this->mode && !$this->isTParameterModeValid($this->mode)) {
		0 ignored issues – show Bug introduced 2017-05-03 15:44 UTC by Report Bug Copy Issue Report It seems like `isTParameterModeValid()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Duplication introduced 2017-05-03 15:45 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
218		$msg = "Mode must be a valid TParameterMode";
219		return false;
220		}
221	View Code Duplication	if (null != $this->maxLength && !$this->isTMaxLengthFacetValid($this->maxLength)) {
		0 ignored issues – show Duplication introduced 2017-05-03 15:45 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
222		$msg = "Max length must be a valid TMaxLengthFacet";
223		return false;
224		}
225	View Code Duplication	if (null != $this->precision && !$this->isTPrecisionFacetValid($this->precision)) {
		0 ignored issues – show Duplication introduced 2017-05-03 15:45 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
226		$msg = "Precision must be a valid TPrecisionFacet";
227		return false;
228		}
229		if (null != $this->scale && !$this->isTPrecisionFacetValid($this->scale)) {
230		$msg = "Scale must be a valid TScaleFacet";
231		return false;
232		}
233		if (null != $this->sRID && !$this->isTPrecisionFacetValid($this->sRID)) {
234		$msg = "SRID must be a valid TSRIDFacet";
235		return false;
236		}
237
238		return true;
239		}
240		}
241

Algo-Web / ODataMetadata

Push — master ( feaee9...2b3e4e )

isTFunctionImportParameterAttributesValid() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like