Connection::getSQL() - Code Metrics - Inspection of "work in progress (not working" - Algo-Web/ModelViews - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 357397...5befae )

by Christopher

created 2017-11-20 06:23 UTC

Connection::getSQL() A

↳ Parent: Connection

Complexity

Conditions	4
Paths	4

Size

Total Lines	14
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	14
rs	9.2
cc	4
eloc	9
nc	4
nop	2

<?php
namespace AlgoWeb\ModelViews\Database;

use Illuminate\Database\Connection as BaseConnection;
use Illuminate\Database\Eloquent\Model;

class Connection extends BaseConnection

{
    protected static $classes = [];

    protected static $information_schema = [];


    public static function RegisterTableToProvide($ModelOfTable)

    {
        self::$classes[] = $ModelOfTable;

        $currentISchemaTables = 0;
        if(array_key_exists("tables",self::$information_schema)){
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            $currentISchemaTables = count(self::$information_schema["tables"]);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        } else {
            self::$information_schema["tables"] = [];
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }
        self::$information_schema["tables"][$currentISchemaTables]["Model"] = $ModelOfTable;
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        self::$information_schema["tables"][$currentISchemaTables]["TABLE_NAME"] = $ModelOfTable::getTableName();  
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        self::$information_schema["tables"][$currentISchemaTables]["TABLE_SCHEMA"] = \Config::get('database.connections.'.\Config::get('database.default').'.database');
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
    }

    protected $normalizer;
    /**
     * Run a select statement and return a single result.
     *
     * @param  string $query
     * @param  array  $bindings
     * @return mixed
     */
    public function selectOne($query, $bindings = array())
    {
        $records = parent::select($query, $bindings);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        return $records;
    }
    /**
     * Run a select statement against the database.
     *
     * @param  string                                  $query
     * @param  array                                   $bindings
     * @return \Stidges\LaravelDbNormalizer\Collection

     */
    public function select($query, $bindings = array())
    {

//dd(self::$information_schema);

dd(self::getSQL($query,$bindings));
        $records = parent::select($query, $bindings);
dd($records);
        return $records;
    }

    private function ProcessSQL($query,$results){

    
    }

    private static function getSQL($sql, $bindings)
    {
        $needle = '?';
        foreach ($bindings as $replace){
            $pos = strpos($sql, $needle);
            if ($pos !== false) {
                if (gettype($replace) === "string") {
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                     $replace = ' "'.addslashes($replace).'" ';
                }
                $sql = substr_replace($sql, $replace, $pos, strlen($needle));

            }
        }
        return $sql;
    }
}


1			<?php
2			namespace AlgoWeb\ModelViews\Database;
3
4			use Illuminate\Database\Connection as BaseConnection;
5			use Illuminate\Database\Eloquent\Model;
6
7			class Connection extends BaseConnection
			0 ignored issues – show Coding Style introduced 2017-11-20 06:27 UTC by Report Bug Copy Issue Report The property $information_schema is not named in camelCase. This check marks property names that have not been written in camelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. Thus the name database connection string becomes `databaseConnectionString`. Loading history...
8			{
9			protected static $classes = [];
10
11			protected static $information_schema = [];
			0 ignored issues – show Coding Style introduced 2017-11-20 06:27 UTC by Report Bug Copy Issue Report `$information_schema` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
12
13			public static function RegisterTableToProvide($ModelOfTable)
			0 ignored issues – show Coding Style introduced 2017-11-18 10:58 UTC by Report Bug Copy Issue Report `function RegisterTableToProvide()` does not seem to conform to the naming convention (`^(?:[a-z]\|__)[a-zA-Z0-9]$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history... Coding Style introduced 2017-11-18 10:58 UTC by Report Bug Copy Issue Report `$ModelOfTable` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history... Coding Style Naming introduced 2017-11-18 10:58 UTC by Report Bug Copy Issue Report The parameter $ModelOfTable is not named in camelCase. This check marks parameter names that have not been written in camelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. Thus the name database connection string becomes `databaseConnectionString`. Loading history... Coding Style introduced 2017-11-18 10:37 UTC by Report Bug Copy Issue Report This method is not in camel caps format. This check looks for method names that are not written in camelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. Thus the name database connection seeker becomes `databaseConnectionSeeker`. Loading history...
14			{
15			self::$classes[] = $ModelOfTable;
			0 ignored issues – show Coding Style introduced 2017-11-20 06:27 UTC by Report Bug Copy Issue Report `$ModelOfTable` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
16			$currentISchemaTables = 0;
17			if(array_key_exists("tables",self::$information_schema)){
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-11-20 06:27 UTC by Report Bug Copy Issue Report The string literal `tables` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
18			$currentISchemaTables = count(self::$information_schema["tables"]);
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-11-20 06:27 UTC by Report Bug Copy Issue Report The string literal `tables` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
19			} else {
20			self::$information_schema["tables"] = [];
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-11-20 06:27 UTC by Report Bug Copy Issue Report The string literal `tables` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
21			}
22			self::$information_schema["tables"][$currentISchemaTables]["Model"] = $ModelOfTable;
			0 ignored issues – show Coding Style introduced 2017-11-20 06:27 UTC by Report Bug Copy Issue Report `$ModelOfTable` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history... Coding Style Comprehensibility introduced 2017-11-20 06:27 UTC by Report Bug Copy Issue Report The string literal `tables` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2017-11-20 06:27 UTC by Report Bug Copy Issue Report The string literal `Model` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
23			self::$information_schema["tables"][$currentISchemaTables]["TABLE_NAME"] = $ModelOfTable::getTableName();
			0 ignored issues – show Coding Style introduced 2017-11-20 06:27 UTC by Report Bug Copy Issue Report `$ModelOfTable` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history... Coding Style Comprehensibility introduced 2017-11-20 06:27 UTC by Report Bug Copy Issue Report The string literal `tables` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2017-11-20 06:27 UTC by Report Bug Copy Issue Report The string literal `TABLE_NAME` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
24			self::$information_schema["tables"][$currentISchemaTables]["TABLE_SCHEMA"] = \Config::get('database.connections.'.\Config::get('database.default').'.database');
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-11-20 06:27 UTC by Report Bug Copy Issue Report The string literal `tables` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2017-11-20 06:27 UTC by Report Bug Copy Issue Report The string literal `TABLE_SCHEMA` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style introduced 2017-11-20 06:27 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 168 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
25			}
26
27			protected $normalizer;
28			/**
29			* Run a select statement and return a single result.
30			*
31			* @param string $query
32			* @param array $bindings
33			* @return mixed
34			*/
35			public function selectOne($query, $bindings = array())
36			{
37			$records = parent::select($query, $bindings);
			0 ignored issues – show Comprehensibility Bug introduced 2017-11-18 10:58 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`select()` instead of `selectOne()`). Are you sure this is correct? If so, you might want to change this to `$this->select()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
38			return $records;
39			}
40			/**
41			* Run a select statement against the database.
42			*
43			* @param string $query
44			* @param array $bindings
45			* @return \Stidges\LaravelDbNormalizer\Collection
			0 ignored issues – show Documentation introduced 2017-11-18 10:58 UTC by Report Bug Copy Issue Report Should the return type not be `array`? Also, consider making the array more specific, something like `array<String>`, or `String[]`. This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. If the return type contains the type array, this check recommends the use of a more specific type like `String[]` or `array<String>`. Loading history...
46			*/
47			public function select($query, $bindings = array())
48			{
49
50			//dd(self::$information_schema);
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-11-20 06:27 UTC by Report Bug Copy Issue Report `86%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
51			dd(self::getSQL($query,$bindings));
52			$records = parent::select($query, $bindings);
53			dd($records);
54			return $records;
55			}
56
57			private function ProcessSQL($query,$results){
			0 ignored issues – show Coding Style introduced 2017-11-20 06:27 UTC by Report Bug Copy Issue Report `function ProcessSQL()` does not seem to conform to the naming convention (`^(?:[a-z]\|__)[a-zA-Z0-9]$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history... Unused Code introduced 2017-11-20 06:27 UTC by Report Bug Copy Issue Report The parameter `$query` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-11-20 06:27 UTC by Report Bug Copy Issue Report The parameter `$results` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Coding Style introduced 2017-11-20 06:27 UTC by Report Bug Copy Issue Report This method is not in camel caps format. This check looks for method names that are not written in camelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. Thus the name database connection seeker* becomes `databaseConnectionSeeker`. Loading history...
58
59			}
60
61			private static function getSQL($sql, $bindings)
62			{
63			$needle = '?';
64			foreach ($bindings as $replace){
65			$pos = strpos($sql, $needle);
66			if ($pos !== false) {
67			if (gettype($replace) === "string") {
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-11-20 06:27 UTC by Report Bug Copy Issue Report The string literal `string` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
68			$replace = ' "'.addslashes($replace).'" ';
69			}
70			$sql = substr_replace($sql, $replace, $pos, strlen($needle));
			0 ignored issues – show Coding Style introduced 2017-11-20 06:27 UTC by Report Bug Copy Issue Report Consider using a different name than the parameter `$sql`. This often makes code more readable. Loading history...
71			}
72			}
73			return $sql;
74			}
75			}
76

Algo-Web / ModelViews

Push — master ( 357397...5befae )

Connection::getSQL() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like