AlgoWeb\ModelViews\Database\Connection

Complexity

Total Complexity

3

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	RegisterTableToProvide()	0	3	1
A	selectOne()	0	5	1
A	select()	0	5	1

<?php
namespace AlgoWeb\ModelViews\Database;

use Illuminate\Database\Connection as BaseConnection;
use Illuminate\Database\Eloquent\Model;
class Connection extends BaseConnection
{
    protected static $classes;

    public static function RegisterTableToProvide(Model $ModelOfTable){

This method is not in camel caps format.

function RegisterTableToProvide() does not seem to conform to the naming convention (^(?:[a-z]|__)[a-zA-Z0-9]*$).

$ModelOfTable does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

The parameter $ModelOfTable is not used and could be removed.

The parameter $ModelOfTable is not named in camelCase.

    }

    protected $normalizer;
    /**
     * Run a select statement and return a single result.
     *
     * @param  string  $query
     * @param  array   $bindings
     * @return mixed
     */
    public function selectOne($query, $bindings = array())
    {
        $records = parent::select($query, $bindings);

It seems like you call parent on a different method (select() instead of selectOne()). Are you sure this is correct? If so, you might want to change this to $this->select().

        return $records;
    }
    /**
     * Run a select statement against the database.
     *
     * @param  string  $query
     * @param  array   $bindings
     * @return \Stidges\LaravelDbNormalizer\Collection

Should the return type not be array? Also, consider making the array more specific, something like array<String>, or String[].

     */
    public function select($query, $bindings = array())
    {
        $records = parent::select($query, $bindings);
        return $records;
    }
}